| Message ID | 20250421-b4-gs101_max77759_fg-v3-0-50cd8caf9017@uclouvain.be |
|---|---|
| Headers | show |
| Series | Google Pixel 6 (oriole): max77759 fuel gauge enablement and driver support | expand |
On Mon, 21 Apr 2025 20:13:31 +0200, Thomas Antoine wrote: > The Google Pixel 6 has a Maxim MAX77759 which provides a fuel gauge with > an interface with a lot in common with the Maxim max1720x. > > Modify the Maxim MAX1720x driver to be compatible with the Maxim MAX77759 > and enable it for the gs101-oriole board. > > The voltage, current, capacity, temperature and charge have all been > tested and show coherent results. The charge full design and capacity > equal the ones seen on android, the ratio between average charge and > average current does predict pretty accurately the time to empty under > a constant workload and temperature is coherent with the dynamic state > of the device. > > Health is not enabled as it always reports overheating. The time to empty > is wrong by about a factor 2 and is thus also disabled. > > Signed-off-by: Thomas Antoine <t.antoine@uclouvain.be> > > --- > Changes in v3: > - Update base tree to avoid conflicts > - Fix capacity computation for max1720x > - Add separate properties for the max7759 to disable non-functional ones > - Take TASKPERIOD into account for voltage computation of max77759 > - Simplify vcell computation (Dimitri Fedrau) > - Switch has_nvmem to bool and keep it only in chip_data (Dimitri Fedrau) > - Drop the yes_range from the write table (Sebastian Reichel) > - Add test_power_supply_properties.sh to cover letter (Sebastian Reichel) > - Switch back some changes to binding and actually use allOf:if: to > restrict constraints (Krzysztof Kozlowski) > - Fix style errors > - Link to v2: https://lore.kernel.org/r/20250102-b4-gs101_max77759_fg-v2-0-87959abeb7ff@uclouvain.be > > Changes in v2: > - Add fallback for voltage measurement (André Draszik) > - Add regmap for the max77759 (André Draszik) > - Add chip identification for the max77759 (André Draszik, Peter Griffin) > - Move RSense value to a devicetree property shunt-resistor-micro-ohms > (Dimitri Fedrau, André Draszik) > - Use allOf:if to narrow binding per variant (Krzysztof Kozlowski) > - Remove binding example (Krzysztof Kozlowski) > - Change defconfig order to follow savedefconfig (Krzysztof Kozlowski) > - Fix style errors > - Link to v1: https://lore.kernel.org/r/20241202-b4-gs101_max77759_fg-v1-0-98d2fa7bfe30@uclouvain.be > > tools/testing/selftests/power_supply/test_power_supply_properties.sh: > ok 1 max77759-fg.exists > ok 2 max77759-fg.uevent.NAME > ok 3 max77759-fg.sysfs.type > ok 4 max77759-fg.uevent.TYPE > ok 5 max77759-fg.sysfs.usb_type # SKIP > ok 6 max77759-fg.sysfs.online # SKIP > ok 7 max77759-fg.sysfs.present > ok 8 max77759-fg.sysfs.status # SKIP > ok 9 max77759-fg.sysfs.capacity > ok 10 max77759-fg.sysfs.capacity_level # SKIP > ok 11 max77759-fg.sysfs.model_name > ok 12 max77759-fg.sysfs.manufacturer > ok 13 max77759-fg.sysfs.serial_number # SKIP > ok 14 max77759-fg.sysfs.technology # SKIP > ok 15 max77759-fg.sysfs.cycle_count # SKIP > ok 16 max77759-fg.sysfs.scope # SKIP > ok 17 max77759-fg.sysfs.input_current_limit # SKIP(Dimitri Fedrau) > ok 18 max77759-fg.sysfs.input_voltage_limit # SKIP > ok 19 max77759-fg.sysfs.voltage_now > ok 20 max77759-fg.sysfs.voltage_min # SKIP > ok 21 max77759-fg.sysfs.voltage_max # SKIP > ok 22 max77759-fg.sysfs.voltage_min_design # SKIP > ok 23 max77759-fg.sysfs.voltage_max_design # SKIP > ok 24 max77759-fg.sysfs.current_now > ok 25 max77759-fg.sysfs.current_max # SKIP > ok 26 max77759-fg.sysfs.charge_now # SKIP > ok 27 max77759-fg.sysfs.charge_full > ok 28 max77759-fg.sysfs.charge_full_design > ok 29 max77759-fg.sysfs.power_now # SKIP > ok 30 max77759-fg.sysfs.energy_now # SKIP > ok 31 max77759-fg.sysfs.energy_full # SKIP > ok 32 max77759-fg.sysfs.energy_full_design # SKIP > ok 33 max77759-fg.sysfs.energy_full_design # SKIP > > --- > Thomas Antoine (5): > power: supply: correct capacity computation > power: supply: add support for max77759 fuel gauge > dt-bindings: power: supply: add max77759-fg flavor > arm64: defconfig: enable Maxim max1720x driver > arm64: dts: exynos: gs101-oriole: enable Maxim max77759 fuel gauge > > .../bindings/power/supply/maxim,max17201.yaml | 34 ++- > .../boot/dts/exynos/google/gs101-pixel-common.dtsi | 10 + > arch/arm64/configs/defconfig | 1 + > drivers/power/supply/max1720x_battery.c | 271 ++++++++++++++++++--- > 4 files changed, 280 insertions(+), 36 deletions(-) > --- > base-commit: e48e99b6edf41c69c5528aa7ffb2daf3c59ee105 > change-id: 20241202-b4-gs101_max77759_fg-402e231a4b33 > > Best regards, > -- > Thomas Antoine <t.antoine@uclouvain.be> > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade This patch series was applied (using b4) to base: Base: using specified base-commit e48e99b6edf41c69c5528aa7ffb2daf3c59ee105 If this is not the correct base, please add 'base-commit' tag (or use b4 which does this automatically) New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/exynos/' for 20250421-b4-gs101_max77759_fg-v3-0-50cd8caf9017@uclouvain.be: arch/arm64/boot/dts/exynos/google/gs101-raven.dtb: fuel-gauge@36 (maxim,max77759-fg): reg: [[54]] is too short from schema $id: http://devicetree.org/schemas/power/supply/maxim,max17201.yaml# arch/arm64/boot/dts/exynos/google/gs101-raven.dtb: fuel-gauge@36 (maxim,max77759-fg): reg-names: ['m5'] is too short from schema $id: http://devicetree.org/schemas/power/supply/maxim,max17201.yaml# arch/arm64/boot/dts/exynos/google/gs101-raven.dtb: fuel-gauge@36 (maxim,max77759-fg): Unevaluated properties are not allowed ('reg-names' was unexpected) from schema $id: http://devicetree.org/schemas/power/supply/maxim,max17201.yaml# arch/arm64/boot/dts/exynos/google/gs101-oriole.dtb: fuel-gauge@36 (maxim,max77759-fg): reg: [[54]] is too short from schema $id: http://devicetree.org/schemas/power/supply/maxim,max17201.yaml# arch/arm64/boot/dts/exynos/google/gs101-oriole.dtb: fuel-gauge@36 (maxim,max77759-fg): reg-names: ['m5'] is too short from schema $id: http://devicetree.org/schemas/power/supply/maxim,max17201.yaml# arch/arm64/boot/dts/exynos/google/gs101-oriole.dtb: fuel-gauge@36 (maxim,max77759-fg): Unevaluated properties are not allowed ('reg-names' was unexpected) from schema $id: http://devicetree.org/schemas/power/supply/maxim,max17201.yaml#
Hi Dimitri, On 4/22/25 11:46, Dimitri Fedrau wrote: > Hi Thomas, > > On Mon, Apr 21, 2025 at 08:13:32PM +0200, Thomas Antoine via B4 Relay wrote: >> From: Thomas Antoine <t.antoine@uclouvain.be> [...] >> -static int max172xx_capacity_to_ps(unsigned int reg) >> +static int max172xx_capacity_to_ps(unsigned int reg, >> + struct max1720x_device_info *info) >> { >> - return reg * 500; /* in uAh */ >> + return reg * (500000 / info->rsense); /* in uAh */ >> } >> >> /* >> >> -- >> 2.49.0 >> >> > thanks for finding this. > > Reviewed-by: Dimitri Fedrau <dimitri.fedrau@liebherr.com> > > Best regards, > Dimitri Fedrau I just realized I forgot to change the function calls in this patch, it is only changed in the next patch. This will not compile as the function call does not pass info as argument. I will change this in the next version. Best regards, Thomas Antoine
The Google Pixel 6 has a Maxim MAX77759 which provides a fuel gauge with an interface with a lot in common with the Maxim max1720x. Modify the Maxim MAX1720x driver to be compatible with the Maxim MAX77759 and enable it for the gs101-oriole board. The voltage, current, capacity, temperature and charge have all been tested and show coherent results. The charge full design and capacity equal the ones seen on android, the ratio between average charge and average current does predict pretty accurately the time to empty under a constant workload and temperature is coherent with the dynamic state of the device. Health is not enabled as it always reports overheating. The time to empty is wrong by about a factor 2 and is thus also disabled. Signed-off-by: Thomas Antoine <t.antoine@uclouvain.be> --- Changes in v3: - Update base tree to avoid conflicts - Fix capacity computation for max1720x - Add separate properties for the max7759 to disable non-functional ones - Take TASKPERIOD into account for voltage computation of max77759 - Simplify vcell computation (Dimitri Fedrau) - Switch has_nvmem to bool and keep it only in chip_data (Dimitri Fedrau) - Drop the yes_range from the write table (Sebastian Reichel) - Add test_power_supply_properties.sh to cover letter (Sebastian Reichel) - Switch back some changes to binding and actually use allOf:if: to restrict constraints (Krzysztof Kozlowski) - Fix style errors - Link to v2: https://lore.kernel.org/r/20250102-b4-gs101_max77759_fg-v2-0-87959abeb7ff@uclouvain.be Changes in v2: - Add fallback for voltage measurement (André Draszik) - Add regmap for the max77759 (André Draszik) - Add chip identification for the max77759 (André Draszik, Peter Griffin) - Move RSense value to a devicetree property shunt-resistor-micro-ohms (Dimitri Fedrau, André Draszik) - Use allOf:if to narrow binding per variant (Krzysztof Kozlowski) - Remove binding example (Krzysztof Kozlowski) - Change defconfig order to follow savedefconfig (Krzysztof Kozlowski) - Fix style errors - Link to v1: https://lore.kernel.org/r/20241202-b4-gs101_max77759_fg-v1-0-98d2fa7bfe30@uclouvain.be tools/testing/selftests/power_supply/test_power_supply_properties.sh: ok 1 max77759-fg.exists ok 2 max77759-fg.uevent.NAME ok 3 max77759-fg.sysfs.type ok 4 max77759-fg.uevent.TYPE ok 5 max77759-fg.sysfs.usb_type # SKIP ok 6 max77759-fg.sysfs.online # SKIP ok 7 max77759-fg.sysfs.present ok 8 max77759-fg.sysfs.status # SKIP ok 9 max77759-fg.sysfs.capacity ok 10 max77759-fg.sysfs.capacity_level # SKIP ok 11 max77759-fg.sysfs.model_name ok 12 max77759-fg.sysfs.manufacturer ok 13 max77759-fg.sysfs.serial_number # SKIP ok 14 max77759-fg.sysfs.technology # SKIP ok 15 max77759-fg.sysfs.cycle_count # SKIP ok 16 max77759-fg.sysfs.scope # SKIP ok 17 max77759-fg.sysfs.input_current_limit # SKIP(Dimitri Fedrau) ok 18 max77759-fg.sysfs.input_voltage_limit # SKIP ok 19 max77759-fg.sysfs.voltage_now ok 20 max77759-fg.sysfs.voltage_min # SKIP ok 21 max77759-fg.sysfs.voltage_max # SKIP ok 22 max77759-fg.sysfs.voltage_min_design # SKIP ok 23 max77759-fg.sysfs.voltage_max_design # SKIP ok 24 max77759-fg.sysfs.current_now ok 25 max77759-fg.sysfs.current_max # SKIP ok 26 max77759-fg.sysfs.charge_now # SKIP ok 27 max77759-fg.sysfs.charge_full ok 28 max77759-fg.sysfs.charge_full_design ok 29 max77759-fg.sysfs.power_now # SKIP ok 30 max77759-fg.sysfs.energy_now # SKIP ok 31 max77759-fg.sysfs.energy_full # SKIP ok 32 max77759-fg.sysfs.energy_full_design # SKIP ok 33 max77759-fg.sysfs.energy_full_design # SKIP --- Thomas Antoine (5): power: supply: correct capacity computation power: supply: add support for max77759 fuel gauge dt-bindings: power: supply: add max77759-fg flavor arm64: defconfig: enable Maxim max1720x driver arm64: dts: exynos: gs101-oriole: enable Maxim max77759 fuel gauge .../bindings/power/supply/maxim,max17201.yaml | 34 ++- .../boot/dts/exynos/google/gs101-pixel-common.dtsi | 10 + arch/arm64/configs/defconfig | 1 + drivers/power/supply/max1720x_battery.c | 271 ++++++++++++++++++--- 4 files changed, 280 insertions(+), 36 deletions(-) --- base-commit: e48e99b6edf41c69c5528aa7ffb2daf3c59ee105 change-id: 20241202-b4-gs101_max77759_fg-402e231a4b33 Best regards,