| Message ID | 20250506-csl42x-v3-0-e9496db544c4@nxp.com |
|---|---|
| Headers | show |
| Series | ASoC: codec: cs42l[56,73,52]: Convert to GPIO descriptors | expand |
On Tue, 06 May 2025 15:29:30 +0800, Peng Fan (OSS) wrote: > This patchset is separate from [1], and not merging changes in one > patch. So separate changes into three patches for each chip. > - sort headers > - Drop legacy platform support > - Convert to GPIO descriptors > > of_gpio.h is deprecated, update the driver to use GPIO descriptors. > - Use devm_gpiod_get_optional to get GPIO descriptor with default > polarity GPIOD_OUT_LOW, set consumer name. > - Use gpiod_set_value_cansleep to configure output value. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/9] ASoC: codec: cs42l56: Sort headers alphabetically commit: 4060ebdd5063eed98a8f81f78f1e67ffc4ff0942 [2/9] ASoC: codec: cs42l56: Drop cs42l56.h commit: 86f6e4791c40c33891299d95c055e5d06d396284 [3/9] ASoC: codec: cs42l56: Convert to GPIO descriptors commit: 0bb92e4736a9dd43e3215b378db5ac63075a3cc1 [4/9] ASoC: codec: cs42l73: Sort headers alphabetically commit: f3e7298848f0e6c09e4da5fd80bca7cd0c58ccc1 [5/9] ASoC: codec: cs42l73: Drop cs42l73.h commit: 43ef0dccbc2528924c4b03a902fa39502faabb16 [6/9] ASoC: codec: cs42l73: Convert to GPIO descriptors commit: b6118100382c9e4c8ca623b3a8e8bf1a09c42aa5 [7/9] ASoC: codec: cs42l52: Sort headers alphabetically commit: 2d703321b856acdb6589d74906e19aa5cb328d4e [8/9] ASoC: codec: cs42l52: Drop cs42l52.h commit: 772c036befb875c904731fb309fb9d2e065ba3f8 [9/9] ASoC: codec: cs42l52: Convert to GPIO descriptors commit: 5bf5bdfd007e07f2ec5b3e07aa02616f4eebef67 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
On Tue, May 6, 2025 at 9:31 AM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote: > From: Peng Fan <peng.fan@nxp.com> > > of_gpio.h is deprecated, update the driver to use GPIO descriptors. > - Use devm_gpiod_get_optional to get GPIO descriptor with default > polarity GPIOD_OUT_LOW, set consumer name. > - Use gpiod_set_value_cansleep to configure output value. > > Checking the current driver using legacy GPIO API, the > nreset value is first output HIGH, then LOW, then HIGH. > > Checking the datasheet, nreset is should be held low after power > on, when nreset is high, it starts to work. > > Since the driver has been here for quite long time and no complain on > the nreset flow, still follow original flow when using GPIOD > descriptors. > > Commit 944004eb56dc ("gpiolib: of: add a quirk for reset line for Cirrus > CS42L56 codec") added quirks, so the gpio request API will work as before. > > Per datasheet, the DTS polarity should be GPIOD_ACTIVE_LOW. The binding > example use value 0(GPIOD_ACTIVE_HIGH) which seems wrong. There is > no in-tree DTS has the device, so all should be fine. > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
On Tue, May 6, 2025 at 9:31 AM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote: > From: Peng Fan <peng.fan@nxp.com> > > of_gpio.h is deprecated, update the driver to use GPIO descriptors. > - Use devm_gpiod_get_optional to get GPIO descriptor with default > polarity GPIOD_OUT_LOW, set consumer name. > - Use gpiod_set_value_cansleep to configure output value. > > Checking the current driver using legacy GPIO API, the > nreset value is first output HIGH, then LOW, then HIGH. > > Checking the datasheet, nreset is should be held low after power > on, when nreset is high, it starts to work. > > Since the driver has been here for quite long time and no complain on > the nreset flow, still follow original flow when using GPIOD > descriptors. > > Commit 944004eb56dc ("gpiolib: of: add a quirk for reset line for Cirrus > CS42L56 codec") added quirks, so the gpio request API will work as before. > > Per datasheet, the DTS polarity should be GPIOD_ACTIVE_LOW. The binding > example use value 0(GPIOD_ACTIVE_HIGH) which seems wrong. There is > no in-tree DTS has the device, so all should be fine. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Tue, May 6, 2025 at 9:31 AM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote: > From: Peng Fan <peng.fan@nxp.com> > > of_gpio.h is deprecated, update the driver to use GPIO descriptors. > - Use devm_gpiod_get_optional to get GPIO descriptor with default > polarity GPIOD_OUT_LOW, set consumer name. > - Use gpiod_set_value_cansleep to configure output value. > > Checking the current driver using legacy GPIO API, the > reset value is first output HIGH, then LOW, then HIGH. > > Checking the datasheet, the device remains in Power-down state until > RESET pin is brought high. > > Since the driver has been here for quite long time and no complain on > the reset flow, still follow original flow when using GPIOD > descriptors. > > Per datasheet, the DTS polarity should be GPIOD_ACTIVE_LOW. The binding > example use value 0(GPIOD_ACTIVE_HIGH) which seems wrong. > And the binding use reset-gpio as example, not same as driver using > "cirrus,reset-gpio", and there is no in-tree DTS has the device, > so all should be fine with this patch. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
This patchset is separate from [1], and not merging changes in one patch. So separate changes into three patches for each chip. - sort headers - Drop legacy platform support - Convert to GPIO descriptors of_gpio.h is deprecated, update the driver to use GPIO descriptors. - Use devm_gpiod_get_optional to get GPIO descriptor with default polarity GPIOD_OUT_LOW, set consumer name. - Use gpiod_set_value_cansleep to configure output value. I not have platforms to test, just do the patches with my best efforts, and make build pass. [1] https://lore.kernel.org/all/20250408-asoc-gpio-v1-0-c0db9d3fd6e9@nxp.com/ Signed-off-by: Peng Fan <peng.fan@nxp.com> --- Changes in v3: - Fix build break in patch 2 when using allmodconfig - Link to v2: https://lore.kernel.org/r/20250428-csl42x-v2-0-e8056313968f@nxp.com --- Peng Fan (9): ASoC: codec: cs42l56: Sort headers alphabetically ASoC: codec: cs42l56: Drop cs42l56.h ASoC: codec: cs42l56: Convert to GPIO descriptors ASoC: codec: cs42l73: Sort headers alphabetically ASoC: codec: cs42l73: Drop cs42l73.h ASoC: codec: cs42l73: Convert to GPIO descriptors ASoC: codec: cs42l52: Sort headers alphabetically ASoC: codec: cs42l52: Drop cs42l52.h ASoC: codec: cs42l52: Convert to GPIO descriptors include/sound/cs42l52.h | 29 ------------ include/sound/cs42l56.h | 45 ------------------ include/sound/cs42l73.h | 19 -------- sound/soc/codecs/cs42l52.c | 112 ++++++++++++++++++++++++--------------------- sound/soc/codecs/cs42l56.c | 90 ++++++++++++++++++++++-------------- sound/soc/codecs/cs42l73.c | 70 +++++++++++++--------------- 6 files changed, 150 insertions(+), 215 deletions(-) --- base-commit: d9889ee34d3ea05284d5df6182692c12595b671d change-id: 20250427-csl42x-0151784a1230 Best regards,