| Message ID | 20250513200043.608292-1-va@nvidia.com |
|---|---|
| State | New |
| Headers | show |
| Series | [V4,1/2] dt-bindings: spi: tegra: Document IOMMU property for Tegra234 QSPI | expand |
On Tue, May 13, 2025 at 08:00:42PM +0000, Vishwaroop A wrote: > Add the 'iommus' property to the Tegra QSPI device tree binding. > The property is needed for Tegra234 when using the internal DMA > controller, and is not supported on other Tegra chips, as DMA is > handled by an external controller. > > Signed-off-by: Vishwaroop A <va@nvidia.com> Acked-by: Conor Dooley <conor.dooley@microchip.com>
On 14/05/2025 17:25, Conor Dooley wrote: > On Tue, May 13, 2025 at 08:00:42PM +0000, Vishwaroop A wrote: >> Add the 'iommus' property to the Tegra QSPI device tree binding. >> The property is needed for Tegra234 when using the internal DMA >> controller, and is not supported on other Tegra chips, as DMA is >> handled by an external controller. >> >> Signed-off-by: Vishwaroop A <va@nvidia.com> > > Acked-by: Conor Dooley <conor.dooley@microchip.com> Reviewed-by: Jon Hunter <jonathanh@nvidia.com> Thanks! Jon
On Tue, 13 May 2025 20:00:42 +0000, Vishwaroop A wrote: > Add the 'iommus' property to the Tegra QSPI device tree binding. > The property is needed for Tegra234 when using the internal DMA > controller, and is not supported on other Tegra chips, as DMA is > handled by an external controller. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/2] dt-bindings: spi: tegra: Document IOMMU property for Tegra234 QSPI commit: 4614fd6342ab69feebb067d5db84a9bfb9aada9f [2/2] spi: tegra210-quad: Add support for internal DMA commit: 017f1b0bae08e8b456cf35cbdaae93ec19b50f0a All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml b/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml index 48e97e240265..8b3640280559 100644 --- a/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml +++ b/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml @@ -10,9 +10,6 @@ maintainers: - Thierry Reding <thierry.reding@gmail.com> - Jonathan Hunter <jonathanh@nvidia.com> -allOf: - - $ref: spi-controller.yaml# - properties: compatible: enum: @@ -47,6 +44,9 @@ properties: - const: rx - const: tx + iommus: + maxItems: 1 + patternProperties: "@[0-9a-f]+$": type: object @@ -69,6 +69,18 @@ required: unevaluatedProperties: false +allOf: + - $ref: spi-controller.yaml# + - if: + properties: + compatible: + not: + contains: + const: nvidia,tegra234-qspi + then: + properties: + iommus: false + examples: - | #include <dt-bindings/clock/tegra210-car.h>
Add the 'iommus' property to the Tegra QSPI device tree binding. The property is needed for Tegra234 when using the internal DMA controller, and is not supported on other Tegra chips, as DMA is handled by an external controller. Signed-off-by: Vishwaroop A <va@nvidia.com> --- .../bindings/spi/nvidia,tegra210-quad.yaml | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) Changes since v3: - Inverted the logic of the conditional statement for the IOMMU property Changes since v2: - Fixed version number to match the actual version - Added proper changelog section - No functional changes from v2 Changes since v1: - Fixed subject prefix to match subsystem (dt-bindings: spi: tegra) - Improved commit message formatting to follow Linux coding style - Clarified that IOMMU is only required for Tegra234 platform - Added explicit disallow for IOMMU on other platforms - Removed redundant explanations of what the patch does - Fixed commit message to use imperative mood Initial Version: - Initial implementation of IOMMU property documentation - Added iommus property to device tree binding - Added support for Tegra234 platform - Added explanation of DMA and IOMMU requirements