diff mbox series

[2/2] HID: lenovo: Remove CONFIG_ACPI dependency

Message ID 20250518-hid_lenovo_acpi_dependency-v1-2-afdb93b5d1a6@jannau.net
State New
Headers show
Series Remove HID_LENOVO's dependency on ACPI | expand

Commit Message

Janne Grunau via B4 Relay May 18, 2025, 10:18 a.m. UTC 
From: Janne Grunau <j@jannau.net>

With platform_profile_cycle() stubbed the dependency on CONFIG_ACPI can
be relaxed to `ACPI || !ACPI` and CONFIG_ACPI_PLATFORM_PROFILE is only
selected if ACPI is enabled.
Cycling through platform profiles is only functional with ACPI but that
should not be an issue as it only used on a detachable keyboard of a x86
tablet with a special connector.

Fixes: 52572cde8b4a4 ("HID: lenovo: select CONFIG_ACPI_PLATFORM_PROFILE")
Signed-off-by: Janne Grunau <j@jannau.net>
---
 drivers/hid/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Arnd Bergmann May 18, 2025, 10:36 a.m. UTC | #1 
On Sun, May 18, 2025, at 12:18, Janne Grunau via B4 Relay wrote:
> 
>  config HID_LENOVO
>  	tristate "Lenovo / Thinkpad devices"
> -	depends on ACPI
> -	select ACPI_PLATFORM_PROFILE
> +	depends on ACPI || !ACPI

Since ACPI is a 'bool' symbol, the 'ACPI || !ACPI' dependency
has no actual effect. I don't see any way that ACPI will ever
become a loadable module.

      Arnd
diff mbox series

Patch

diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index a503252702b7b43c332a12b14bc8b23b83e9f028..984f7bd235141f21e018b51f97546ec9d00324e8 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -595,8 +595,8 @@  config HID_LED
 
 config HID_LENOVO
 	tristate "Lenovo / Thinkpad devices"
-	depends on ACPI
-	select ACPI_PLATFORM_PROFILE
+	depends on ACPI || !ACPI
+	select ACPI_PLATFORM_PROFILE if ACPI
 	select NEW_LEDS
 	select LEDS_CLASS
 	help