| Message ID | 20250519151116.803-1-shiju.jose@huawei.com |
|---|---|
| Headers | show |
| Series | ACPI: Add support for ACPI RAS2 feature table | expand |
On Mon, 19 May 2025 16:11:13 +0100 <shiju.jose@huawei.com> wrote: > From: Shiju Jose <shiju.jose@huawei.com> > Hi Rafael, Are you looking for anything else for this series? (reviews from others etc?) The core EDAC support when upstream last cycle (this was in that series as well so is kind of version 27). I believe the expectation is this will go through your tree. Tweaks have been pretty minor for last few versions. Thanks, Jonathan > Add support for ACPI RAS2 feature table (RAS2) defined in the > ACPI 6.5 specification, section 5.2.21 and RAS2 HW based memory > scrubbing feature. > > ACPI RAS2 patches were part of the EDAC series [1]. > > The code is based on ras.git: edac-for-next branch [2] > merged with linux-pm.git [3] : linux-next branch. > > 1. https://lore.kernel.org/linux-cxl/20250212143654.1893-1-shiju.jose@huawei.com/ > 2. https://web.git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git/log/?h=edac-for-next > 3. https://web.git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/ > > Changes > ======= > v6 -> v7: > 1. Fix for the issue reported by Daniel, > In ras2_check_pcc_chan(), add read, clear and check RAS2 set_cap_status outside > if (status & PCC_STATUS_ERROR) check. > https://lore.kernel.org/all/51bcb52c-4132-4daf-8903-29b121c485a1@os.amperecomputing.com/ > > v5 -> v6: > 1. Fix for the issue reported by Daniel, in start scrubbing with correct addr and size > after firmware return INVALID DATA error for scrub request with invalid addr or size. > https://lore.kernel.org/all/8cdf7885-31b3-4308-8a7c-f4e427486429@os.amperecomputing.com/ > > v4 -> v5: > 1. Fix for the build warnings reported by kernel test robot. > https://patchwork.kernel.org/project/linux-edac/patch/20250423163511.1412-3-shiju.jose@huawei.com/ > 2. Removed patch "ACPI: ACPI 6.5: RAS2: Rename RAS2 table structure and field names" > from the series as the patch was merged to linux-pm.git : branch linux-next > 3. Rebased to ras.git: edac-for-next branch merged with linux-pm.git : linux-next branch. > > v3 -> v4: > 1. Changes for feedbacks from Yazen on v3. > https://lore.kernel.org/all/20250415210504.GA854098@yaz-khff2.amd.com/ > > v2 -> v3: > 1. Rename RAS2 table structure and field names in > include/acpi/actbl2.h limited to only necessary > for RAS2 scrub feature. > 2. Changes for feedbacks from Jonathan on v2. > 3. Daniel reported a known behaviour: when readback 'size' attribute after > setting in, returns 0 before starting scrubbing via 'addr' attribute. > Changes added to fix this. > 4. Daniel reported that firmware cannot update status of demand scrubbing > via the 'Actual Address Range (OUTPUT)', thus add workaround in the > kernel to update sysfs 'addr' attribute with the status of demand > scrubbing. > 5. Optimized logic in ras2_check_pcc_chan() function > (patch - ACPI:RAS2: Add ACPI RAS2 driver). > 6. Add PCC channel lock to struct ras2_pcc_subspace and change > lock in ras2_mem_ctx as a pointer to pcc channel lock to make sure > writing to PCC subspace shared memory is protected from race conditions. > > v1 -> v2: > 1. Changes for feedbacks from Borislav. > - Shorten ACPI RAS2 structures and variables names. > - Shorten some of the other variables in the RAS2 drivers. > - Fixed few CamelCases. > > 2. Changes for feedbacks from Yazen. > - Added newline after number of '}' and return statements. > - Changed return type for "ras2_add_aux_device() to 'int'. > - Deleted a duplication of acpi_get_table("RAS2",...) in the ras2_acpi_parse_table(). > - Add "FW_WARN" to few error logs in the ras2_acpi_parse_table(). > - Rename ras2_acpi_init() to acpi_ras2_init() and modified to call acpi_ras2_init() > function from the acpi_init(). > - Moved scrub related variables from the struct ras2_mem_ctx from patch > "ACPI:RAS2: Add ACPI RAS2 driver" to "ras: mem: Add memory ACPI RAS2 driver". > > Shiju Jose (2): > ACPI:RAS2: Add ACPI RAS2 driver > ras: mem: Add memory ACPI RAS2 driver > > Documentation/edac/scrub.rst | 78 ++++++ > drivers/acpi/Kconfig | 11 + > drivers/acpi/Makefile | 1 + > drivers/acpi/bus.c | 3 + > drivers/acpi/ras2.c | 450 +++++++++++++++++++++++++++++++++++ > drivers/ras/Kconfig | 11 + > drivers/ras/Makefile | 1 + > drivers/ras/acpi_ras2.c | 424 +++++++++++++++++++++++++++++++++ > include/acpi/ras2.h | 70 ++++++ > 9 files changed, 1049 insertions(+) > create mode 100644 drivers/acpi/ras2.c > create mode 100644 drivers/ras/acpi_ras2.c > create mode 100644 include/acpi/ras2.h >
From: Shiju Jose <shiju.jose@huawei.com> Add support for ACPI RAS2 feature table (RAS2) defined in the ACPI 6.5 specification, section 5.2.21 and RAS2 HW based memory scrubbing feature. ACPI RAS2 patches were part of the EDAC series [1]. The code is based on ras.git: edac-for-next branch [2] merged with linux-pm.git [3] : linux-next branch. 1. https://lore.kernel.org/linux-cxl/20250212143654.1893-1-shiju.jose@huawei.com/ 2. https://web.git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git/log/?h=edac-for-next 3. https://web.git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/ Changes ======= v6 -> v7: 1. Fix for the issue reported by Daniel, In ras2_check_pcc_chan(), add read, clear and check RAS2 set_cap_status outside if (status & PCC_STATUS_ERROR) check. https://lore.kernel.org/all/51bcb52c-4132-4daf-8903-29b121c485a1@os.amperecomputing.com/ v5 -> v6: 1. Fix for the issue reported by Daniel, in start scrubbing with correct addr and size after firmware return INVALID DATA error for scrub request with invalid addr or size. https://lore.kernel.org/all/8cdf7885-31b3-4308-8a7c-f4e427486429@os.amperecomputing.com/ v4 -> v5: 1. Fix for the build warnings reported by kernel test robot. https://patchwork.kernel.org/project/linux-edac/patch/20250423163511.1412-3-shiju.jose@huawei.com/ 2. Removed patch "ACPI: ACPI 6.5: RAS2: Rename RAS2 table structure and field names" from the series as the patch was merged to linux-pm.git : branch linux-next 3. Rebased to ras.git: edac-for-next branch merged with linux-pm.git : linux-next branch. v3 -> v4: 1. Changes for feedbacks from Yazen on v3. https://lore.kernel.org/all/20250415210504.GA854098@yaz-khff2.amd.com/ v2 -> v3: 1. Rename RAS2 table structure and field names in include/acpi/actbl2.h limited to only necessary for RAS2 scrub feature. 2. Changes for feedbacks from Jonathan on v2. 3. Daniel reported a known behaviour: when readback 'size' attribute after setting in, returns 0 before starting scrubbing via 'addr' attribute. Changes added to fix this. 4. Daniel reported that firmware cannot update status of demand scrubbing via the 'Actual Address Range (OUTPUT)', thus add workaround in the kernel to update sysfs 'addr' attribute with the status of demand scrubbing. 5. Optimized logic in ras2_check_pcc_chan() function (patch - ACPI:RAS2: Add ACPI RAS2 driver). 6. Add PCC channel lock to struct ras2_pcc_subspace and change lock in ras2_mem_ctx as a pointer to pcc channel lock to make sure writing to PCC subspace shared memory is protected from race conditions. v1 -> v2: 1. Changes for feedbacks from Borislav. - Shorten ACPI RAS2 structures and variables names. - Shorten some of the other variables in the RAS2 drivers. - Fixed few CamelCases. 2. Changes for feedbacks from Yazen. - Added newline after number of '}' and return statements. - Changed return type for "ras2_add_aux_device() to 'int'. - Deleted a duplication of acpi_get_table("RAS2",...) in the ras2_acpi_parse_table(). - Add "FW_WARN" to few error logs in the ras2_acpi_parse_table(). - Rename ras2_acpi_init() to acpi_ras2_init() and modified to call acpi_ras2_init() function from the acpi_init(). - Moved scrub related variables from the struct ras2_mem_ctx from patch "ACPI:RAS2: Add ACPI RAS2 driver" to "ras: mem: Add memory ACPI RAS2 driver". Shiju Jose (2): ACPI:RAS2: Add ACPI RAS2 driver ras: mem: Add memory ACPI RAS2 driver Documentation/edac/scrub.rst | 78 ++++++ drivers/acpi/Kconfig | 11 + drivers/acpi/Makefile | 1 + drivers/acpi/bus.c | 3 + drivers/acpi/ras2.c | 450 +++++++++++++++++++++++++++++++++++ drivers/ras/Kconfig | 11 + drivers/ras/Makefile | 1 + drivers/ras/acpi_ras2.c | 424 +++++++++++++++++++++++++++++++++ include/acpi/ras2.h | 70 ++++++ 9 files changed, 1049 insertions(+) create mode 100644 drivers/acpi/ras2.c create mode 100644 drivers/ras/acpi_ras2.c create mode 100644 include/acpi/ras2.h