| Message ID | 20250523092313.2625421-1-vladimir.zapolskiy@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] arm64: dts: qcom: sm8250: enable camcc clock controller by default | expand |
Hi Konrad, On 5/23/25 13:42, Konrad Dybcio wrote: > On 5/23/25 11:23 AM, Vladimir Zapolskiy wrote: >> Enable camera clock controller on all Qualcomm SM8250 derived boards >> by default due to the established agreement of having all clock >> controllers enabled. >> >> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> >> --- > > No reason for it to be 2 patches but redoing it would be clearly > wasted time > > Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > thank you for review, the reason behind two patches like here and in some other series from me is a care about potential clean change reverts. If something goes wrong for whatever reason (even in the untouched clock driver), and even if there are more cc device status okay/disabled series for any other boards, the split to a platform and a board changes allows to revert the changes independently at any point of time in future. -- Best wishes, Vladimir
diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi index f0d18fd37aaf..a6f9b78c5226 100644 --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi @@ -4653,7 +4653,6 @@ camcc: clock-controller@ad00000 { clock-names = "iface", "bi_tcxo", "bi_tcxo_ao", "sleep_clk"; power-domains = <&rpmhpd RPMHPD_MMCX>; required-opps = <&rpmhpd_opp_low_svs>; - status = "disabled"; #clock-cells = <1>; #reset-cells = <1>; #power-domain-cells = <1>;
Enable camera clock controller on all Qualcomm SM8250 derived boards by default due to the established agreement of having all clock controllers enabled. Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 1 - 1 file changed, 1 deletion(-)