diff mbox series

arm64: dts: qcom: qcs615-ride: Add PSCI SYSTEM_RESET2 types

Message ID 20250422-add_psci_sys_reset2_modes_for_qcs615-v1-1-7faaf877366e@quicinc.com
State New
Headers show
Series arm64: dts: qcom: qcs615-ride: Add PSCI SYSTEM_RESET2 types | expand

Commit Message

Song Xue April 22, 2025, 7:39 a.m. UTC
Add properties to support Bootloader and Edl mode for PSCI system
reset2 reboot modes. The cookie and magic values set will be used
by SYSTEM_RESET2 call.

Signed-off-by: Song Xue <quic_songxue@quicinc.com>
---
Dependencies:
Link to bindings and driver changes:
https://lore.kernel.org/all/20250303-arm-psci-system_reset2-vendor-reboots-v9-0-b2cf4a20feda@oss.qualcomm.com/
---
 arch/arm64/boot/dts/qcom/qcs615-ride.dts | 7 +++++++
 arch/arm64/boot/dts/qcom/qcs615.dtsi     | 2 +-
 2 files changed, 8 insertions(+), 1 deletion(-)


---
base-commit: e21edb1638e82460f126a6e49bcdd958d452929c
change-id: 20250330-add_psci_sys_reset2_modes_for_qcs615-4efe1822d156

Best regards,

Comments

Bjorn Andersson May 24, 2025, 2:41 a.m. UTC | #1
On Thu, Apr 24, 2025 at 01:59:04PM +0800, Song Xue wrote:
> 
> 
> On 4/22/2025 9:38 PM, Rob Herring (Arm) wrote:
> > 
> > On Tue, 22 Apr 2025 15:39:54 +0800, Song Xue wrote:
> > > Add properties to support Bootloader and Edl mode for PSCI system
> > > reset2 reboot modes. The cookie and magic values set will be used
> > > by SYSTEM_RESET2 call.
> > > 
> > > Signed-off-by: Song Xue <quic_songxue@quicinc.com>
> > > ---
> > > Dependencies:
> > > Link to bindings and driver changes:
> > > https://lore.kernel.org/all/20250303-arm-psci-system_reset2-vendor-reboots-v9-0-b2cf4a20feda@oss.qualcomm.com/
> > > ---
> > >   arch/arm64/boot/dts/qcom/qcs615-ride.dts | 7 +++++++
> > >   arch/arm64/boot/dts/qcom/qcs615.dtsi     | 2 +-
> > >   2 files changed, 8 insertions(+), 1 deletion(-)
> > > 
> > 
> > 
> > My bot found new DTB warnings on the .dts files added or changed in this
> > series.
> > 
> > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> > are fixed by another series. Ultimately, it is up to the platform
> > maintainer whether these warnings are acceptable or not. No need to reply
> > unless the platform maintainer has comments.
> > 
> > If you already ran DT checks and didn't see these error(s), then
> > make sure dt-schema is up to date:
> > 
> >    pip3 install dtschema --upgrade
> > 
> > 
> > This patch series was applied (using b4) to base:
> >   Base: using specified base-commit e21edb1638e82460f126a6e49bcdd958d452929c
> > 
> > If this is not the correct base, please add 'base-commit' tag
> > (or use b4 which does this automatically)
> > 
> > New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20250422-add_psci_sys_reset2_modes_for_qcs615-v1-1-7faaf877366e@quicinc.com:
> > 
> > arch/arm64/boot/dts/qcom/qcs615-ride.dtb: psci (arm,psci-1.0): 'reset-types' does not match any of the regexes: '^pinctrl-[0-9]+$', '^power-domain-'
> > 	from schema $id: http://devicetree.org/schemas/arm/psci.yaml#
> > 
> My patch is depend on the bindings:https://lore.kernel.org/all/20250303-arm-psci-system_reset2-vendor-reboots-v9-1-b2cf4a20feda@oss.qualcomm.com/
> 

This dependency has not yet been accepted, so there's nothing I can do
with your patch. Please resubmit it once the dependencies have been
accepted.

Thanks,
Bjorn

> In this bindings, we can see the property definition of 'reset-types' which
> only has "mode-" property.
> 
> Best regards,
> Song Xue
> > 
> > 
> > 
> > 
>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
index 2b5aa3c66867676bda59ff82b902b6e4974126f8..7dec44de8143939e52899c4bed9f57a417688b76 100644
--- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
+++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
@@ -236,6 +236,13 @@  &pon_resin {
 	status = "okay";
 };
 
+&psci {
+	reset-types {
+		mode-bootloader = <0x10001 0x2>;
+		mode-edl = <0 0x1>;
+	};
+};
+
 &qupv3_id_0 {
 	status = "okay";
 };
diff --git a/arch/arm64/boot/dts/qcom/qcs615.dtsi b/arch/arm64/boot/dts/qcom/qcs615.dtsi
index edfb796d8dd38f5d65fd4327308fb5ac52d2b95e..48f7b975b6205a659e5c7ecd296e59b0d3ee50f4 100644
--- a/arch/arm64/boot/dts/qcom/qcs615.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs615.dtsi
@@ -352,7 +352,7 @@  opp-128000000 {
 		};
 	};
 
-	psci {
+	psci: psci {
 		compatible = "arm,psci-1.0";
 		method = "smc";