| Message ID | 20250612-exynos7870-mipi-phy-v1-2-3fff0b62d9d3@disroot.org |
|---|---|
| State | New |
| Headers | show |
| Series | Support for Exynos7870's MIPI PHY blocks | expand |
On 12/06/2025 17:09, Kaustabh Chakraborty wrote: > Add support for Exynos7870 in the existing MIPI CSIS/DSIM driver. The > SoC has one DSIM phy and three CSIS phys. > > Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> > --- > drivers/phy/samsung/phy-exynos-mipi-video.c | 52 +++++++++++++++++++++++++++++ > include/linux/soc/samsung/exynos-regs-pmu.h | 5 +++ > 2 files changed, 57 insertions(+) > > diff --git a/drivers/phy/samsung/phy-exynos-mipi-video.c b/drivers/phy/samsung/phy-exynos-mipi-video.c > index f6756a609a9a0774ecb6e27cf96726891683636c..b184923b9b400f0d536a913bdf32f3156c0a1854 100644 > --- a/drivers/phy/samsung/phy-exynos-mipi-video.c > +++ b/drivers/phy/samsung/phy-exynos-mipi-video.c > @@ -213,6 +213,55 @@ static const struct mipi_phy_device_desc exynos5433_mipi_phy = { > }, > }; > > +static const struct mipi_phy_device_desc exynos7870_mipi_phy = { > + .num_regmaps = 3, > + .regmap_names = { > + "samsung,pmu-syscon", > + "samsung,disp-sysreg", > + "samsung,cam-sysreg" > + }, > + .num_phys = 4, > + .phys = { > + { > + /* EXYNOS_MIPI_PHY_ID_CSIS0 */ > + .coupled_phy_id = EXYNOS_MIPI_PHY_ID_DSIM0, > + .enable_val = EXYNOS4_PHY_ENABLE, > + .enable_reg = EXYNOS7870_MIPI_PHY_CONTROL0, > + .enable_map = EXYNOS_MIPI_REGMAP_PMU, > + .resetn_val = BIT(0), > + .resetn_reg = 0, > + .resetn_map = EXYNOS_MIPI_REGMAP_CAM0, > + }, { > + /* EXYNOS_MIPI_PHY_ID_DSIM0 */ > + .coupled_phy_id = EXYNOS_MIPI_PHY_ID_CSIS0, > + .enable_val = EXYNOS4_PHY_ENABLE, > + .enable_reg = EXYNOS7870_MIPI_PHY_CONTROL0, > + .enable_map = EXYNOS_MIPI_REGMAP_PMU, > + .resetn_val = BIT(0), > + .resetn_reg = 0, > + .resetn_map = EXYNOS_MIPI_REGMAP_DISP, > + }, { > + /* EXYNOS_MIPI_PHY_ID_CSIS1 */ > + .coupled_phy_id = EXYNOS_MIPI_PHY_ID_NONE, > + .enable_val = EXYNOS4_PHY_ENABLE, > + .enable_reg = EXYNOS7870_MIPI_PHY_CONTROL1, > + .enable_map = EXYNOS_MIPI_REGMAP_PMU, > + .resetn_val = BIT(1), > + .resetn_reg = 0, > + .resetn_map = EXYNOS_MIPI_REGMAP_CAM0, > + }, { > + /* EXYNOS_MIPI_PHY_ID_CSIS2 */ > + .coupled_phy_id = EXYNOS_MIPI_PHY_ID_NONE, > + .enable_val = EXYNOS4_PHY_ENABLE, > + .enable_reg = EXYNOS7870_MIPI_PHY_CONTROL2, > + .enable_map = EXYNOS_MIPI_REGMAP_PMU, > + .resetn_val = BIT(2), > + .resetn_reg = 0, > + .resetn_map = EXYNOS_MIPI_REGMAP_CAM0, > + }, > + }, > +}; > + > struct exynos_mipi_video_phy { > struct regmap *regmaps[EXYNOS_MIPI_REGMAPS_NUM]; > int num_phys; > @@ -351,6 +400,9 @@ static const struct of_device_id exynos_mipi_video_phy_of_match[] = { > }, { > .compatible = "samsung,exynos5433-mipi-video-phy", > .data = &exynos5433_mipi_phy, > + }, { > + .compatible = "samsung,exynos7870-mipi-video-phy", > + .data = &exynos7870_mipi_phy, > }, > { /* sentinel */ }, > }; > diff --git a/include/linux/soc/samsung/exynos-regs-pmu.h b/include/linux/soc/samsung/exynos-regs-pmu.h > index 1a2c0e0838f99821151661878f022f2129a0c19b..8fd59994bca76a6bf21306337f0b47ccb5a22adc 100644 > --- a/include/linux/soc/samsung/exynos-regs-pmu.h > +++ b/include/linux/soc/samsung/exynos-regs-pmu.h > @@ -662,6 +662,11 @@ > #define EXYNOS5433_PAD_RETENTION_UFS_OPTION (0x3268) > #define EXYNOS5433_PAD_RETENTION_FSYSGENIO_OPTION (0x32A8) > > +/* For Exynos7870 */ > +#define EXYNOS7870_MIPI_PHY_CONTROL0 (0x070c) > +#define EXYNOS7870_MIPI_PHY_CONTROL1 (0x0714) > +#define EXYNOS7870_MIPI_PHY_CONTROL2 (0x0734) > + > /* For Tensor GS101 */ > /* PMU ALIVE */ > #define GS101_SYSIP_DAT0 (0x810) > Looks good: Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
diff --git a/drivers/phy/samsung/phy-exynos-mipi-video.c b/drivers/phy/samsung/phy-exynos-mipi-video.c index f6756a609a9a0774ecb6e27cf96726891683636c..b184923b9b400f0d536a913bdf32f3156c0a1854 100644 --- a/drivers/phy/samsung/phy-exynos-mipi-video.c +++ b/drivers/phy/samsung/phy-exynos-mipi-video.c @@ -213,6 +213,55 @@ static const struct mipi_phy_device_desc exynos5433_mipi_phy = { }, }; +static const struct mipi_phy_device_desc exynos7870_mipi_phy = { + .num_regmaps = 3, + .regmap_names = { + "samsung,pmu-syscon", + "samsung,disp-sysreg", + "samsung,cam-sysreg" + }, + .num_phys = 4, + .phys = { + { + /* EXYNOS_MIPI_PHY_ID_CSIS0 */ + .coupled_phy_id = EXYNOS_MIPI_PHY_ID_DSIM0, + .enable_val = EXYNOS4_PHY_ENABLE, + .enable_reg = EXYNOS7870_MIPI_PHY_CONTROL0, + .enable_map = EXYNOS_MIPI_REGMAP_PMU, + .resetn_val = BIT(0), + .resetn_reg = 0, + .resetn_map = EXYNOS_MIPI_REGMAP_CAM0, + }, { + /* EXYNOS_MIPI_PHY_ID_DSIM0 */ + .coupled_phy_id = EXYNOS_MIPI_PHY_ID_CSIS0, + .enable_val = EXYNOS4_PHY_ENABLE, + .enable_reg = EXYNOS7870_MIPI_PHY_CONTROL0, + .enable_map = EXYNOS_MIPI_REGMAP_PMU, + .resetn_val = BIT(0), + .resetn_reg = 0, + .resetn_map = EXYNOS_MIPI_REGMAP_DISP, + }, { + /* EXYNOS_MIPI_PHY_ID_CSIS1 */ + .coupled_phy_id = EXYNOS_MIPI_PHY_ID_NONE, + .enable_val = EXYNOS4_PHY_ENABLE, + .enable_reg = EXYNOS7870_MIPI_PHY_CONTROL1, + .enable_map = EXYNOS_MIPI_REGMAP_PMU, + .resetn_val = BIT(1), + .resetn_reg = 0, + .resetn_map = EXYNOS_MIPI_REGMAP_CAM0, + }, { + /* EXYNOS_MIPI_PHY_ID_CSIS2 */ + .coupled_phy_id = EXYNOS_MIPI_PHY_ID_NONE, + .enable_val = EXYNOS4_PHY_ENABLE, + .enable_reg = EXYNOS7870_MIPI_PHY_CONTROL2, + .enable_map = EXYNOS_MIPI_REGMAP_PMU, + .resetn_val = BIT(2), + .resetn_reg = 0, + .resetn_map = EXYNOS_MIPI_REGMAP_CAM0, + }, + }, +}; + struct exynos_mipi_video_phy { struct regmap *regmaps[EXYNOS_MIPI_REGMAPS_NUM]; int num_phys; @@ -351,6 +400,9 @@ static const struct of_device_id exynos_mipi_video_phy_of_match[] = { }, { .compatible = "samsung,exynos5433-mipi-video-phy", .data = &exynos5433_mipi_phy, + }, { + .compatible = "samsung,exynos7870-mipi-video-phy", + .data = &exynos7870_mipi_phy, }, { /* sentinel */ }, }; diff --git a/include/linux/soc/samsung/exynos-regs-pmu.h b/include/linux/soc/samsung/exynos-regs-pmu.h index 1a2c0e0838f99821151661878f022f2129a0c19b..8fd59994bca76a6bf21306337f0b47ccb5a22adc 100644 --- a/include/linux/soc/samsung/exynos-regs-pmu.h +++ b/include/linux/soc/samsung/exynos-regs-pmu.h @@ -662,6 +662,11 @@ #define EXYNOS5433_PAD_RETENTION_UFS_OPTION (0x3268) #define EXYNOS5433_PAD_RETENTION_FSYSGENIO_OPTION (0x32A8) +/* For Exynos7870 */ +#define EXYNOS7870_MIPI_PHY_CONTROL0 (0x070c) +#define EXYNOS7870_MIPI_PHY_CONTROL1 (0x0714) +#define EXYNOS7870_MIPI_PHY_CONTROL2 (0x0734) + /* For Tensor GS101 */ /* PMU ALIVE */ #define GS101_SYSIP_DAT0 (0x810)
Add support for Exynos7870 in the existing MIPI CSIS/DSIM driver. The SoC has one DSIM phy and three CSIS phys. Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> --- drivers/phy/samsung/phy-exynos-mipi-video.c | 52 +++++++++++++++++++++++++++++ include/linux/soc/samsung/exynos-regs-pmu.h | 5 +++ 2 files changed, 57 insertions(+)