| Message ID | 20250613100255.2131800-3-joy.zou@nxp.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add i.MX91 platform support | expand |
On 13/06/2025 12:02, Joy Zou wrote: > Add new compatible string "fsl,imx91-media-blk-ctrl" for i.MX91, > which has different input clocks compared to i.MX93. Update the > clock-names list and handle it in the if-else branch accordingly. > > Keep the same restriction for the existed compatible strings. > > Signed-off-by: Joy Zou <joy.zou@nxp.com> > --- > .../soc/imx/fsl,imx93-media-blk-ctrl.yaml | 55 +++++++++++++++---- > 1 file changed, 43 insertions(+), 12 deletions(-) This wasn't here in v4 and changelog is silent about it. Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: 2025年6月13日 18:41 > To: Joy Zou <joy.zou@nxp.com>; robh@kernel.org; krzk+dt@kernel.org; > conor+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de; > catalin.marinas@arm.com; will@kernel.org; andrew+netdev@lunn.ch; > davem@davemloft.net; edumazet@google.com; kuba@kernel.org; > pabeni@redhat.com; mcoquelin.stm32@gmail.com; > alexandre.torgue@foss.st.com; ulf.hansson@linaro.org; > richardcochran@gmail.com; kernel@pengutronix.de; festevam@gmail.com > Cc: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > imx@lists.linux.dev; linux-arm-kernel@lists.infradead.org; > netdev@vger.kernel.org; linux-stm32@st-md-mailman.stormreply.com; > linux-pm@vger.kernel.org; Frank Li <frank.li@nxp.com>; Ye Li <ye.li@nxp.com>; > Jacky Bai <ping.bai@nxp.com>; Peng Fan <peng.fan@nxp.com>; Aisheng Dong > <aisheng.dong@nxp.com>; Clark Wang <xiaoning.wang@nxp.com> > Subject: Re: [PATCH v5 2/9] dt-bindings: soc: imx-blk-ctrl: add i.MX91 > blk-ctrl compatible > > > On 13/06/2025 12:02, Joy Zou wrote: > > Add new compatible string "fsl,imx91-media-blk-ctrl" for i.MX91, which > > has different input clocks compared to i.MX93. Update the clock-names > > list and handle it in the if-else branch accordingly. > > > > Keep the same restriction for the existed compatible strings. > > > > Signed-off-by: Joy Zou <joy.zou@nxp.com> > > --- > > .../soc/imx/fsl,imx93-media-blk-ctrl.yaml | 55 +++++++++++++++---- > > 1 file changed, 43 insertions(+), 12 deletions(-) > > This wasn't here in v4 and changelog is silent about it. Thanks for your comments! Only add changelog in cover letter and miss changelog in this patch. Will add changelog in per patch for the convenience of review. BR Joy Zou > > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml index b3554e7f9e76..db5ee65f8eb8 100644 --- a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml @@ -18,7 +18,9 @@ description: properties: compatible: items: - - const: fsl,imx93-media-blk-ctrl + - enum: + - fsl,imx91-media-blk-ctrl + - fsl,imx93-media-blk-ctrl - const: syscon reg: @@ -31,21 +33,50 @@ properties: maxItems: 1 clocks: + minItems: 8 maxItems: 10 clock-names: - items: - - const: apb - - const: axi - - const: nic - - const: disp - - const: cam - - const: pxp - - const: lcdif - - const: isi - - const: csi - - const: dsi + minItems: 8 + maxItems: 10 +allOf: + - if: + properties: + compatible: + contains: + const: fsl,imx93-media-blk-ctrl + then: + properties: + clock-names: + items: + - const: apb + - const: axi + - const: nic + - const: disp + - const: cam + - const: pxp + - const: lcdif + - const: isi + - const: csi + - const: dsi + - if: + properties: + compatible: + contains: + const: fsl,imx91-media-blk-ctrl + then: + properties: + clock-names: + items: + - const: apb + - const: axi + - const: nic + - const: disp + - const: cam + - const: lcdif + - const: isi + - const: csi required: - compatible - reg
Add new compatible string "fsl,imx91-media-blk-ctrl" for i.MX91, which has different input clocks compared to i.MX93. Update the clock-names list and handle it in the if-else branch accordingly. Keep the same restriction for the existed compatible strings. Signed-off-by: Joy Zou <joy.zou@nxp.com> --- .../soc/imx/fsl,imx93-media-blk-ctrl.yaml | 55 +++++++++++++++---- 1 file changed, 43 insertions(+), 12 deletions(-)