| Message ID | 20250614-dev-adp5589-fw-v5-0-7e9d84906268@analog.com |
|---|---|
| Headers | show |
| Series | mfd: adp5585: support keymap events and drop legacy Input driver | expand |
On Sat, 14 Jun 2025, Nuno Sá via B4 Relay wrote: > Hi all, > > Here it goes v4. Main changes is to drop chip info based struct and > directly use an enum in the FW .data pointer, use the notifier API for > dispatching events and multiple calls to mfd_add_devices(). > > Regarding the last point, I think I could have used multiple calls to > devm_mfd_add_devices() and avoid those gotos in adp5585_add_devices() > but I do not feel that would have been "correct". > > Thanks! > - Nuno Sá > > --- > Changes in v5: > - Patch 2: > * Use the existing devm_mfd_add_devices(). > - Patch 3: > * Remove TODO comment. > - Patch 4: > * Mention in the commit message the Copyright update. > - Patch 6: > * Return a struct regmap_config pointer in > adp5585_fill_regmap_config(); > * Just leave a blank entry in the adp5585_regmap_defaults array. > - Patch 13: > * Improve comments for pin6 (row5) validation; > * Don't use magic numbers; > * Drop some odd line breaks; > * Initialize vartiable when declaring. > - Patch 14: > * Drop double spaces; > * Don't use magic numbers; > * Improve some comments. > - Patch 16: > * Fix missing semicolon. > - Patch 20: > * DS -> datasheet. > > - Link to v4: https://lore.kernel.org/r/20250521-dev-adp5589-fw-v4-0-f2c988d7a7a0@analog.com > - Link to v3: https://lore.kernel.org/r/20250512-dev-adp5589-fw-v3-0-092b14b79a88@analog.com > - Link to v2: https://lore.kernel.org/r/20250415-dev-adp5589-fw-v2-0-3a799c3ed812@analog.com > - Link to v1: https://lore.kernel.org/r/20250313-dev-adp5589-fw-v1-0-20e80d4bd4ea@analog.com Okay, that's it from me. Please respin those nits, then you should be good to go.
Hi all, Here it goes v4. Main changes is to drop chip info based struct and directly use an enum in the FW .data pointer, use the notifier API for dispatching events and multiple calls to mfd_add_devices(). Regarding the last point, I think I could have used multiple calls to devm_mfd_add_devices() and avoid those gotos in adp5585_add_devices() but I do not feel that would have been "correct". Thanks! - Nuno Sá --- Changes in v5: - Patch 2: * Use the existing devm_mfd_add_devices(). - Patch 3: * Remove TODO comment. - Patch 4: * Mention in the commit message the Copyright update. - Patch 6: * Return a struct regmap_config pointer in adp5585_fill_regmap_config(); * Just leave a blank entry in the adp5585_regmap_defaults array. - Patch 13: * Improve comments for pin6 (row5) validation; * Don't use magic numbers; * Drop some odd line breaks; * Initialize vartiable when declaring. - Patch 14: * Drop double spaces; * Don't use magic numbers; * Improve some comments. - Patch 16: * Fix missing semicolon. - Patch 20: * DS -> datasheet. - Link to v4: https://lore.kernel.org/r/20250521-dev-adp5589-fw-v4-0-f2c988d7a7a0@analog.com - Link to v3: https://lore.kernel.org/r/20250512-dev-adp5589-fw-v3-0-092b14b79a88@analog.com - Link to v2: https://lore.kernel.org/r/20250415-dev-adp5589-fw-v2-0-3a799c3ed812@analog.com - Link to v1: https://lore.kernel.org/r/20250313-dev-adp5589-fw-v1-0-20e80d4bd4ea@analog.com --- Nuno Sá (20): dt-bindings: mfd: adp5585: ease on the required properties mfd: adp5585: only add devices given in FW mfd: adp5585: enable oscilator during probe mfd: adp5585: make use of MFD_CELL_NAME() dt-bindings: mfd: adp5585: document adp5589 I/O expander mfd: adp5585: refactor how regmap defaults are handled mfd: adp5585: add support for adp5589 mfd: adp5585: add a per chip reg struture gpio: adp5585: add support for the adp5589 expander pwm: adp5585: add support for adp5589 dt-bindings: mfd: adp5585: add properties for input events mfd: adp5585: add support for event handling mfd: adp5585: support reset and unlock events mfd: adp5585: add support for input devices gpio: adp5585: support gpi events Input: adp5585: Add Analog Devices ADP5585/89 support Input: adp5589: remove the driver mfd: adp5585: support getting vdd regulator dt-bindings: mfd: adp5585: document reset gpio mfd: adp5585: add support for a reset pin .../devicetree/bindings/mfd/adi,adp5585.yaml | 240 ++++- .../devicetree/bindings/trivial-devices.yaml | 2 - MAINTAINERS | 1 + drivers/gpio/Kconfig | 1 + drivers/gpio/gpio-adp5585.c | 364 ++++++- drivers/input/keyboard/Kconfig | 21 +- drivers/input/keyboard/Makefile | 2 +- drivers/input/keyboard/adp5585-keys.c | 371 +++++++ drivers/input/keyboard/adp5589-keys.c | 1066 -------------------- drivers/mfd/adp5585.c | 743 +++++++++++++- drivers/pwm/pwm-adp5585.c | 78 +- include/linux/mfd/adp5585.h | 118 ++- 12 files changed, 1799 insertions(+), 1208 deletions(-) --- base-commit: 407f60a151df3c44397e5afc0111eb9b026c38d3 change-id: 20250311-dev-adp5589-fw-e04cfd945286 -- Thanks! - Nuno Sá