diff mbox series

[3/3] rtmutex: remove unnecessary adjust prio

Message ID 1495689995-29849-3-git-send-email-alex.shi@linaro.org
State Superseded
Headers show
Series None | expand

Commit Message

Alex Shi May 25, 2017, 5:26 a.m. UTC 
We don't need to adjust prio before new pi_waiter adding. The prio
only need update after pi_waiter change or task priority change.

Signed-off-by: Alex Shi <alex.shi@linaro.org>

Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Sebastian Siewior <bigeasy@linutronix.de>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Juri Lelli <juri.lelli@arm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
To: linux-kernel@vger.kernel.org
To: Ingo Molnar <mingo@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
---
 kernel/locking/rtmutex.c | 1 -
 1 file changed, 1 deletion(-)

-- 
1.9.1

Comments

Alex Shi June 20, 2017, 12:40 a.m. UTC | #1 
CC fengguang.

This patch survived in Fengguang's 0day testing on
https://github.com/alexshi/power-scheduling.git rtmutex-doc :)

Regards
Alex

On 05/25/2017 01:26 PM, Alex Shi wrote:
> We don't need to adjust prio before new pi_waiter adding. The prio

> only need update after pi_waiter change or task priority change.

> 

> Signed-off-by: Alex Shi <alex.shi@linaro.org>

> Cc: Steven Rostedt <rostedt@goodmis.org>

> Cc: Sebastian Siewior <bigeasy@linutronix.de>

> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>

> Cc: Juri Lelli <juri.lelli@arm.com>

> Cc: Thomas Gleixner <tglx@linutronix.de>

> To: linux-kernel@vger.kernel.org

> To: Ingo Molnar <mingo@redhat.com>

> To: Peter Zijlstra <peterz@infradead.org>

> ---

>  kernel/locking/rtmutex.c | 1 -

>  1 file changed, 1 deletion(-)

> 

> diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c

> index b955094..b659ba0 100644

> --- a/kernel/locking/rtmutex.c

> +++ b/kernel/locking/rtmutex.c

> @@ -963,7 +963,6 @@ static int task_blocks_on_rt_mutex(struct rt_mutex *lock,

>  		return -EDEADLK;

>  

>  	raw_spin_lock(&task->pi_lock);

> -	rt_mutex_adjust_prio(task);

>  	waiter->task = task;

>  	waiter->lock = lock;

>  	waiter->prio = task->prio;

>
diff mbox series

Patch

diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c
index b955094..b659ba0 100644
--- a/kernel/locking/rtmutex.c
+++ b/kernel/locking/rtmutex.c
@@ -963,7 +963,6 @@  static int task_blocks_on_rt_mutex(struct rt_mutex *lock,
 		return -EDEADLK;
 
 	raw_spin_lock(&task->pi_lock);
-	rt_mutex_adjust_prio(task);
 	waiter->task = task;
 	waiter->lock = lock;
 	waiter->prio = task->prio;