diff mbox

kconfig-frontends: fix another build race

Message ID 1495815229-10309-1-git-send-email-ross.burton@intel.com
State Accepted
Commit ad915e9baa04c73981c4795a97da95cea40b50c2
Headers show

Commit Message

Ross Burton May 26, 2017, 4:13 p.m. UTC
It is possible that frontends/kconfig is written to by sed before frontends/
exists, so add a mkdir to ensure the directory always exits.

[ YOCTO #11574 ]

Signed-off-by: Ross Burton <ross.burton@intel.com>

---
 meta/recipes-devtools/kconfig-frontends/files/missing-mkdir.patch | 4 ++++
 1 file changed, 4 insertions(+)

-- 
2.8.1

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Comments

Khem Raj May 26, 2017, 4:25 p.m. UTC | #1
On Fri, May 26, 2017 at 9:13 AM, Ross Burton <ross.burton@intel.com> wrote:
> It is possible that frontends/kconfig is written to by sed before frontends/

> exists, so add a mkdir to ensure the directory always exits.

>

> [ YOCTO #11574 ]

>


this package should probably be retired from oe-core. I added it as
part of eglibc
kconfig support which we have dropped few releases back.


> Signed-off-by: Ross Burton <ross.burton@intel.com>

> ---

>  meta/recipes-devtools/kconfig-frontends/files/missing-mkdir.patch | 4 ++++

>  1 file changed, 4 insertions(+)

>

> diff --git a/meta/recipes-devtools/kconfig-frontends/files/missing-mkdir.patch b/meta/recipes-devtools/kconfig-frontends/files/missing-mkdir.patch

> index a06a547..a11186e 100644

> --- a/meta/recipes-devtools/kconfig-frontends/files/missing-mkdir.patch

> +++ b/meta/recipes-devtools/kconfig-frontends/files/missing-mkdir.patch

> @@ -21,6 +21,10 @@ diff --git a/Makefile.am b/Makefile.am

>  index c8e96ef..1baa110 100644

>  --- a/Makefile.am

>  +++ b/Makefile.am

> +@@ -173,2 +173,3 @@ bin_SCRIPTS += frontends/kconfig

> + frontends/kconfig: frontends/kconfig.in

> ++      $(MKDIR_P) $(@D)

> +       $(AM_V_GEN)$(SED) -e 's/@KCFG_LIST@/$(kcfg_list)/g' \

>  @@ -348,6 +348,7 @@ EXTRA_DIST += \

>         utils/kconfig-tweak.in.patch

>

> --

> 2.8.1

>

> --

> _______________________________________________

> Openembedded-core mailing list

> Openembedded-core@lists.openembedded.org

> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Ross Burton May 26, 2017, 4:27 p.m. UTC | #2
On 26 May 2017 at 17:25, Khem Raj <raj.khem@gmail.com> wrote:

> this package should probably be retired from oe-core. I added it as

> part of eglibc

> kconfig support which we have dropped few releases back.

>


If you added it, and nobody else really wants it, feel free to submit a
removal patch.

Ross
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Peter Kjellerstedt June 1, 2017, 8:04 a.m. UTC | #3
We use it, so if you want to remove it from OE-core, then please move it to meta-oe.

//Peter

From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of Burton, Ross

Sent: den 26 maj 2017 18:27
To: Khem Raj <raj.khem@gmail.com>
Cc: Patches and discussions about the oe-core layer <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] kconfig-frontends: fix another build race


On 26 May 2017 at 17:25, Khem Raj <raj.khem@gmail.com<mailto:raj.khem@gmail.com>> wrote:
this package should probably be retired from oe-core. I added it as
part of eglibc
kconfig support which we have dropped few releases back.

If you added it, and nobody else really wants it, feel free to submit a removal patch.

Ross
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
diff mbox

Patch

diff --git a/meta/recipes-devtools/kconfig-frontends/files/missing-mkdir.patch b/meta/recipes-devtools/kconfig-frontends/files/missing-mkdir.patch
index a06a547..a11186e 100644
--- a/meta/recipes-devtools/kconfig-frontends/files/missing-mkdir.patch
+++ b/meta/recipes-devtools/kconfig-frontends/files/missing-mkdir.patch
@@ -21,6 +21,10 @@  diff --git a/Makefile.am b/Makefile.am
 index c8e96ef..1baa110 100644
 --- a/Makefile.am
 +++ b/Makefile.am
+@@ -173,2 +173,3 @@ bin_SCRIPTS += frontends/kconfig
+ frontends/kconfig: frontends/kconfig.in
++	$(MKDIR_P) $(@D)
+ 	$(AM_V_GEN)$(SED) -e 's/@KCFG_LIST@/$(kcfg_list)/g' \
 @@ -348,6 +348,7 @@ EXTRA_DIST += \
  	utils/kconfig-tweak.in.patch