| Message ID | 1498117882-21695-1-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | Accepted |
| Commit | 5e75ea15067ab8118a16f5b5f278ccae87819683 |
| Headers | show |
On Thu, Jun 22, 2017 at 3:51 PM, Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > These are only used in drivers/mis/i2c_eeprom.c > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > drivers/misc/i2c_eeprom.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Hello Masahiro, Am 22.06.2017 um 09:51 schrieb Masahiro Yamada: > These are only used in drivers/mis/i2c_eeprom.c > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > drivers/misc/i2c_eeprom.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Thanks! Reviewed-by: Heiko Schocher <hs@denx.de> bye, Heiko > > diff --git a/drivers/misc/i2c_eeprom.c b/drivers/misc/i2c_eeprom.c > index da6e2b05f730..a14e83225bcc 100644 > --- a/drivers/misc/i2c_eeprom.c > +++ b/drivers/misc/i2c_eeprom.c > @@ -42,7 +42,7 @@ static int i2c_eeprom_std_write(struct udevice *dev, int offset, > return -ENODEV; > } > > -struct i2c_eeprom_ops i2c_eeprom_std_ops = { > +static const struct i2c_eeprom_ops i2c_eeprom_std_ops = { > .read = i2c_eeprom_std_read, > .write = i2c_eeprom_std_write, > }; > @@ -59,7 +59,7 @@ static int i2c_eeprom_std_ofdata_to_platdata(struct udevice *dev) > return 0; > } > > -int i2c_eeprom_std_probe(struct udevice *dev) > +static int i2c_eeprom_std_probe(struct udevice *dev) > { > return 0; > } >
On 22 June 2017 at 01:51, Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > These are only used in drivers/mis/i2c_eeprom.c > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > drivers/misc/i2c_eeprom.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Simon Glass <sjg@chromium.org>
diff --git a/drivers/misc/i2c_eeprom.c b/drivers/misc/i2c_eeprom.c index da6e2b05f730..a14e83225bcc 100644 --- a/drivers/misc/i2c_eeprom.c +++ b/drivers/misc/i2c_eeprom.c @@ -42,7 +42,7 @@ static int i2c_eeprom_std_write(struct udevice *dev, int offset, return -ENODEV; } -struct i2c_eeprom_ops i2c_eeprom_std_ops = { +static const struct i2c_eeprom_ops i2c_eeprom_std_ops = { .read = i2c_eeprom_std_read, .write = i2c_eeprom_std_write, }; @@ -59,7 +59,7 @@ static int i2c_eeprom_std_ofdata_to_platdata(struct udevice *dev) return 0; } -int i2c_eeprom_std_probe(struct udevice *dev) +static int i2c_eeprom_std_probe(struct udevice *dev) { return 0; }
These are only used in drivers/mis/i2c_eeprom.c Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- drivers/misc/i2c_eeprom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)