| Message ID | 20170630155431.23824-2-julien.grall@arm.com |
|---|---|
| State | Accepted |
| Commit | 5e2af95aeb168d90c5900d35d663691f595fb012 |
| Headers | show |
| Series | xen/arm: Clean-up memory subsystems | expand |
On Fri, 30 Jun 2017, Julien Grall wrote: > xenheap_mfn_end is storing an MFN and not a physical address. The value will > be reset after the loop. So drop this bogus xenheap_mfn_end. > > Signed-off-by: Julien Grall <julien.grall@arm.com> > --- > Changes in v2: > - Update commit message > > Changes in v3: > - Don't mention the fact that Xen is not currently using > xenheap_mfn_end. > - Add Stefano's reviewed-by You didn't actually add my reviewed-by :-) But that's OK > --- > xen/arch/arm/setup.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c > index f00f29a45b..ab4d8e4218 100644 > --- a/xen/arch/arm/setup.c > +++ b/xen/arch/arm/setup.c > @@ -654,8 +654,6 @@ static void __init setup_mm(unsigned long dtb_paddr, size_t dtb_size) > if ( e > bank_end ) > e = bank_end; > > - xenheap_mfn_end = e; > - > dt_unreserved_regions(s, e, init_boot_pages, 0); > s = n; > } > -- > 2.11.0 >
diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index f00f29a45b..ab4d8e4218 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -654,8 +654,6 @@ static void __init setup_mm(unsigned long dtb_paddr, size_t dtb_size) if ( e > bank_end ) e = bank_end; - xenheap_mfn_end = e; - dt_unreserved_regions(s, e, init_boot_pages, 0); s = n; }
xenheap_mfn_end is storing an MFN and not a physical address. The value will be reset after the loop. So drop this bogus xenheap_mfn_end. Signed-off-by: Julien Grall <julien.grall@arm.com> --- Changes in v2: - Update commit message Changes in v3: - Don't mention the fact that Xen is not currently using xenheap_mfn_end. - Add Stefano's reviewed-by --- xen/arch/arm/setup.c | 2 -- 1 file changed, 2 deletions(-)