diff mbox

ARM: SAMSUNG: Fix HDMI related warnings

Message ID 1346136077-1226-1-git-send-email-sachin.kamat@linaro.org
State Accepted
Headers show

Commit Message

Sachin Kamat Aug. 28, 2012, 6:41 a.m. UTC
Silences the following warnings:
arch/arm/plat-samsung/devs.c:765:31: warning:
symbol 's5p_hdmi_def_platdata' was not declared. Should it be static?
arch/arm/plat-samsung/devs.c:767:13: warning:
symbol 's5p_hdmi_set_platdata' was not declared. Should it be static?

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 arch/arm/plat-samsung/devs.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Comments

Kukjin Kim Sept. 7, 2012, 6:16 a.m. UTC | #1
Sachin Kamat wrote:
> 
> Silences the following warnings:
> arch/arm/plat-samsung/devs.c:765:31: warning:
> symbol 's5p_hdmi_def_platdata' was not declared. Should it be static?
> arch/arm/plat-samsung/devs.c:767:13: warning:
> symbol 's5p_hdmi_set_platdata' was not declared. Should it be static?
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  arch/arm/plat-samsung/devs.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c
> index 6ff45d5..565cea7 100644
> --- a/arch/arm/plat-samsung/devs.c
> +++ b/arch/arm/plat-samsung/devs.c
> @@ -51,6 +51,7 @@
>  #include <plat/ehci.h>
>  #include <plat/fb.h>
>  #include <plat/fb-s3c2410.h>
> +#include <plat/hdmi.h>
>  #include <plat/hwmon.h>
>  #include <plat/iic.h>
>  #include <plat/keypad.h>
> @@ -762,7 +763,7 @@ void __init s5p_i2c_hdmiphy_set_platdata(struct
> s3c2410_platform_i2c *pd)
>  			       &s5p_device_i2c_hdmiphy);
>  }
> 
> -struct s5p_hdmi_platform_data s5p_hdmi_def_platdata;
> +static struct s5p_hdmi_platform_data s5p_hdmi_def_platdata;
> 
>  void __init s5p_hdmi_set_platdata(struct i2c_board_info *hdmiphy_info,
>  				  struct i2c_board_info *mhl_info, int
mhl_bus)
> --
> 1.7.4.1

Applied, thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
diff mbox

Patch

diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c
index 6ff45d5..565cea7 100644
--- a/arch/arm/plat-samsung/devs.c
+++ b/arch/arm/plat-samsung/devs.c
@@ -51,6 +51,7 @@ 
 #include <plat/ehci.h>
 #include <plat/fb.h>
 #include <plat/fb-s3c2410.h>
+#include <plat/hdmi.h>
 #include <plat/hwmon.h>
 #include <plat/iic.h>
 #include <plat/keypad.h>
@@ -762,7 +763,7 @@  void __init s5p_i2c_hdmiphy_set_platdata(struct s3c2410_platform_i2c *pd)
 			       &s5p_device_i2c_hdmiphy);
 }
 
-struct s5p_hdmi_platform_data s5p_hdmi_def_platdata;
+static struct s5p_hdmi_platform_data s5p_hdmi_def_platdata;
 
 void __init s5p_hdmi_set_platdata(struct i2c_board_info *hdmiphy_info,
 				  struct i2c_board_info *mhl_info, int mhl_bus)