[PULL,09/32] target/i386: [tcg] Port to insn_start

Message ID	20170906160612.22769-10-richard.henderson@linaro.org
State	Accepted
Commit	9d75f52b34053066b8e8fc37610d5f300d67538b
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; From: Richard Henderson <richard.henderson@linaro.org> To: qemu-devel@nongnu.org Date: Wed, 6 Sep 2017 09:05:49 -0700 Message-Id: <20170906160612.22769-10-richard.henderson@linaro.org> In-Reply-To: <20170906160612.22769-1-richard.henderson@linaro.org> References: <20170906160612.22769-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PULL 09/32] target/i386: [tcg] Port to insn_start Precedence: list Cc: peter.maydell@linaro.org, =?utf-8?q?Llu=C3=ADs_Vilanova?= <vilanova@ac.upc.edu>, Richard Henderson <rth@twiddle.net> Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+patch=linaro.org@nongnu.org>
Series	tcg generic translate loop \| expand [PULL,00/32] tcg generic translate loop [PULL,01/32] tcg: Add generic DISAS_NORETURN [PULL,02/32] target/i386: Use generic DISAS_* enumerators [PULL,03/32] target/arm: Use DISAS_NORETURN [PULL,04/32] target: [tcg] Use a generic enum for DISAS_ values [PULL,05/32] target/arm: Delay check for magic kernel page [PULL,06/32] tcg: Add generic translation framework [PULL,07/32] target/i386: [tcg] Port to DisasContextBase [PULL,08/32] target/i386: [tcg] Port to init_disas_context [PULL,09/32] target/i386: [tcg] Port to insn_start [PULL,10/32] target/i386: [tcg] Port to breakpoint_check [PULL,11/32] target/i386: [tcg] Port to translate_insn [PULL,12/32] target/i386: [tcg] Port to tb_stop [PULL,13/32] target/i386: [tcg] Port to disas_log [PULL,14/32] target/i386: [tcg] Port to generic translation framework [PULL,15/32] target/arm: [tcg] Port to DisasContextBase [PULL,16/32] target/arm: [tcg] Port to init_disas_context [PULL,17/32] target/arm: [tcg, a64] Port to init_disas_context [PULL,18/32] target/arm: [tcg] Port to tb_start [PULL,19/32] target/arm: [tcg] Port to insn_start [PULL,20/32] target/arm: [tcg, a64] Port to insn_start [PULL,21/32] target/arm: [tcg, a64] Port to breakpoint_check [PULL,22/32] target/arm: [tcg] Port to translate_insn [PULL,23/32] target/arm: [tcg, a64] Port to translate_insn [PULL,24/32] target/arm: [tcg] Port to tb_stop [PULL,25/32] target/arm: [tcg,a64] Port to tb_stop [PULL,26/32] target/arm: [tcg] Port to disas_log [PULL,27/32] target/arm: [tcg,a64] Port to disas_log [PULL,28/32] target/arm: [tcg] Port to generic translation framework [PULL,29/32] target/arm: [a64] Move page and ss checks to init_disas_context [PULL,30/32] target/arm: Move ss check to init_disas_context [PULL,31/32] target/arm: Split out thumb_tr_translate_insn [PULL,32/32] target/arm: Perform per-insn cross-page check only for Thumb

Message ID

20170906160612.22769-10-richard.henderson@linaro.org

State

Accepted

Commit

9d75f52b34053066b8e8fc37610d5f300d67538b

Headers

Received-SPF: pass (google.com: domain of
	qemu-devel-bounces+patch=linaro.org@nongnu.org designates
	2001:4830:134:3::11 as permitted sender)
	client-ip=2001:4830:134:3::11; 
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Date: Wed,  6 Sep 2017 09:05:49 -0700
Message-Id: <20170906160612.22769-10-richard.henderson@linaro.org>
In-Reply-To: <20170906160612.22769-1-richard.henderson@linaro.org>
References: <20170906160612.22769-1-richard.henderson@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: [Qemu-devel] [PULL 09/32] target/i386: [tcg] Port to insn_start
Precedence: list
Cc: peter.maydell@linaro.org, =?utf-8?q?Llu=C3=ADs_Vilanova?=
	<vilanova@ac.upc.edu>, 	Richard Henderson <rth@twiddle.net>
Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org
Sender: "Qemu-devel" <qemu-devel-bounces+patch=linaro.org@nongnu.org>

Series

tcg generic translate loop | expand

Commit Message

Richard Henderson Sept. 6, 2017, 4:05 p.m. UTC

From: Lluís Vilanova <vilanova@ac.upc.edu>


Incrementally paves the way towards using the generic instruction translation
loop.

Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>

Reviewed-by: Emilio G. Cota <cota@braap.org>

Reviewed-by: Richard Henderson <rth@twiddle.net>

Reviewed-by: Alex Benneé <alex.benee@linaro.org>

Message-Id: <150002146647.22386.13380064201042141261.stgit@frigg.lan>
Signed-off-by: Richard Henderson <rth@twiddle.net>

---
 target/i386/translate.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

-- 
2.13.5

diff --git a/target/i386/translate.c b/target/i386/translate.c
index 4281e9bc56..b7e5854513 100644
--- a/target/i386/translate.c
+++ b/target/i386/translate.c
@@ -8449,6 +8449,13 @@  static int i386_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cpu,
     return max_insns;
 }
 
+static void i386_tr_insn_start(DisasContextBase *dcbase, CPUState *cpu)
+{
+    DisasContext *dc = container_of(dcbase, DisasContext, base);
+
+    tcg_gen_insn_start(dc->base.pc_next, dc->cc_op);
+}
+
 /* generate intermediate code for basic block 'tb'.  */
 void gen_intermediate_code(CPUState *cs, TranslationBlock *tb)
 {
@@ -8476,7 +8483,7 @@  void gen_intermediate_code(CPUState *cs, TranslationBlock *tb)
     num_insns = 0;
     gen_tb_start(tb);
     for(;;) {
-        tcg_gen_insn_start(dc->base.pc_next, dc->cc_op);
+        i386_tr_insn_start(&dc->base, cs);
         num_insns++;
 
         /* If RF is set, suppress an internally generated breakpoint.  */

[PULL,09/32] target/i386: [tcg] Port to insn_start

Commit Message

Patch