| Message ID | 5c7bbac3efb2149d79f5c1735f91e64e8ff303cf.1508360121.git.amit.kucheria@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | arm64 defconfig: enable additional led triggers | expand |
On 10/18/17 3:57 PM, Amit Kucheria wrote:
> Enable panic and disk activity triggers to tie to LED activity
Could you provide some explanation as to why we want this enabled for
ARM64? I don't have a problem with the change itself, but I think patch
descriptions for defconfig changes should include justifications.
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
On Thu, Oct 19, 2017 at 8:54 PM, Timur Tabi <timur@codeaurora.org> wrote: > On 10/18/17 3:57 PM, Amit Kucheria wrote: >> >> Enable panic and disk activity triggers to tie to LED activity > > > Could you provide some explanation as to why we want this enabled for ARM64? > I don't have a problem with the change itself, but I think patch > descriptions for defconfig changes should include justifications. Indeed. The blurb should be modified as follows: "Most development boards and devices have one or more LEDs. It is useful during debugging if they can be wired to show different behaviours such as disk or cpu activity or a load-average dependent heartbeat. Enable panic and disk activity triggers so they can be tied to LED activity during debugging as well." If this blurb works, I'll send out another version.
On 10/22/2017 11:56 PM, Amit Kucheria wrote: > > "Most development boards and devices have one or more LEDs. It is > useful during debugging if they can be wired to show different > behaviours such as disk or cpu activity or a load-average dependent > heartbeat. Enable panic and disk activity triggers so they can be tied > to LED activity during debugging as well." This is great, thanks. -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
On Mon, Oct 23, 2017 at 8:54 PM, Timur Tabi <timur@codeaurora.org> wrote: > On 10/22/2017 11:56 PM, Amit Kucheria wrote: >> >> >> "Most development boards and devices have one or more LEDs. It is >> useful during debugging if they can be wired to show different >> behaviours such as disk or cpu activity or a load-average dependent >> heartbeat. Enable panic and disk activity triggers so they can be tied >> to LED activity during debugging as well." > > > This is great, thanks. Can I take this as an ACK?
On 10/23/17 6:11 PM, Amit Kucheria wrote: >> This is great, thanks. > Can I take this as an ACK? Sure, but I'm not a maintainer for the defconfig, so it's just my personal opinion. -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
On 19 October 2017 at 02:27, Amit Kucheria <amit.kucheria@linaro.org> wrote: > Enable panic and disk activity triggers to tie to LED activity > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Regards, Mani > --- > arch/arm64/configs/defconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index 34480e9..4ed357f 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -460,6 +460,8 @@ CONFIG_LEDS_SYSCON=y > CONFIG_LEDS_TRIGGER_HEARTBEAT=y > CONFIG_LEDS_TRIGGER_CPU=y > CONFIG_LEDS_TRIGGER_DEFAULT_ON=y > +CONFIG_LEDS_TRIGGER_PANIC=y > +CONFIG_LEDS_TRIGGER_DISK=y > CONFIG_EDAC=y > CONFIG_RTC_CLASS=y > CONFIG_RTC_DRV_MAX77686=y > -- > 2.7.4 >
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 34480e9..4ed357f 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -460,6 +460,8 @@ CONFIG_LEDS_SYSCON=y CONFIG_LEDS_TRIGGER_HEARTBEAT=y CONFIG_LEDS_TRIGGER_CPU=y CONFIG_LEDS_TRIGGER_DEFAULT_ON=y +CONFIG_LEDS_TRIGGER_PANIC=y +CONFIG_LEDS_TRIGGER_DISK=y CONFIG_EDAC=y CONFIG_RTC_CLASS=y CONFIG_RTC_DRV_MAX77686=y
Enable panic and disk activity triggers to tie to LED activity Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> --- arch/arm64/configs/defconfig | 2 ++ 1 file changed, 2 insertions(+) -- 2.7.4