| Message ID | 20171102053922.33426-1-raj.khem@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [V3] musl: Update to 1.1.18 | expand |
On 11/02/2017 07:39 AM, Khem Raj wrote: > Changes since v2: Move to 1.1.18 release > -PV = "1.1.16+git${SRCPV}" > +PV = "1.1.18+git${SRCPV}" Can you drop this, and simply rename the recipe to musl_1.1.18.bb please? Alex -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
On Thu, Nov 2, 2017 at 10:19 AM, Alexander Kanavin <alexander.kanavin@linux.intel.com> wrote: > On 11/02/2017 07:39 AM, Khem Raj wrote: > >> Changes since v2: Move to 1.1.18 release >> -PV = "1.1.16+git${SRCPV}" >> +PV = "1.1.18+git${SRCPV}" > > > Can you drop this, and simply rename the recipe to musl_1.1.18.bb please? Why? keeping it on _git makes sense to me. -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
On 11/02/2017 02:21 PM, Otavio Salvador wrote: > On Thu, Nov 2, 2017 at 10:19 AM, Alexander Kanavin > <alexander.kanavin@linux.intel.com> wrote: >> On 11/02/2017 07:39 AM, Khem Raj wrote: >> >>> Changes since v2: Move to 1.1.18 release >>> -PV = "1.1.16+git${SRCPV}" >>> +PV = "1.1.18+git${SRCPV}" >> >> >> Can you drop this, and simply rename the recipe to musl_1.1.18.bb please? > > Why? keeping it on _git makes sense to me. Only if it's a random development revision (e.g. 1.1.18 plus a bunch of commits) - if the version taken is a pristine tagged release, it should be indicated as such, regardless of whether it's taken from a tarball or a git checkout. Alex -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
On Thu, Nov 2, 2017 at 5:24 AM Alexander Kanavin < alexander.kanavin@linux.intel.com> wrote: > On 11/02/2017 02:21 PM, Otavio Salvador wrote: > > On Thu, Nov 2, 2017 at 10:19 AM, Alexander Kanavin > > <alexander.kanavin@linux.intel.com> wrote: > >> On 11/02/2017 07:39 AM, Khem Raj wrote: > >> > >>> Changes since v2: Move to 1.1.18 release > >>> -PV = "1.1.16+git${SRCPV}" > >>> +PV = "1.1.18+git${SRCPV}" > >> > >> > >> Can you drop this, and simply rename the recipe to musl_1.1.18.bb > please? > > > > Why? keeping it on _git makes sense to me. > We always use a given srcrev always this time It just happens to match with release > > Only if it's a random development revision (e.g. 1.1.18 plus a bunch of > commits) - if the version taken is a pristine tagged release, it should > be indicated as such, regardless of whether it's taken from a tarball or > a git checkout. > > Alex > <div><br><div class="gmail_quote"><div dir="auto">On Thu, Nov 2, 2017 at 5:24 AM Alexander Kanavin <<a href="mailto:alexander.kanavin@linux.intel.com">alexander.kanavin@linux.intel.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 11/02/2017 02:21 PM, Otavio Salvador wrote:<br> > On Thu, Nov 2, 2017 at 10:19 AM, Alexander Kanavin<br> > <<a href="mailto:alexander.kanavin@linux.intel.com" target="_blank">alexander.kanavin@linux.intel.com</a>> wrote:<br> >> On 11/02/2017 07:39 AM, Khem Raj wrote:<br> >><br> >>> Changes since v2: Move to 1.1.18 release<br> >>> -PV = "1.1.16+git${SRCPV}"<br> >>> +PV = "1.1.18+git${SRCPV}"<br> >><br> >><br> >> Can you drop this, and simply rename the recipe to <a href="http://musl_1.1.18.bb" rel="noreferrer" target="_blank">musl_1.1.18.bb</a> please?<br> ><br> > Why? keeping it on _git makes sense to me.<br> </blockquote><div dir="auto"><br></div><div dir="auto">We always use a given srcrev always this time</div><div dir="auto">It just happens to match with release </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br> Only if it's a random development revision (e.g. 1.1.18 plus a bunch of<br> commits) - if the version taken is a pristine tagged release, it should<br> be indicated as such, regardless of whether it's taken from a tarball or<br> a git checkout.<br> <br> Alex<br> </blockquote></div></div> -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
On 11/02/2017 05:28 PM, Khem Raj wrote: > >> Can you drop this, and simply rename the recipe to > musl_1.1.18.bb <http://musl_1.1.18.bb> please? > > > > Why? keeping it on _git makes sense to me. > > > We always use a given srcrev always this time > It just happens to match with release But why the need to pick mid-development commits, rather than stick with tagged releases? Alex -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
On Thu, Nov 2, 2017 at 8:30 AM, Alexander Kanavin <alexander.kanavin@linux.intel.com> wrote: > On 11/02/2017 05:28 PM, Khem Raj wrote: > >> >> Can you drop this, and simply rename the recipe to >> musl_1.1.18.bb <http://musl_1.1.18.bb> please? >> > >> > Why? keeping it on _git makes sense to me. >> >> >> We always use a given srcrev always this time >> It just happens to match with release > > > But why the need to pick mid-development commits, rather than stick with > tagged releases? We do not carry any patches and musl releases aren't frequent. It has served us well since we have been able to get regression fixed upstream as they happened with musl on OE I wish every project was usable in this fashion. > > Alex -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
On Thu, Nov 2, 2017 at 10:24 AM, Alexander Kanavin <alexander.kanavin@linux.intel.com> wrote: > On 11/02/2017 02:21 PM, Otavio Salvador wrote: >> >> On Thu, Nov 2, 2017 at 10:19 AM, Alexander Kanavin >> <alexander.kanavin@linux.intel.com> wrote: >>> >>> On 11/02/2017 07:39 AM, Khem Raj wrote: >>> >>>> Changes since v2: Move to 1.1.18 release >>>> -PV = "1.1.16+git${SRCPV}" >>>> +PV = "1.1.18+git${SRCPV}" >>> >>> >>> >>> Can you drop this, and simply rename the recipe to musl_1.1.18.bb please? >> >> >> Why? keeping it on _git makes sense to me. > > > Only if it's a random development revision (e.g. 1.1.18 plus a bunch of > commits) - if the version taken is a pristine tagged release, it should be > indicated as such, regardless of whether it's taken from a tarball or a git > checkout. I agree partially; if it points to a tag it can be said in a comment ... using SRCPV for this kind of recipe makes sense as it allows for easy tracking of the revision in use. -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
On 11/02/2017 06:10 PM, Otavio Salvador wrote: > I agree partially; if it points to a tag it can be said in a comment > ... using SRCPV for this kind of recipe makes sense as it allows for > easy tracking of the revision in use. But you can use SRCREV for that. Why the need specifically for SRCPV? Alex -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
On 11/02/2017 05:21 AM, Otavio Salvador wrote: > On Thu, Nov 2, 2017 at 10:19 AM, Alexander Kanavin > <alexander.kanavin@linux.intel.com> wrote: >> On 11/02/2017 07:39 AM, Khem Raj wrote: >> >>> Changes since v2: Move to 1.1.18 release >>> -PV = "1.1.16+git${SRCPV}" >>> +PV = "1.1.18+git${SRCPV}" >> >> Can you drop this, and simply rename the recipe to musl_1.1.18.bb please? > Why? keeping it on _git makes sense to me. SRCPV causes package versioning havoc. You can not tell what version 1.1.8+git(hash) or 1.1.8+git(hash) is the latest on a system. Can your package manage figure that out? - Armin >
On 11/03/2017 05:08 PM, akuster808 wrote: > SRCPV causes package versioning havoc. You can not tell what version > 1.1.8+git(hash) or 1.1.8+git(hash) is the latest on a system. Can your > package manage figure that out? I thought the entire point of SRCPV is to provide something that is guaranteed to increase over time? It makes sense when taking random revisions from git, but when git is used only for tagged releases, it's just annoying visual clutter. Alex
On Fri, Nov 3, 2017 at 1:34 PM, Alexander Kanavin <alexander.kanavin@linux.intel.com> wrote: > On 11/03/2017 05:08 PM, akuster808 wrote: > >> SRCPV causes package versioning havoc. You can not tell what version >> 1.1.8+git(hash) or 1.1.8+git(hash) is the latest on a system. Can your >> package manage figure that out? > > I thought the entire point of SRCPV is to provide something that is > guaranteed to increase over time? It makes sense when taking random > revisions from git, but when git is used only for tagged releases, it's just > annoying visual clutter. Honestly, the recipe name should interfere with this. In fact using git for a git-based recipe makes more sense to me. Anyway, as Khem mentioned, musl often points to non-tag revision when bug fixes are made so I think there is no point in keeping this discussion going. -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
diff --git a/meta/recipes-core/musl/musl_git.bb b/meta/recipes-core/musl/musl_git.bb index bd7573e0f3..932c9a27a0 100644 --- a/meta/recipes-core/musl/musl_git.bb +++ b/meta/recipes-core/musl/musl_git.bb @@ -3,9 +3,9 @@ require musl.inc -SRCREV = "da438ee1fc516c41ba1790cef7be551a9e244397" +SRCREV = "eb03bde2f24582874cb72b56c7811bf51da0c817" -PV = "1.1.16+git${SRCPV}" +PV = "1.1.18+git${SRCPV}" # mirror is at git://github.com/kraj/musl.git
Rich Felker (10): fix use of memset without declaration in sched.h cpu set macros fix access by setjmp and longjmp to __hwcap on arm built as thumb2 for executing init array functions, use function type with prototype fix read-after-free type error in pthread_detach fix incorrect base name offset from nftw when pathname ends in slash(es) in dns parsing callback, enforce MAXADDRS to preclude overflow release 1.1.17 fix regression in glob with literal . or .. path component fix build regression on ARM for ISA levels less than v5 release 1.1.18 Szabolcs Nagy (2): powerpc{64}: fix MAP_NORESERVE and MAP_LOCKED in mman.h math: rewrite fma with mostly int arithmetics Will Dietz (1): posix_spawn: use larger stack to cover worst-case in execvpe Signed-off-by: Khem Raj <raj.khem@gmail.com> --- Changes since v2: Move to 1.1.18 release meta/recipes-core/musl/musl_git.bb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.15.0 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core