| Message ID | 20171106135619.1248453-1-arnd@arndb.de |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] rtlwifi: fix uninitialized rtlhal->last_suspend_sec time | expand |
On 11/06/2017 07:55 AM, Arnd Bergmann wrote: > We set rtlhal->last_suspend_sec to an uninitialized stack variable, > but unfortunately gcc never warned about this, I only found it > while working on another patch. I opened a gcc bug for this. > > Presumably the value of rtlhal->last_suspend_sec is not all that > important, but it does get used, so we probably want the > patch backported to stable kernels. > > Cc: stable@vger.kernel.org > Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82839 > Signed-off-by: Arnd Bergmann <arnd@arndb.de> For all three of these patches: Acked-by: Larry Finger <Larry.Finger@lwfinger.net> Thanks, Larry > --- > drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c > index 60c82a5b51cd..20ffe856180e 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c > +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c > @@ -1373,6 +1373,7 @@ static void _rtl8821ae_get_wakeup_reason(struct ieee80211_hw *hw) > > ppsc->wakeup_reason = 0; > > + do_gettimeofday(&ts); > rtlhal->last_suspend_sec = ts.tv_sec; > > switch (fw_reason) { >
Arnd Bergmann <arnd@arndb.de> wrote: > We set rtlhal->last_suspend_sec to an uninitialized stack variable, > but unfortunately gcc never warned about this, I only found it > while working on another patch. I opened a gcc bug for this. > > Presumably the value of rtlhal->last_suspend_sec is not all that > important, but it does get used, so we probably want the > patch backported to stable kernels. > > Cc: stable@vger.kernel.org > Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82839 > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Acked-by: Larry Finger <Larry.Finger@lwfinger.net> 3 patches applied to wireless-drivers-next.git, thanks. 3f2a162fab15 rtlwifi: fix uninitialized rtlhal->last_suspend_sec time 3c92d5517af8 rtlwifi: use ktime_get_real_seconds() for suspend time ac978dc79a91 rtlwifi: drop unused ppsc->last_wakeup_time -- https://patchwork.kernel.org/patch/10043505/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c index 60c82a5b51cd..20ffe856180e 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c @@ -1373,6 +1373,7 @@ static void _rtl8821ae_get_wakeup_reason(struct ieee80211_hw *hw) ppsc->wakeup_reason = 0; + do_gettimeofday(&ts); rtlhal->last_suspend_sec = ts.tv_sec; switch (fw_reason) {
We set rtlhal->last_suspend_sec to an uninitialized stack variable, but unfortunately gcc never warned about this, I only found it while working on another patch. I opened a gcc bug for this. Presumably the value of rtlhal->last_suspend_sec is not all that important, but it does get used, so we probably want the patch backported to stable kernels. Cc: stable@vger.kernel.org Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82839 Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 1 + 1 file changed, 1 insertion(+) -- 2.9.0