diff mbox series

[edk2] ArmVirtPkg: add NOOPT target to platform .DSCs

Message ID 20171206113711.6040-1-ard.biesheuvel@linaro.org
State Accepted
Commit 80ee06cee70cec00a4674964c477f99e128e21e6
Headers show
Series [edk2] ArmVirtPkg: add NOOPT target to platform .DSCs | expand

Commit Message

Ard Biesheuvel Dec. 6, 2017, 11:37 a.m. UTC
In order to allow the ArmVirtPkg platforms to be built using the
NOOPT target, add it explicitly to the BUILD_TARGETS define.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

---
 ArmVirtPkg/ArmVirtQemu.dsc       | 2 +-
 ArmVirtPkg/ArmVirtQemuKernel.dsc | 2 +-
 ArmVirtPkg/ArmVirtXen.dsc        | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.11.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Laszlo Ersek Dec. 6, 2017, 2:14 p.m. UTC | #1
On 12/06/17 12:37, Ard Biesheuvel wrote:
> In order to allow the ArmVirtPkg platforms to be built using the

> NOOPT target, add it explicitly to the BUILD_TARGETS define.

> 

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---

>  ArmVirtPkg/ArmVirtQemu.dsc       | 2 +-

>  ArmVirtPkg/ArmVirtQemuKernel.dsc | 2 +-

>  ArmVirtPkg/ArmVirtXen.dsc        | 2 +-

>  3 files changed, 3 insertions(+), 3 deletions(-)

> 

> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc

> index f09226671827..76a83b99a303 100644

> --- a/ArmVirtPkg/ArmVirtQemu.dsc

> +++ b/ArmVirtPkg/ArmVirtQemu.dsc

> @@ -25,7 +25,7 @@ [Defines]

>    DSC_SPECIFICATION              = 0x00010005

>    OUTPUT_DIRECTORY               = Build/ArmVirtQemu-$(ARCH)

>    SUPPORTED_ARCHITECTURES        = AARCH64|ARM

> -  BUILD_TARGETS                  = DEBUG|RELEASE

> +  BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT

>    SKUID_IDENTIFIER               = DEFAULT

>    FLASH_DEFINITION               = ArmVirtPkg/ArmVirtQemu.fdf

>  

> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc

> index cc2c5a50c925..7d9a9196d640 100644

> --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc

> +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc

> @@ -25,7 +25,7 @@ [Defines]

>    DSC_SPECIFICATION              = 0x00010005

>    OUTPUT_DIRECTORY               = Build/ArmVirtQemuKernel-$(ARCH)

>    SUPPORTED_ARCHITECTURES        = AARCH64|ARM

> -  BUILD_TARGETS                  = DEBUG|RELEASE

> +  BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT

>    SKUID_IDENTIFIER               = DEFAULT

>    FLASH_DEFINITION               = ArmVirtPkg/ArmVirtQemuKernel.fdf

>  

> diff --git a/ArmVirtPkg/ArmVirtXen.dsc b/ArmVirtPkg/ArmVirtXen.dsc

> index 9b3cc2bd5a10..175b56d10c8f 100644

> --- a/ArmVirtPkg/ArmVirtXen.dsc

> +++ b/ArmVirtPkg/ArmVirtXen.dsc

> @@ -25,7 +25,7 @@ [Defines]

>    DSC_SPECIFICATION              = 0x00010005

>    OUTPUT_DIRECTORY               = Build/ArmVirtXen-$(ARCH)

>    SUPPORTED_ARCHITECTURES        = AARCH64|ARM

> -  BUILD_TARGETS                  = DEBUG|RELEASE

> +  BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT

>    SKUID_IDENTIFIER               = DEFAULT

>    FLASH_DEFINITION               = ArmVirtPkg/ArmVirtXen.fdf

>  

> 


Reviewed-by: Laszlo Ersek <lersek@redhat.com>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Ard Biesheuvel Dec. 6, 2017, 8:50 p.m. UTC | #2
On 6 December 2017 at 14:14, Laszlo Ersek <lersek@redhat.com> wrote:
> On 12/06/17 12:37, Ard Biesheuvel wrote:

>> In order to allow the ArmVirtPkg platforms to be built using the

>> NOOPT target, add it explicitly to the BUILD_TARGETS define.

>>

>> Contributed-under: TianoCore Contribution Agreement 1.1

>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

>> ---

>>  ArmVirtPkg/ArmVirtQemu.dsc       | 2 +-

>>  ArmVirtPkg/ArmVirtQemuKernel.dsc | 2 +-

>>  ArmVirtPkg/ArmVirtXen.dsc        | 2 +-

>>  3 files changed, 3 insertions(+), 3 deletions(-)

>>

>> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc

>> index f09226671827..76a83b99a303 100644

>> --- a/ArmVirtPkg/ArmVirtQemu.dsc

>> +++ b/ArmVirtPkg/ArmVirtQemu.dsc

>> @@ -25,7 +25,7 @@ [Defines]

>>    DSC_SPECIFICATION              = 0x00010005

>>    OUTPUT_DIRECTORY               = Build/ArmVirtQemu-$(ARCH)

>>    SUPPORTED_ARCHITECTURES        = AARCH64|ARM

>> -  BUILD_TARGETS                  = DEBUG|RELEASE

>> +  BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT

>>    SKUID_IDENTIFIER               = DEFAULT

>>    FLASH_DEFINITION               = ArmVirtPkg/ArmVirtQemu.fdf

>>

>> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc

>> index cc2c5a50c925..7d9a9196d640 100644

>> --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc

>> +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc

>> @@ -25,7 +25,7 @@ [Defines]

>>    DSC_SPECIFICATION              = 0x00010005

>>    OUTPUT_DIRECTORY               = Build/ArmVirtQemuKernel-$(ARCH)

>>    SUPPORTED_ARCHITECTURES        = AARCH64|ARM

>> -  BUILD_TARGETS                  = DEBUG|RELEASE

>> +  BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT

>>    SKUID_IDENTIFIER               = DEFAULT

>>    FLASH_DEFINITION               = ArmVirtPkg/ArmVirtQemuKernel.fdf

>>

>> diff --git a/ArmVirtPkg/ArmVirtXen.dsc b/ArmVirtPkg/ArmVirtXen.dsc

>> index 9b3cc2bd5a10..175b56d10c8f 100644

>> --- a/ArmVirtPkg/ArmVirtXen.dsc

>> +++ b/ArmVirtPkg/ArmVirtXen.dsc

>> @@ -25,7 +25,7 @@ [Defines]

>>    DSC_SPECIFICATION              = 0x00010005

>>    OUTPUT_DIRECTORY               = Build/ArmVirtXen-$(ARCH)

>>    SUPPORTED_ARCHITECTURES        = AARCH64|ARM

>> -  BUILD_TARGETS                  = DEBUG|RELEASE

>> +  BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT

>>    SKUID_IDENTIFIER               = DEFAULT

>>    FLASH_DEFINITION               = ArmVirtPkg/ArmVirtXen.fdf

>>

>>

>

> Reviewed-by: Laszlo Ersek <lersek@redhat.com>


Thanks. Pushed as 80ee06cee70c
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
diff mbox series

Patch

diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
index f09226671827..76a83b99a303 100644
--- a/ArmVirtPkg/ArmVirtQemu.dsc
+++ b/ArmVirtPkg/ArmVirtQemu.dsc
@@ -25,7 +25,7 @@  [Defines]
   DSC_SPECIFICATION              = 0x00010005
   OUTPUT_DIRECTORY               = Build/ArmVirtQemu-$(ARCH)
   SUPPORTED_ARCHITECTURES        = AARCH64|ARM
-  BUILD_TARGETS                  = DEBUG|RELEASE
+  BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT
   SKUID_IDENTIFIER               = DEFAULT
   FLASH_DEFINITION               = ArmVirtPkg/ArmVirtQemu.fdf
 
diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc
index cc2c5a50c925..7d9a9196d640 100644
--- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
+++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
@@ -25,7 +25,7 @@  [Defines]
   DSC_SPECIFICATION              = 0x00010005
   OUTPUT_DIRECTORY               = Build/ArmVirtQemuKernel-$(ARCH)
   SUPPORTED_ARCHITECTURES        = AARCH64|ARM
-  BUILD_TARGETS                  = DEBUG|RELEASE
+  BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT
   SKUID_IDENTIFIER               = DEFAULT
   FLASH_DEFINITION               = ArmVirtPkg/ArmVirtQemuKernel.fdf
 
diff --git a/ArmVirtPkg/ArmVirtXen.dsc b/ArmVirtPkg/ArmVirtXen.dsc
index 9b3cc2bd5a10..175b56d10c8f 100644
--- a/ArmVirtPkg/ArmVirtXen.dsc
+++ b/ArmVirtPkg/ArmVirtXen.dsc
@@ -25,7 +25,7 @@  [Defines]
   DSC_SPECIFICATION              = 0x00010005
   OUTPUT_DIRECTORY               = Build/ArmVirtXen-$(ARCH)
   SUPPORTED_ARCHITECTURES        = AARCH64|ARM
-  BUILD_TARGETS                  = DEBUG|RELEASE
+  BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT
   SKUID_IDENTIFIER               = DEFAULT
   FLASH_DEFINITION               = ArmVirtPkg/ArmVirtXen.fdf