| Message ID | 20171206145928.5497-1-ross.burton@intel.com |
|---|---|
| State | Accepted |
| Commit | 52263f5f6caeaf215ab96d58218fb5f9a2ed4264 |
| Headers | show |
| Series | [1/2] libxslt: use HTTP instead of FTP in SRC_URI | expand |
On Wed, 06 Dec 2017 15:02:57 -0000 Patchwork <patchwork@patchwork.openembedded.org> wrote: > == Series Details == > > Series: "libxslt: use HTTP instead of F..." and 1 more > Revision: 1 > URL : https://patchwork.openembedded.org/series/10099/ > State : failure > > == Summary == > > > Thank you for submitting this patch series to OpenEmbedded Core. This is > an automated response. Several tests have been executed on the proposed > series by patchtest resulting in the following failures: > > > > * Issue SRC_URI changed but checksums are the same [test_src_uri_checksums_not_changed] > Suggested fix Include the SRC_URI's checksums changes into your patch I believe we need to improve this check. checksums do not necessary change if URL changes. > > > > If you believe any of these test results are incorrect, please reply to the > mailing list (openembedded-core@lists.openembedded.org) raising your concerns. > Otherwise we would appreciate you correcting the issues and submitting a new > version of the patchset if applicable. Please ensure you add/increment the > version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> > [PATCH v3] -> ...). > > --- > Guidelines: https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines > Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest > Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe > > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
On 6 December 2017 at 16:00, Leonardo Sandoval < leonardo.sandoval.gonzalez@linux.intel.com> wrote: > On Wed, 06 Dec 2017 15:02:57 -0000 > Patchwork <patchwork@patchwork.openembedded.org> wrote: > > > == Series Details == > > > > Series: "libxslt: use HTTP instead of F..." and 1 more > > Revision: 1 > > URL : https://patchwork.openembedded.org/series/10099/ > > State : failure > > > > == Summary == > > > > > > Thank you for submitting this patch series to OpenEmbedded Core. This is > > an automated response. Several tests have been executed on the proposed > > series by patchtest resulting in the following failures: > > > > > > > > * Issue SRC_URI changed but checksums are the same > [test_src_uri_checksums_not_changed] > > Suggested fix Include the SRC_URI's checksums changes into your > patch > > > I believe we need to improve this check. checksums do not necessary change > if URL changes. > Not sure how to improve it. Maybe making the wording vague, as that is a common mistake and the URL changing but checksums not changing is not common. Ross <div dir="ltr">On 6 December 2017 at 16:00, Leonardo Sandoval <span dir="ltr"><<a href="mailto:leonardo.sandoval.gonzalez@linux.intel.com" target="_blank">leonardo.sandoval.gonzalez@linux.intel.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Wed, 06 Dec 2017 15:02:57 -0000<br> Patchwork <<a href="mailto:patchwork@patchwork.openembedded.org">patchwork@patchwork.<wbr>openembedded.org</a>> wrote:<br> <br> > == Series Details ==<br> ><br> > Series: "libxslt: use HTTP instead of F..." and 1 more<br> > Revision: 1<br> > URL : <a href="https://patchwork.openembedded.org/series/10099/" rel="noreferrer" target="_blank">https://patchwork.<wbr>openembedded.org/series/10099/</a><br> > State : failure<br> ><br> > == Summary ==<br> ><br> ><br> > Thank you for submitting this patch series to OpenEmbedded Core. This is<br> > an automated response. Several tests have been executed on the proposed<br> > series by patchtest resulting in the following failures:<br> ><br> ><br> ><br> > * Issue SRC_URI changed but checksums are the same [test_src_uri_checksums_not_<wbr>changed]<br> > Suggested fix Include the SRC_URI's checksums changes into your patch<br> <br> <br> I believe we need to improve this check. checksums do not necessary change if URL changes.<br></blockquote><div><br></div><div>Not sure how to improve it. Maybe making the wording vague, as that is a common mistake and the URL changing but checksums not changing is not common.</div><div><br></div><div>Ross </div></div></div></div> -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
On Wed, 6 Dec 2017 16:03:13 +0000 "Burton, Ross" <ross.burton@intel.com> wrote: > On 6 December 2017 at 16:00, Leonardo Sandoval < > leonardo.sandoval.gonzalez@linux.intel.com> wrote: > > > On Wed, 06 Dec 2017 15:02:57 -0000 > > Patchwork <patchwork@patchwork.openembedded.org> wrote: > > > > > == Series Details == > > > > > > Series: "libxslt: use HTTP instead of F..." and 1 more > > > Revision: 1 > > > URL : https://patchwork.openembedded.org/series/10099/ > > > State : failure > > > > > > == Summary == > > > > > > > > > Thank you for submitting this patch series to OpenEmbedded Core. This is > > > an automated response. Several tests have been executed on the proposed > > > series by patchtest resulting in the following failures: > > > > > > > > > > > > * Issue SRC_URI changed but checksums are the same > > [test_src_uri_checksums_not_changed] > > > Suggested fix Include the SRC_URI's checksums changes into your > > patch > > > > > > I believe we need to improve this check. checksums do not necessary change > > if URL changes. > > > > Not sure how to improve it. Maybe making the wording vague, as that is a > common mistake and the URL changing but checksums not changing is not > common. Rigth. Also bitbake fails if downloaded tarball does not match its checksums with the ones defined on recipe. Time to disable this check. > > Ross -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
diff --git a/meta/recipes-support/libxslt/libxslt_1.1.32.bb b/meta/recipes-support/libxslt/libxslt_1.1.32.bb index e8b1409d79b..b8951ab3a8b 100644 --- a/meta/recipes-support/libxslt/libxslt_1.1.32.bb +++ b/meta/recipes-support/libxslt/libxslt_1.1.32.bb @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://Copyright;md5=0cd9a07afbeb24026c9b03aecfeba458" SECTION = "libs" DEPENDS = "libxml2" -SRC_URI = "ftp://xmlsoft.org/libxslt/libxslt-${PV}.tar.gz \ +SRC_URI = "http://xmlsoft.org/sources/libxslt-${PV}.tar.gz \ file://pkgconfig_fix.patch \ "
FTP isn't as reliable as HTTP. [ YOCTO #12398 ] Signed-off-by: Ross Burton <ross.burton@intel.com> --- meta/recipes-support/libxslt/libxslt_1.1.32.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.11.0 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core