| Message ID | 20171209095624.20915-1-ard.biesheuvel@linaro.org |
|---|---|
| State | Accepted |
| Commit | 26b99f3bb3f1fc34962e203ba431447dcd2ad946 |
| Headers | show |
| Series | [edk2] ArmPkg/PlatformBootManagerLib: add missing newline | expand |
On Sat, Dec 09, 2017 at 09:56:24AM +0000, Ard Biesheuvel wrote: > Add a missing newline to the version string output that is displayed > on the serial console, or the next line will be appended to it. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > --- > ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c > index ccdb3e0a5d78..61ab61ccc780 100644 > --- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c > +++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c > @@ -549,7 +549,7 @@ PlatformBootManagerAfterConsole ( > Status = BootLogoEnableLogo (); > if (EFI_ERROR (Status)) { > if (FirmwareVerLength > 0) { > - Print (VERSION_STRING_PREFIX L"%s", > + Print (VERSION_STRING_PREFIX L"%s\n", > PcdGetPtr (PcdFirmwareVersionString)); > } > Print (L"Press ESCAPE for boot options "); > -- > 2.11.0 > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
On 11 December 2017 at 11:48, Leif Lindholm <leif.lindholm@linaro.org> wrote: > On Sat, Dec 09, 2017 at 09:56:24AM +0000, Ard Biesheuvel wrote: >> Add a missing newline to the version string output that is displayed >> on the serial console, or the next line will be appended to it. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > Thanks. Pushed as 26b99f3bb3f1fc34962e203ba431447dcd2ad946 >> --- >> ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c >> index ccdb3e0a5d78..61ab61ccc780 100644 >> --- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c >> +++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c >> @@ -549,7 +549,7 @@ PlatformBootManagerAfterConsole ( >> Status = BootLogoEnableLogo (); >> if (EFI_ERROR (Status)) { >> if (FirmwareVerLength > 0) { >> - Print (VERSION_STRING_PREFIX L"%s", >> + Print (VERSION_STRING_PREFIX L"%s\n", >> PcdGetPtr (PcdFirmwareVersionString)); >> } >> Print (L"Press ESCAPE for boot options "); >> -- >> 2.11.0 >> _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c index ccdb3e0a5d78..61ab61ccc780 100644 --- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c +++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c @@ -549,7 +549,7 @@ PlatformBootManagerAfterConsole ( Status = BootLogoEnableLogo (); if (EFI_ERROR (Status)) { if (FirmwareVerLength > 0) { - Print (VERSION_STRING_PREFIX L"%s", + Print (VERSION_STRING_PREFIX L"%s\n", PcdGetPtr (PcdFirmwareVersionString)); } Print (L"Press ESCAPE for boot options ");
Add a missing newline to the version string output that is displayed on the serial console, or the next line will be appended to it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> --- ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.11.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel