diff mbox series

[v2,01/16] target/arm: Mark disas_set_insn_syndrome inline

Message ID 20180119045438.28582-2-richard.henderson@linaro.org
State Accepted
Commit cf96a682481bbfb1e6b53d2436c3d51563d5dff8
Headers show
Series target/arm: Prepatory work for SVE | expand

Commit Message

Richard Henderson Jan. 19, 2018, 4:54 a.m. UTC
If it isn't used when translate.h is included,
we'll get a compiler Werror.

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

---
 target/arm/translate.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.14.3

Comments

Alex Bennée Jan. 19, 2018, 1:54 p.m. UTC | #1
Richard Henderson <richard.henderson@linaro.org> writes:

> If it isn't used when translate.h is included,

> we'll get a compiler Werror.

>

> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Reviewed-by: Alex Bennée <alex.bennee@linaro.org>


> ---

>  target/arm/translate.h | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

>

> diff --git a/target/arm/translate.h b/target/arm/translate.h

> index cd7313ace7..3f4df91e5e 100644

> --- a/target/arm/translate.h

> +++ b/target/arm/translate.h

> @@ -108,7 +108,7 @@ static inline int default_exception_el(DisasContext *s)

>              ? 3 : MAX(1, s->current_el);

>  }

>

> -static void disas_set_insn_syndrome(DisasContext *s, uint32_t syn)

> +static inline void disas_set_insn_syndrome(DisasContext *s, uint32_t syn)

>  {

>      /* We don't need to save all of the syndrome so we mask and shift

>       * out unneeded bits to help the sleb128 encoder do a better job.



--
Alex Bennée
diff mbox series

Patch

diff --git a/target/arm/translate.h b/target/arm/translate.h
index cd7313ace7..3f4df91e5e 100644
--- a/target/arm/translate.h
+++ b/target/arm/translate.h
@@ -108,7 +108,7 @@  static inline int default_exception_el(DisasContext *s)
             ? 3 : MAX(1, s->current_el);
 }
 
-static void disas_set_insn_syndrome(DisasContext *s, uint32_t syn)
+static inline void disas_set_insn_syndrome(DisasContext *s, uint32_t syn)
 {
     /* We don't need to save all of the syndrome so we mask and shift
      * out unneeded bits to help the sleb128 encoder do a better job.