| Message ID | 1517542227-32907-2-git-send-email-heyi.guo@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [edk2,edk2/MdePkg,v1] MdePkg ACPI: Add some macros for PPTT | expand |
Any comments for this patch? On 2018/2/2 11:30, Heyi Guo wrote: > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang <huangming23@huawei.com> > Signed-off-by: Heyi Guo <heyi.guo@linaro.org> > --- > MdePkg/Include/IndustryStandard/Acpi62.h | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/MdePkg/Include/IndustryStandard/Acpi62.h b/MdePkg/Include/IndustryStandard/Acpi62.h > index 2904d34..30faba9 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi62.h > +++ b/MdePkg/Include/IndustryStandard/Acpi62.h > @@ -2557,6 +2557,12 @@ typedef struct { > } EFI_ACPI_6_2_PPTT_STRUCTURE_HEADER; > > /// > +/// Value for valid fields in PPTT struct > +/// > +#define EFI_ACPI_6_2_PPTT_INVALID 0x0 > +#define EFI_ACPI_6_2_PPTT_VALID 0x1 > + > +/// > /// Processor hierarchy node structure flags > /// > typedef struct { > @@ -2593,6 +2599,18 @@ typedef struct { > } EFI_ACPI_6_2_PPTT_STRUCTURE_CACHE_FLAGS; > > /// > +/// For cache attributes > +/// > +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_ALLOCATION_READ 0x0 > +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_ALLOCATION_WRITE 0x1 > +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_ALLOCATION_READ_WRITE 0x2 > +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_CACHE_TYPE_DATA 0x0 > +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_CACHE_TYPE_INSTRUCTION 0x1 > +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_CACHE_TYPE_UNIFIED 0x2 > +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_WRITE_POLICY_WRITE_BACK 0x0 > +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_WRITE_POLICY_WRITE_THROUGH 0x1 > + > +/// > /// Cache Type Structure cache attributes > /// > typedef struct { > -- Best Regards, Ming _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
On 2018/2/6 12:16, Zeng, Star wrote: > How about using EFI_ACPI_6_2_PPTT_PROCESSOR_ID_XXX to be more specific? > like this? EFI_ACPI_6_2_PPTT_PROCESSOR_ID_PHYSICAL_PACKAGE 0x01 EFI_ACPI_6_2_PPTT_PROCESSOR_ID_ACPI_PROCESSOR 0x01 > Others are good to me. > > > Thanks, > Star > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Heyi Guo > Sent: Friday, February 2, 2018 11:30 AM > To: leif.lindholm@linaro.org; linaro-uefi@lists.linaro.org; edk2-devel@lists.01.org; graeme.gregory@linaro.org > Cc: huangming23@huawei.com; ard.biesheuvel@linaro.org; Gao, Liming <liming.gao@intel.com>; mengfanrong@huawei.com; guoheyi@huawei.com; Heyi Guo <heyi.guo@linaro.org>; zhangjinsong2@huawei.com; Kinney, Michael D <michael.d.kinney@intel.com>; waip23@126.com; wanghuiqiang@huawei.com; huangdaode@hisilicon.com > Subject: [edk2] [PATCH edk2/MdePkg v1] MdePkg ACPI: Add some macros for PPTT > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang <huangming23@huawei.com> > Signed-off-by: Heyi Guo <heyi.guo@linaro.org> > --- > MdePkg/Include/IndustryStandard/Acpi62.h | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/MdePkg/Include/IndustryStandard/Acpi62.h b/MdePkg/Include/IndustryStandard/Acpi62.h > index 2904d34..30faba9 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi62.h > +++ b/MdePkg/Include/IndustryStandard/Acpi62.h > @@ -2557,6 +2557,12 @@ typedef struct { > } EFI_ACPI_6_2_PPTT_STRUCTURE_HEADER; > > /// > +/// Value for valid fields in PPTT struct > +/// > +#define EFI_ACPI_6_2_PPTT_INVALID 0x0 > +#define EFI_ACPI_6_2_PPTT_VALID 0x1 > + > +/// > /// Processor hierarchy node structure flags > /// > typedef struct { > @@ -2593,6 +2599,18 @@ typedef struct { > } EFI_ACPI_6_2_PPTT_STRUCTURE_CACHE_FLAGS; > > /// > +/// For cache attributes > +/// > +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_ALLOCATION_READ 0x0 > +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_ALLOCATION_WRITE 0x1 > +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_ALLOCATION_READ_WRITE 0x2 > +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_CACHE_TYPE_DATA 0x0 > +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_CACHE_TYPE_INSTRUCTION 0x1 > +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_CACHE_TYPE_UNIFIED 0x2 > +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_WRITE_POLICY_WRITE_BACK 0x0 > +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_WRITE_POLICY_WRITE_THROUGH 0x1 > + > +/// > /// Cache Type Structure cache attributes > /// > typedef struct { > -- Best Regards, Ming _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
I mean +#define EFI_ACPI_6_2_PPTT_PROCESSOR_ID_INVALID 0x0 +#define EFI_ACPI_6_2_PPTT_PROCESSOR_ID_VALID 0x1 Thanks, Star -----Original Message----- From: Huangming (Mark) [mailto:huangming23@huawei.com] Sent: Tuesday, February 6, 2018 2:12 PM To: Zeng, Star <star.zeng@intel.com>; Heyi Guo <heyi.guo@linaro.org>; leif.lindholm@linaro.org; linaro-uefi@lists.linaro.org; edk2-devel@lists.01.org; graeme.gregory@linaro.org Cc: ard.biesheuvel@linaro.org; Gao, Liming <liming.gao@intel.com>; mengfanrong@huawei.com; guoheyi@huawei.com; zhangjinsong2@huawei.com; Kinney, Michael D <michael.d.kinney@intel.com>; waip23@126.com; wanghuiqiang@huawei.com; huangdaode@hisilicon.com Subject: Re: [edk2] [PATCH edk2/MdePkg v1] MdePkg ACPI: Add some macros for PPTT On 2018/2/6 12:16, Zeng, Star wrote: > How about using EFI_ACPI_6_2_PPTT_PROCESSOR_ID_XXX to be more specific? > like this? EFI_ACPI_6_2_PPTT_PROCESSOR_ID_PHYSICAL_PACKAGE 0x01 EFI_ACPI_6_2_PPTT_PROCESSOR_ID_ACPI_PROCESSOR 0x01 > Others are good to me. > > > Thanks, > Star > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Heyi Guo > Sent: Friday, February 2, 2018 11:30 AM > To: leif.lindholm@linaro.org; linaro-uefi@lists.linaro.org; > edk2-devel@lists.01.org; graeme.gregory@linaro.org > Cc: huangming23@huawei.com; ard.biesheuvel@linaro.org; Gao, Liming > <liming.gao@intel.com>; mengfanrong@huawei.com; guoheyi@huawei.com; > Heyi Guo <heyi.guo@linaro.org>; zhangjinsong2@huawei.com; Kinney, > Michael D <michael.d.kinney@intel.com>; waip23@126.com; > wanghuiqiang@huawei.com; huangdaode@hisilicon.com > Subject: [edk2] [PATCH edk2/MdePkg v1] MdePkg ACPI: Add some macros > for PPTT > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang <huangming23@huawei.com> > Signed-off-by: Heyi Guo <heyi.guo@linaro.org> > --- > MdePkg/Include/IndustryStandard/Acpi62.h | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/MdePkg/Include/IndustryStandard/Acpi62.h > b/MdePkg/Include/IndustryStandard/Acpi62.h > index 2904d34..30faba9 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi62.h > +++ b/MdePkg/Include/IndustryStandard/Acpi62.h > @@ -2557,6 +2557,12 @@ typedef struct { } > EFI_ACPI_6_2_PPTT_STRUCTURE_HEADER; > > /// > +/// Value for valid fields in PPTT struct /// > +#define EFI_ACPI_6_2_PPTT_INVALID 0x0 > +#define EFI_ACPI_6_2_PPTT_VALID 0x1 > + > +/// > /// Processor hierarchy node structure flags /// typedef struct { > @@ -2593,6 +2599,18 @@ typedef struct { } > EFI_ACPI_6_2_PPTT_STRUCTURE_CACHE_FLAGS; > > /// > +/// For cache attributes > +/// > +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_ALLOCATION_READ 0x0 > +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_ALLOCATION_WRITE 0x1 > +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_ALLOCATION_READ_WRITE 0x2 > +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_CACHE_TYPE_DATA 0x0 > +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_CACHE_TYPE_INSTRUCTION 0x1 > +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_CACHE_TYPE_UNIFIED 0x2 > +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_WRITE_POLICY_WRITE_BACK 0x0 > +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_WRITE_POLICY_WRITE_THROUGH 0x1 > + > +/// > /// Cache Type Structure cache attributes /// typedef struct { > -- Best Regards, Ming _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
diff --git a/MdePkg/Include/IndustryStandard/Acpi62.h b/MdePkg/Include/IndustryStandard/Acpi62.h index 2904d34..30faba9 100644 --- a/MdePkg/Include/IndustryStandard/Acpi62.h +++ b/MdePkg/Include/IndustryStandard/Acpi62.h @@ -2557,6 +2557,12 @@ typedef struct { } EFI_ACPI_6_2_PPTT_STRUCTURE_HEADER; /// +/// Value for valid fields in PPTT struct +/// +#define EFI_ACPI_6_2_PPTT_INVALID 0x0 +#define EFI_ACPI_6_2_PPTT_VALID 0x1 + +/// /// Processor hierarchy node structure flags /// typedef struct { @@ -2593,6 +2599,18 @@ typedef struct { } EFI_ACPI_6_2_PPTT_STRUCTURE_CACHE_FLAGS; /// +/// For cache attributes +/// +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_ALLOCATION_READ 0x0 +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_ALLOCATION_WRITE 0x1 +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_ALLOCATION_READ_WRITE 0x2 +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_CACHE_TYPE_DATA 0x0 +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_CACHE_TYPE_INSTRUCTION 0x1 +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_CACHE_TYPE_UNIFIED 0x2 +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_WRITE_POLICY_WRITE_BACK 0x0 +#define EFI_ACPI_6_2_CACHE_ATTRIBUTES_WRITE_POLICY_WRITE_THROUGH 0x1 + +/// /// Cache Type Structure cache attributes /// typedef struct {