diff mbox series

conf: Remove unused virDomainDefNewFull

Message ID 841c8e100dd2de70abc9aedd686c7222b542db43.1529433703.git.crobinso@redhat.com
State Superseded
Headers show
Series conf: Remove unused virDomainDefNewFull | expand

Commit Message

Cole Robinson June 19, 2018, 6:42 p.m. UTC 
The last usages were removed with the xend driver in 1dac5fbbbb0

Signed-off-by: Cole Robinson <crobinso@redhat.com>

---
 src/conf/domain_conf.c   | 22 ----------------------
 src/conf/domain_conf.h   |  3 ---
 src/libvirt_private.syms |  1 -
 3 files changed, 26 deletions(-)

-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Comments

Erik Skultety June 20, 2018, 6:12 a.m. UTC | #1 
On Tue, Jun 19, 2018 at 02:42:06PM -0400, Cole Robinson wrote:
> The last usages were removed with the xend driver in 1dac5fbbbb0

>

> Signed-off-by: Cole Robinson <crobinso@redhat.com>


Reviewed-by: Erik Skultety <eskultet@redhat.com>


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
diff mbox series

Patch

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 522e0c2bf3..f0b604e125 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -3241,28 +3241,6 @@  virDomainDefNew(void)
 }
 
 
-virDomainDefPtr
-virDomainDefNewFull(const char *name,
-                    const unsigned char *uuid,
-                    int id)
-{
-    virDomainDefPtr def;
-
-    if (!(def = virDomainDefNew()))
-        return NULL;
-
-    if (VIR_STRDUP(def->name, name) < 0) {
-        VIR_FREE(def);
-        return NULL;
-    }
-
-    memcpy(def->uuid, uuid, VIR_UUID_BUFLEN);
-    def->id = id;
-
-    return def;
-}
-
-
 void virDomainObjAssignDef(virDomainObjPtr domain,
                            virDomainDefPtr def,
                            bool live,
diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index 6344c02d1c..8cefef535a 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -2919,9 +2919,6 @@  virDomainChrSourceDefNew(virDomainXMLOptionPtr xmlopt);
 virDomainChrDefPtr virDomainChrDefNew(virDomainXMLOptionPtr xmlopt);
 
 virDomainDefPtr virDomainDefNew(void);
-virDomainDefPtr virDomainDefNewFull(const char *name,
-                                    const unsigned char *uuid,
-                                    int id);
 
 void virDomainObjAssignDef(virDomainObjPtr domain,
                            virDomainDefPtr def,
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index ea24f2847c..98913a577a 100644
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -287,7 +287,6 @@  virDomainDefMaybeAddController;
 virDomainDefMaybeAddInput;
 virDomainDefNeedsPlacementAdvice;
 virDomainDefNew;
-virDomainDefNewFull;
 virDomainDefParseFile;
 virDomainDefParseNode;
 virDomainDefParseString;