diff mbox series

Print sign of NaN values to nano-vfprintf.

Message ID 20180712181353.125469-1-kumar.gala@linaro.org
State Accepted
Commit 6d7e0b337c16421a460ab0594db67bdecb377c67
Headers show
Series Print sign of NaN values to nano-vfprintf. | expand

Commit Message

Kumar Gala July 12, 2018, 6:13 p.m. UTC
Signed-off-by: Kumar Gala <kumar.gala@linaro.org>

---
 newlib/libc/stdio/nano-vfprintf_float.c | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.14.4

Comments

Corinna Vinschen July 13, 2018, 11:37 a.m. UTC | #1
On Jul 12 13:13, Kumar Gala wrote:
> Signed-off-by: Kumar Gala <kumar.gala@linaro.org>

> ---

>  newlib/libc/stdio/nano-vfprintf_float.c | 2 ++

>  1 file changed, 2 insertions(+)

> 

> diff --git a/newlib/libc/stdio/nano-vfprintf_float.c b/newlib/libc/stdio/nano-vfprintf_float.c

> index 98893e97b..071a09edc 100644

> --- a/newlib/libc/stdio/nano-vfprintf_float.c

> +++ b/newlib/libc/stdio/nano-vfprintf_float.c

> @@ -213,6 +213,8 @@ _printf_float (struct _reent *data,

>      }

>    if (isnan (_fpvalue))

>      {

> +      if (_fpvalue < 0)

> +	pdata->l_buf[0] = '-';

>        if (code <= 'G')		/* 'A', 'E', 'F', or 'G'.  */

>  	cp = "NAN";

>        else

> -- 

> 2.14.4


Any comment from the nano-printf guys?

Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat
Corinna Vinschen July 17, 2018, 12:42 p.m. UTC | #2
On Jul 12 13:13, Kumar Gala wrote:
> Signed-off-by: Kumar Gala <kumar.gala@linaro.org>

> ---

>  newlib/libc/stdio/nano-vfprintf_float.c | 2 ++

>  1 file changed, 2 insertions(+)

> 

> diff --git a/newlib/libc/stdio/nano-vfprintf_float.c b/newlib/libc/stdio/nano-vfprintf_float.c

> index 98893e97b..071a09edc 100644

> --- a/newlib/libc/stdio/nano-vfprintf_float.c

> +++ b/newlib/libc/stdio/nano-vfprintf_float.c

> @@ -213,6 +213,8 @@ _printf_float (struct _reent *data,

>      }

>    if (isnan (_fpvalue))

>      {

> +      if (_fpvalue < 0)

> +	pdata->l_buf[0] = '-';

>        if (code <= 'G')		/* 'A', 'E', 'F', or 'G'.  */

>  	cp = "NAN";

>        else

> -- 

> 2.14.4


Pushed.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat
diff mbox series

Patch

diff --git a/newlib/libc/stdio/nano-vfprintf_float.c b/newlib/libc/stdio/nano-vfprintf_float.c
index 98893e97b..071a09edc 100644
--- a/newlib/libc/stdio/nano-vfprintf_float.c
+++ b/newlib/libc/stdio/nano-vfprintf_float.c
@@ -213,6 +213,8 @@  _printf_float (struct _reent *data,
     }
   if (isnan (_fpvalue))
     {
+      if (_fpvalue < 0)
+	pdata->l_buf[0] = '-';
       if (code <= 'G')		/* 'A', 'E', 'F', or 'G'.  */
 	cp = "NAN";
       else