diff mbox series

mesa: disable LLVM on x86

Message ID 20180906150727.24915-1-ross.burton@intel.com
State Accepted
Commit 882d31bc0dbe20434d2b89aa92901374bb5e5666
Headers show
Series mesa: disable LLVM on x86 | expand

Commit Message

Ross Burton Sept. 6, 2018, 3:07 p.m. UTC
Whilst turning on the LLVM drivers is a honourable goal, the performance impact
is *huge*.  Instead let specific BSPs turn it on as required.

Signed-off-by: Ross Burton <ross.burton@intel.com>

---
 meta/recipes-graphics/mesa/mesa.inc | 3 ---
 1 file changed, 3 deletions(-)

-- 
2.11.0

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Comments

Khem Raj Sept. 6, 2018, 5:24 p.m. UTC | #1
On Thu, Sep 6, 2018 at 8:07 AM Ross Burton <ross.burton@intel.com> wrote:
>

> Whilst turning on the LLVM drivers is a honourable goal, the performance impact

> is *huge*.  Instead let specific BSPs turn it on as required.

>


Can we turn this into a variable so we can add it in a bbappend ?

> Signed-off-by: Ross Burton <ross.burton@intel.com>

> ---

>  meta/recipes-graphics/mesa/mesa.inc | 3 ---

>  1 file changed, 3 deletions(-)

>

> diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc

> index dd626d9f00c..5afd0db4b7d 100644

> --- a/meta/recipes-graphics/mesa/mesa.inc

> +++ b/meta/recipes-graphics/mesa/mesa.inc

> @@ -48,9 +48,6 @@ PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'wayland vulkan', d)} \

>                     ${@bb.utils.contains('DISTRO_FEATURES', 'x11 vulkan', 'dri3', '', d)} \

>                    "

>

> -PACKAGECONFIG_append_x86 = " gallium-llvm gallium r600"

> -PACKAGECONFIG_append_x86-64 = " gallium-llvm gallium r600"

> -

>  # "gbm" requires "dri", "opengl"

>  PACKAGECONFIG[gbm] = "--enable-gbm,--disable-gbm"

>

> --

> 2.11.0

>

> --

> _______________________________________________

> Openembedded-core mailing list

> Openembedded-core@lists.openembedded.org

> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Ross Burton Sept. 6, 2018, 6:07 p.m. UTC | #2
You can fiddle a packageconfig in a bbappend already.

On 6 September 2018 at 18:24, Khem Raj <raj.khem@gmail.com> wrote:
> On Thu, Sep 6, 2018 at 8:07 AM Ross Burton <ross.burton@intel.com> wrote:

>>

>> Whilst turning on the LLVM drivers is a honourable goal, the performance impact

>> is *huge*.  Instead let specific BSPs turn it on as required.

>>

>

> Can we turn this into a variable so we can add it in a bbappend ?

>

>> Signed-off-by: Ross Burton <ross.burton@intel.com>

>> ---

>>  meta/recipes-graphics/mesa/mesa.inc | 3 ---

>>  1 file changed, 3 deletions(-)

>>

>> diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc

>> index dd626d9f00c..5afd0db4b7d 100644

>> --- a/meta/recipes-graphics/mesa/mesa.inc

>> +++ b/meta/recipes-graphics/mesa/mesa.inc

>> @@ -48,9 +48,6 @@ PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'wayland vulkan', d)} \

>>                     ${@bb.utils.contains('DISTRO_FEATURES', 'x11 vulkan', 'dri3', '', d)} \

>>                    "

>>

>> -PACKAGECONFIG_append_x86 = " gallium-llvm gallium r600"

>> -PACKAGECONFIG_append_x86-64 = " gallium-llvm gallium r600"

>> -

>>  # "gbm" requires "dri", "opengl"

>>  PACKAGECONFIG[gbm] = "--enable-gbm,--disable-gbm"

>>

>> --

>> 2.11.0

>>

>> --

>> _______________________________________________

>> Openembedded-core mailing list

>> Openembedded-core@lists.openembedded.org

>> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
diff mbox series

Patch

diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc
index dd626d9f00c..5afd0db4b7d 100644
--- a/meta/recipes-graphics/mesa/mesa.inc
+++ b/meta/recipes-graphics/mesa/mesa.inc
@@ -48,9 +48,6 @@  PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'wayland vulkan', d)} \
                    ${@bb.utils.contains('DISTRO_FEATURES', 'x11 vulkan', 'dri3', '', d)} \
 		   "
 
-PACKAGECONFIG_append_x86 = " gallium-llvm gallium r600"
-PACKAGECONFIG_append_x86-64 = " gallium-llvm gallium r600"
-
 # "gbm" requires "dri", "opengl"
 PACKAGECONFIG[gbm] = "--enable-gbm,--disable-gbm"