| Message ID | 20180913202828.15372-1-robh@kernel.org |
|---|---|
| State | Accepted |
| Commit | 53dd9dce6979bc54d64a3a09a2fb20187a025be7 |
| Headers | show |
| Series | [1/3] libfdt: Ensure INT_MAX is defined in libfdt_env.h | expand |
On 09/13/18 13:28, Rob Herring wrote: > Major changes are I2C and SPI bus checks, YAML output format (for > future validation), some new libfdt functions, and more libfdt > validation of dtbs. > > The YAML addition adds an optional dependency on libyaml. pkg-config is > used to test for it and pkg-config became a kconfig dependency in 4.18. For Ubuntu, the libyaml dependency is provided by the packages: libyaml-0-2 libyaml-dev -Frank > > This adds the following commits from upstream: > > c86da84d30e4 Add support for YAML encoded output > 361b5e7d8067 Make type_marker_length helper public < snip >
On Fri, Sep 14, 2018 at 2:32 PM Frank Rowand <frowand.list@gmail.com> wrote: > > On 09/13/18 13:28, Rob Herring wrote: > > Major changes are I2C and SPI bus checks, YAML output format (for > > future validation), some new libfdt functions, and more libfdt > > validation of dtbs. > > > > The YAML addition adds an optional dependency on libyaml. pkg-config is > > used to test for it and pkg-config became a kconfig dependency in 4.18. > > For Ubuntu, the libyaml dependency is provided by the packages: > > libyaml-0-2 > libyaml-dev Yes, but as it is not yet required by anything in the kernel I don't think that needs to be documented yet. Also, offhand, I don't think we generally document in the kernel distro specifics like package names. Rob
On 09/18/18 11:55, Rob Herring wrote: > On Fri, Sep 14, 2018 at 2:32 PM Frank Rowand <frowand.list@gmail.com> wrote: >> >> On 09/13/18 13:28, Rob Herring wrote: >>> Major changes are I2C and SPI bus checks, YAML output format (for >>> future validation), some new libfdt functions, and more libfdt >>> validation of dtbs. >>> >>> The YAML addition adds an optional dependency on libyaml. pkg-config is >>> used to test for it and pkg-config became a kconfig dependency in 4.18. >> >> For Ubuntu, the libyaml dependency is provided by the packages: >> >> libyaml-0-2 >> libyaml-dev > > Yes, but as it is not yet required by anything in the kernel I don't > think that needs to be documented yet. Also, offhand, I don't think we > generally document in the kernel distro specifics like package names. > > Rob > Agreed. I was providing information that might save other people a bit of research. It is sufficiently visible in the email thread and does not need to be in the commit message.
diff --git a/arch/arm/boot/compressed/libfdt_env.h b/arch/arm/boot/compressed/libfdt_env.h index 07437816e098..b36c0289a308 100644 --- a/arch/arm/boot/compressed/libfdt_env.h +++ b/arch/arm/boot/compressed/libfdt_env.h @@ -6,6 +6,8 @@ #include <linux/string.h> #include <asm/byteorder.h> +#define INT_MAX ((int)(~0U>>1)) + typedef __be16 fdt16_t; typedef __be32 fdt32_t; typedef __be64 fdt64_t; diff --git a/arch/powerpc/boot/libfdt_env.h b/arch/powerpc/boot/libfdt_env.h index 2a0c8b1bf147..2abc8e83b95e 100644 --- a/arch/powerpc/boot/libfdt_env.h +++ b/arch/powerpc/boot/libfdt_env.h @@ -5,6 +5,8 @@ #include <types.h> #include <string.h> +#define INT_MAX ((int)(~0U>>1)) + #include "of.h" typedef unsigned long uintptr_t; diff --git a/include/linux/libfdt_env.h b/include/linux/libfdt_env.h index c6ac1fe7ec68..edb0f0c30904 100644 --- a/include/linux/libfdt_env.h +++ b/include/linux/libfdt_env.h @@ -2,6 +2,7 @@ #ifndef LIBFDT_ENV_H #define LIBFDT_ENV_H +#include <linux/kernel.h> /* For INT_MAX */ #include <linux/string.h> #include <asm/byteorder.h>
The next update of libfdt has a new dependency on INT_MAX. Update the instances of libfdt_env.h in the kernel to either include the necessary header with the definition or define it locally. Cc: Russell King <linux@armlinux.org.uk> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: linux-arm-kernel@lists.infradead.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Rob Herring <robh@kernel.org> --- arch/arm/boot/compressed/libfdt_env.h | 2 ++ arch/powerpc/boot/libfdt_env.h | 2 ++ include/linux/libfdt_env.h | 1 + 3 files changed, 5 insertions(+) -- 2.17.1