Message ID | 20181017015456.3293-2-richard.henderson@linaro.org |
---|---|
State | Superseded |
Headers | show
Delivered-To: patch@linaro.org Received: by 2002:a2e:8595:0:0:0:0:0 with SMTP id b21-v6csp68884lji; Tue, 16 Oct 2018 18:55:22 -0700 (PDT) X-Google-Smtp-Source: ACcGV6386YtQkT03eOa5Z5F7p3oYYyIi44xG8UfISVZmbL14IMhMUxHQacXQ7v4pi0fF3f3a/Jnn X-Received: by 2002:a0c:ae76:: with SMTP id z51-v6mr24253018qvc.108.1539741322053; Tue, 16 Oct 2018 18:55:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539741322; cv=none; d=google.com; s=arc-20160816; b=UBE+bcxJh7ovzD1JYu0udn6nGobkPf1qTtd88/JHOcohmzJKqC/ZzOZQyVPN6r7zAr v+yS36PnPuRLF8KfwuNKSVePlzbamaG3ucUg/21QSeY1BjItrg1pOo/Qj0MPmSxx7OZw 44z8PtOKia0wJMpo8B4XZI+TYgilmgxQErL4cNgvUNB4lmRXSaEsUChkX9GMLXeNDcX2 jTNspNlgx77OB1kn2ZjrvkWokU/eI6LOFse+lzq2sK6lvfQ6c1DSKjBdIBzhLnGVaq4e qrnBIEO18YEPItRXIj5Wzv9nJBn4nj1qc+CbHQJPlozBj5yeSqAqsPFN/WXm5S2RIIIc 6jNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=7LDAkXYqm0E1INzhyCfPvhMzExqgurjucKqSbAhcSOg=; b=tK//rZPlbR9g0pJWDEFmjD8Wd8F2nzkN944n19jSINdGis9l2RmcFBZpnQRLCFesih +oTpyOnbFkP6pyPbUwEpycisxm2UD2XUse0r86jIYgyzBdXqduyDAaA4uIgVubATioOa imyReT5IHS4yhIkFvBBVO5Lwfde6uYxuqGGE6LTVxmM6D0pQ1PnTOcKW3lxtTeAw9fLB GMydnKg+gAOikVCLKSlKfyLfn0DHZUTBYTW+yYEXmJfuWKV5bCrpproTie2wyeE93voq A/5Cl48SNTht4GoA0bdqhlOoOkGuGa84v5kpvtuMTVubF1/XP8KUsjHu8rdnG4xg7POz 1pHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=OUVYb2xJ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: <qemu-devel-bounces+patch=linaro.org@nongnu.org> Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id j3-v6si9848647qkf.0.2018.10.16.18.55.21 for <patch@linaro.org> (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 16 Oct 2018 18:55:22 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=OUVYb2xJ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:33376 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <qemu-devel-bounces+patch=linaro.org@nongnu.org>) id 1gCb3R-0002WN-Iz for patch@linaro.org; Tue, 16 Oct 2018 21:55:21 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47713) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <richard.henderson@linaro.org>) id 1gCb3B-0002W6-3p for qemu-devel@nongnu.org; Tue, 16 Oct 2018 21:55:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <richard.henderson@linaro.org>) id 1gCb37-0006z3-JL for qemu-devel@nongnu.org; Tue, 16 Oct 2018 21:55:04 -0400 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]:44224) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from <richard.henderson@linaro.org>) id 1gCb37-0006yW-DQ for qemu-devel@nongnu.org; Tue, 16 Oct 2018 21:55:01 -0400 Received: by mail-pg1-x541.google.com with SMTP id g2-v6so11710050pgu.11 for <qemu-devel@nongnu.org>; Tue, 16 Oct 2018 18:55:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=7LDAkXYqm0E1INzhyCfPvhMzExqgurjucKqSbAhcSOg=; b=OUVYb2xJEQxeUL7/0wbuFc5C0dAMjJg2SPvJgMBGzV3f98HZUiAeNBE6SD59Kdap04 MOreS8guKKeY18NMFc5qPj7tr19NtyW23fIV4uNQkvJ+GEvk4OLigSyYcJacsMx6eN+H 55T+YsBza/MsYZlu8aBROmH1rv7zl8rhDUYyY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=7LDAkXYqm0E1INzhyCfPvhMzExqgurjucKqSbAhcSOg=; b=G1rRhroGEcP1QDrtvyZPnDQMVqAXLLor2TY2GsC8iAVX/ytsXEeVqBPJJu1+qrJvlU Q+Go1cAR3m9H5P1DhjXuWlbGnnlMatKC6FNRzkjRp698+i4dz0fQTUycC50MwiFUdVmX RVqQSkgNBFBVClAaHcGvCesNpcSz8cHYNp4ZivQ8aikUF2Frx2jRchxbKL5EY0WU4pNJ 6XLEPkRZJ6CGC2YGts2ztFr4tIjXsQxU8YU7qgB0Cr7uAR/vyluLXRGFQFhxZoobQYbR ep5wUPUQIqfEnrTdjsYQ4pqwOJ5v9k/3LL9BrSrVi2GXdeLu1FEpSZFKLwOJH6YS1a5J 2u/g== X-Gm-Message-State: ABuFfoi2mjudvih7or+nGBp9H4zbFF2LP/UzljAhYCPclAD/mxCio+iJ IfqZ32rLj3gT/6y2JgBioDgSzb5bqKk= X-Received: by 2002:a65:4301:: with SMTP id j1-v6mr6445832pgq.279.1539741300064; Tue, 16 Oct 2018 18:55:00 -0700 (PDT) Received: from cloudburst.twiddle.net (174-21-9-133.tukw.qwest.net. [174.21.9.133]) by smtp.gmail.com with ESMTPSA id o133-v6sm24988124pfg.86.2018.10.16.18.54.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Oct 2018 18:54:59 -0700 (PDT) From: Richard Henderson <richard.henderson@linaro.org> To: qemu-devel@nongnu.org Date: Tue, 16 Oct 2018 18:54:54 -0700 Message-Id: <20181017015456.3293-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181017015456.3293-1-richard.henderson@linaro.org> References: <20181017015456.3293-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::541 Subject: [Qemu-devel] [PATCH 1/3] tests/tcg/multiarch/linux-test: Fix error check for shmat X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <qemu-devel.nongnu.org> List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe> List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/> List-Post: <mailto:qemu-devel@nongnu.org> List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help> List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=subscribe> Cc: laurent@vivier.eu Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+patch=linaro.org@nongnu.org> |
Series |
linux-user: Fix shmat by honoring SHMLBA
|
expand
|
diff --git a/tests/tcg/multiarch/linux-test.c b/tests/tcg/multiarch/linux-test.c index e80eccc0ce..6d2c02c5c0 100644 --- a/tests/tcg/multiarch/linux-test.c +++ b/tests/tcg/multiarch/linux-test.c @@ -503,8 +503,9 @@ static void test_shm(void) shmid = chk_error(shmget(IPC_PRIVATE, SHM_SIZE, IPC_CREAT | 0777)); ptr = shmat(shmid, NULL, 0); - if (!ptr) + if (ptr == (void *)-1) { error("shmat"); + } memset(ptr, 0, SHM_SIZE);
The error indicator for this syscall is -1, not 0. Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- tests/tcg/multiarch/linux-test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.17.2