| Message ID | 20181210204448.2338398-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | 2aa55dccf83d7ca9f1da59ae005426c44fbeb890 |
| Headers | show |
| Series | hns3: prevent building without CONFIG_INET | expand |
From: Arnd Bergmann <arnd@arndb.de> Date: Mon, 10 Dec 2018 21:44:34 +0100 > We now get a link failure when CONFIG_INET is disabled, since > tcp_gro_complete is unavailable: > > drivers/net/ethernet/hisilicon/hns3/hns3_enet.o: In function `hns3_set_gro_param': > hns3_enet.c:(.text+0x230c): undefined reference to `tcp_gro_complete' > > Add an explicit CONFIG_INET dependency here to avoid the broken > configuration. > > Fixes: a6d53b97a2e7 ("net: hns3: Adds GRO params to SKB for the stack") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Applied.
diff --git a/drivers/net/ethernet/hisilicon/Kconfig b/drivers/net/ethernet/hisilicon/Kconfig index 25152715396b..fee4664c9189 100644 --- a/drivers/net/ethernet/hisilicon/Kconfig +++ b/drivers/net/ethernet/hisilicon/Kconfig @@ -118,6 +118,7 @@ config HNS3_ENET tristate "Hisilicon HNS3 Ethernet Device Support" default m depends on 64BIT && PCI + depends on INET ---help--- This selects the Ethernet Driver for Hisilicon Network Subsystem 3 for hip08 family of SoCs. This module depends upon HNAE3 driver to access the HNAE3
We now get a link failure when CONFIG_INET is disabled, since tcp_gro_complete is unavailable: drivers/net/ethernet/hisilicon/hns3/hns3_enet.o: In function `hns3_set_gro_param': hns3_enet.c:(.text+0x230c): undefined reference to `tcp_gro_complete' Add an explicit CONFIG_INET dependency here to avoid the broken configuration. Fixes: a6d53b97a2e7 ("net: hns3: Adds GRO params to SKB for the stack") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/net/ethernet/hisilicon/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.20.0