[PULL,05/32] tcg/arm: Remove reloc_pc24_atomic

Message ID	20181214031923.29527-7-richard.henderson@linaro.org
State	Accepted
Commit	2672ccc7eee742e23928f4bf60a13a77d64f540d
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; From: Richard Henderson <richard.henderson@linaro.org> To: qemu-devel@nongnu.org Date: Thu, 13 Dec 2018 21:18:56 -0600 Message-Id: <20181214031923.29527-7-richard.henderson@linaro.org> In-Reply-To: <20181214031923.29527-1-richard.henderson@linaro.org> References: <20181214031923.29527-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PULL 05/32] tcg/arm: Remove reloc_pc24_atomic Precedence: list Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+patch=linaro.org@nongnu.org>
Series	tcg patch queue \| expand [PULL,00/32] tcg patch queue [PULL,01/32] tcg/i386: Always use %ebp for TCG_AREG0 [PULL,02/32] tcg/i386: Move TCG_REG_CALL_STACK from define to enum [PULL,03/32] tcg/aarch64: Remove reloc_pc26_atomic [PULL,04/32] tcg/aarch64: Fold away "noaddr" branch routines [PULL,05/32] tcg/arm: Remove reloc_pc24_atomic [PULL,06/32] tcg/arm: Fold away "noaddr" branch routines [PULL,07/32] tcg/ppc: Fold away "noaddr" branch routines [PULL,08/32] tcg/s390: Remove retranslation code [PULL,09/32] tcg/sparc: Remove retranslation code [PULL,10/32] tcg/mips: Remove retranslation code [PULL,11/32] tcg: Return success from patch_reloc [PULL,12/32] tcg/i386: Return false on failure from patch_reloc [PULL,13/32] tcg/aarch64: Return false on failure from patch_reloc [PULL,14/32] tcg/arm: Return false on failure from patch_reloc [PULL,15/32] tcg/ppc: Return false on failure from patch_reloc [PULL,16/32] tcg/s390x: Return false on failure from patch_reloc [PULL,17/32] tcg/i386: Propagate is64 to tcg_out_qemu_ld_direct [PULL,18/32] tcg/i386: Propagate is64 to tcg_out_qemu_ld_slow_path [PULL,19/32] tcg/i386: Implement INDEX_op_extr{lh}_i64_i32 for 32-bit guests [PULL,20/32] tcg/i386: Assume 32-bit values are zero-extended [PULL,21/32] tcg/i386: Precompute all guest_base parameters [PULL,22/32] tcg/i386: Add setup_guest_base_seg for FreeBSD [PULL,23/32] tcg: Clean up generic bswap32 [PULL,24/32] tcg: Clean up generic bswap64 [PULL,25/32] tcg/optimize: Optimize bswap [PULL,26/32] tcg: Add TCG_TARGET_HAS_MEMORY_BSWAP [PULL,27/32] tcg/mips: Improve the add2/sub2 command to use TCG_TARGET_REG_BITS [PULL,28/32] tcg: Drop nargs from tcg_op_insert_{before, after} [PULL,29/32] qht-bench: document -p flag [PULL,30/32] exec: introduce qemu_xxhash{2,4,5,6,7} [PULL,31/32] include: move exec/tb-hash-xx.h to qemu/xxhash.h [PULL,32/32] xxhash: match output against the original xxhash32

Message ID

20181214031923.29527-7-richard.henderson@linaro.org

State

Accepted

Commit

2672ccc7eee742e23928f4bf60a13a77d64f540d

Headers

Received-SPF: pass (google.com: domain of
	qemu-devel-bounces+patch=linaro.org@nongnu.org designates
	2001:4830:134:3::11 as permitted sender)
	client-ip=2001:4830:134:3::11; 
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Date: Thu, 13 Dec 2018 21:18:56 -0600
Message-Id: <20181214031923.29527-7-richard.henderson@linaro.org>
In-Reply-To: <20181214031923.29527-1-richard.henderson@linaro.org>
References: <20181214031923.29527-1-richard.henderson@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: [Qemu-devel] [PULL 05/32] tcg/arm: Remove reloc_pc24_atomic
Precedence: list
Cc: peter.maydell@linaro.org
Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org
Sender: "Qemu-devel" <qemu-devel-bounces+patch=linaro.org@nongnu.org>

Series

tcg patch queue | expand

Commit Message

Richard Henderson Dec. 14, 2018, 3:18 a.m. UTC

It is unused since 3fb53fb4d12f2e7833bd1659e6013237b130ef20.

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

---
 tcg/arm/tcg-target.inc.c | 8 --------
 1 file changed, 8 deletions(-)

-- 
2.17.2

diff --git a/tcg/arm/tcg-target.inc.c b/tcg/arm/tcg-target.inc.c
index e1fbf465cb..1142eb13ad 100644
--- a/tcg/arm/tcg-target.inc.c
+++ b/tcg/arm/tcg-target.inc.c
@@ -193,14 +193,6 @@  static inline void reloc_pc24(tcg_insn_unit *code_ptr, tcg_insn_unit *target)
     *code_ptr = (*code_ptr & ~0xffffff) | (offset & 0xffffff);
 }
 
-static inline void reloc_pc24_atomic(tcg_insn_unit *code_ptr, tcg_insn_unit *target)
-{
-    ptrdiff_t offset = (tcg_ptr_byte_diff(target, code_ptr) - 8) >> 2;
-    tcg_insn_unit insn = atomic_read(code_ptr);
-    tcg_debug_assert(offset == sextract32(offset, 0, 24));
-    atomic_set(code_ptr, deposit32(insn, 0, 24, offset));
-}
-
 static void patch_reloc(tcg_insn_unit *code_ptr, int type,
                         intptr_t value, intptr_t addend)
 {

[PULL,05/32] tcg/arm: Remove reloc_pc24_atomic

Commit Message

Patch