diff mbox series

docs: storage: owner/group default to libvirtd UID/GID

Message ID a3996c6078c3a233c676f1cebeee2010d9c17802.1549496206.git.crobinso@redhat.com
State Accepted
Commit e00771dfc30fde01ca14e1c6f1bafd831162a031
Headers show
Series docs: storage: owner/group default to libvirtd UID/GID | expand

Commit Message

Cole Robinson Feb. 6, 2019, 11:36 p.m. UTC 
Commit fafcc818f changed the docs to say that when creating a
pool directory or file volume with no owner/group specified, they
will be inherited from the parent directory. This isn't correct
now and doesn't seem to have ever been correct

In reality default owner/group is whatever UID/GID libvirtd is
running as

Signed-off-by: Cole Robinson <crobinso@redhat.com>

---
 docs/formatstorage.html.in | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Comments

Michal Prívozník Feb. 8, 2019, 1:28 p.m. UTC | #1 
On 2/7/19 12:36 AM, Cole Robinson wrote:
> Commit fafcc818f changed the docs to say that when creating a

> pool directory or file volume with no owner/group specified, they

> will be inherited from the parent directory. This isn't correct

> now and doesn't seem to have ever been correct

> 

> In reality default owner/group is whatever UID/GID libvirtd is

> running as

> 

> Signed-off-by: Cole Robinson <crobinso@redhat.com>

> ---

>   docs/formatstorage.html.in | 8 ++++----

>   1 file changed, 4 insertions(+), 4 deletions(-)


ACK

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
diff mbox series

Patch

diff --git a/docs/formatstorage.html.in b/docs/formatstorage.html.in
index 6ebd23549f..968651330f 100644
--- a/docs/formatstorage.html.in
+++ b/docs/formatstorage.html.in
@@ -478,8 +478,8 @@ 
         The <code>owner</code> element contains the numeric user ID.
         The <code>group</code> element contains the numeric group ID.
         If <code>owner</code> or <code>group</code> aren't specified when
-        creating a directory, the values are inherited from the parent
-        directory. The <code>label</code> element contains the MAC (eg SELinux)
+        creating a directory, the UID and GID of the libvirtd process are used.
+        The <code>label</code> element contains the MAC (eg SELinux)
         label string.
         <span class="since">Since 0.4.1</span>
         For running directory or filesystem based pools, these fields
@@ -776,8 +776,8 @@ 
         The <code>owner</code> element contains the numeric user ID.
         The <code>group</code> element contains the numeric group ID.
         If <code>owner</code> or <code>group</code> aren't specified when
-        creating a supported volume, the values are inherited from the parent
-        directory. The <code>label</code> element contains the MAC (eg SELinux)
+        creating a supported volume, the UID and GID of the libvirtd process
+        are used. The <code>label</code> element contains the MAC (eg SELinux)
         label string.
         For existing directory or filesystem based volumes, these fields
         will be filled with the values used by the existing file.