| Message ID | 20190220153412.18090-3-daniel.diaz@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] Add header file lapi/signal.h | expand |
Hi Daniel, > MUSL does not include __SIGRTMIN nor __SIGRTMAX. The > compatibility header can help here. lib/tst_sig.c and testcases/kernel/syscalls/rt_sigsuspend/rt_sigsuspend01.c also use __SIGRTMIN. Don't you have a problem to build it? + I'd squash adding of these includes into single commit. Kind regards, Petr
Hello! On Wed, 20 Feb 2019 at 10:33, Petr Vorel <pvorel@suse.cz> wrote: > Hi Daniel, > > > MUSL does not include __SIGRTMIN nor __SIGRTMAX. The > > compatibility header can help here. > lib/tst_sig.c and testcases/kernel/syscalls/rt_sigsuspend/rt_sigsuspend01.c also > use __SIGRTMIN. Don't you have a problem to build it? Using latest LTP and latest OE-Core (MACHINE = "qemuarm64"; TCLIB = "musl"), no, it built fine. Same for 20190115 -- it built fine. (I'm about to submit the upgrade to that version to OE-core.) Would you like me to add the #include in those two as well? > + I'd squash adding of these includes into single commit. Great! I did that for OE, so let me send that patch instead. Thanks and greetings! Daniel Díaz daniel.diaz@linaro.org
diff --git a/testcases/kernel/syscalls/ptrace/ptrace05.c b/testcases/kernel/syscalls/ptrace/ptrace05.c index 420330029..54cfa4d7b 100644 --- a/testcases/kernel/syscalls/ptrace/ptrace05.c +++ b/testcases/kernel/syscalls/ptrace/ptrace05.c @@ -38,6 +38,7 @@ #include "ptrace.h" #include "test.h" +#include "lapi/signal.h" char *TCID = "ptrace05"; int TST_TOTAL = 0;
MUSL does not include __SIGRTMIN nor __SIGRTMAX. The compatibility header can help here. Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org> --- testcases/kernel/syscalls/ptrace/ptrace05.c | 1 + 1 file changed, 1 insertion(+)