| Message ID | 20190610014249.7346-1-richard.henderson@linaro.org |
|---|---|
| State | Accepted |
| Commit | 62a31161ee60d6c3c62d36b2bcadcd9de8db51f5 |
| Headers | show |
| Series | tests/tcg/s390x: Fix alignment of csst parameter list | expand |
On 10.06.19 03:42, Richard Henderson wrote: > The parameter list given in general register 1 shall be aligned > on a quadword boundary. This test currently succeeds or fails > depending on the compiler version used and the accidential layout > of the function's stack frame. > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > tests/tcg/s390x/csst.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/tcg/s390x/csst.c b/tests/tcg/s390x/csst.c > index 1dae9071fb..084d80af49 100644 > --- a/tests/tcg/s390x/csst.c > +++ b/tests/tcg/s390x/csst.c > @@ -3,7 +3,7 @@ > > int main(void) > { > - uint64_t parmlist[] = { > + uint64_t parmlist[] __attribute__((aligned(16))) = { > 0xfedcba9876543210ull, > 0, > 0x7777777777777777ull, > Reviewed-by: David Hildenbrand <david@redhat.com> Queuing it to https://github.com/davidhildenbrand/qemu.git s390-tcg-next for now. Let me know if you want to send this via a different PULL request yourself. -- Thanks, David / dhildenb
On 6/11/19 6:06 AM, David Hildenbrand wrote: > Queuing it to > > https://github.com/davidhildenbrand/qemu.git s390-tcg-next > > for now. Let me know if you want to send this via a different PULL > request yourself. No, that's perfect, thanks. r~
diff --git a/tests/tcg/s390x/csst.c b/tests/tcg/s390x/csst.c index 1dae9071fb..084d80af49 100644 --- a/tests/tcg/s390x/csst.c +++ b/tests/tcg/s390x/csst.c @@ -3,7 +3,7 @@ int main(void) { - uint64_t parmlist[] = { + uint64_t parmlist[] __attribute__((aligned(16))) = { 0xfedcba9876543210ull, 0, 0x7777777777777777ull,
The parameter list given in general register 1 shall be aligned on a quadword boundary. This test currently succeeds or fails depending on the compiler version used and the accidential layout of the function's stack frame. Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- tests/tcg/s390x/csst.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1