| Message ID | 20190705160421.19015-5-alex.bennee@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | tcg tests and gdbstub fixes | expand |
On 7/5/19 6:04 PM, Alex Bennée wrote: > Add a link to the remote protocol spec and an SPDX tag. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > gdbstub.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/gdbstub.c b/gdbstub.c > index 8618e34311..ea3349d1aa 100644 > --- a/gdbstub.c > +++ b/gdbstub.c > @@ -1,6 +1,10 @@ > /* > * gdb server stub > * > + * This implements a subset of the remote protocol as described in: > + * > + * https://sourceware.org/gdb/onlinedocs/gdb/Remote-Protocol.html > + * > * Copyright (c) 2003-2005 Fabrice Bellard > * > * This library is free software; you can redistribute it and/or > @@ -15,6 +19,8 @@ > * > * You should have received a copy of the GNU Lesser General Public > * License along with this library; if not, see <http://www.gnu.org/licenses/>. > + * > + * SPDX-License-Identifier: GPL-2.0-or-later > */ > > #include "qemu/osdep.h" > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
On 7/5/19 6:04 PM, Alex Bennée wrote: > Add a link to the remote protocol spec and an SPDX tag. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > gdbstub.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/gdbstub.c b/gdbstub.c > index 8618e34311..ea3349d1aa 100644 > --- a/gdbstub.c > +++ b/gdbstub.c > @@ -1,6 +1,10 @@ > /* > * gdb server stub > * > + * This implements a subset of the remote protocol as described in: > + * > + * https://sourceware.org/gdb/onlinedocs/gdb/Remote-Protocol.html > + * Ack. > * Copyright (c) 2003-2005 Fabrice Bellard > * > * This library is free software; you can redistribute it and/or > @@ -15,6 +19,8 @@ > * > * You should have received a copy of the GNU Lesser General Public > * License along with this library; if not, see <http://www.gnu.org/licenses/>. > + * > + * SPDX-License-Identifier: GPL-2.0-or-later Nack. The text is for the LGPL. r~
Richard Henderson <richard.henderson@linaro.org> writes: > On 7/5/19 6:04 PM, Alex Bennée wrote: >> Add a link to the remote protocol spec and an SPDX tag. >> >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> >> --- >> gdbstub.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/gdbstub.c b/gdbstub.c >> index 8618e34311..ea3349d1aa 100644 >> --- a/gdbstub.c >> +++ b/gdbstub.c >> @@ -1,6 +1,10 @@ >> /* >> * gdb server stub >> * >> + * This implements a subset of the remote protocol as described in: >> + * >> + * https://sourceware.org/gdb/onlinedocs/gdb/Remote-Protocol.html >> + * > > Ack. > >> * Copyright (c) 2003-2005 Fabrice Bellard >> * >> * This library is free software; you can redistribute it and/or >> @@ -15,6 +19,8 @@ >> * >> * You should have received a copy of the GNU Lesser General Public >> * License along with this library; if not, see <http://www.gnu.org/licenses/>. >> + * >> + * SPDX-License-Identifier: GPL-2.0-or-later > > Nack. The text is for the LGPL. Fixed in my PR. -- Alex Bennée
diff --git a/gdbstub.c b/gdbstub.c index 8618e34311..ea3349d1aa 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1,6 +1,10 @@ /* * gdb server stub * + * This implements a subset of the remote protocol as described in: + * + * https://sourceware.org/gdb/onlinedocs/gdb/Remote-Protocol.html + * * Copyright (c) 2003-2005 Fabrice Bellard * * This library is free software; you can redistribute it and/or @@ -15,6 +19,8 @@ * * You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. + * + * SPDX-License-Identifier: GPL-2.0-or-later */ #include "qemu/osdep.h"
Add a link to the remote protocol spec and an SPDX tag. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- gdbstub.c | 6 ++++++ 1 file changed, 6 insertions(+) -- 2.20.1