diff mbox series

test/event_crypto: no service core for HW options

Message ID 20190906104434.15467-1-hemant.agrawal@nxp.com
State Accepted
Commit aa026482baf9ce6642c6bcaa1d6d8bd702ca707e
Headers show
Series test/event_crypto: no service core for HW options | expand

Commit Message

Hemant Agrawal Sept. 6, 2019, 10:44 a.m. UTC 
If HW support is available, service core shall not come
into play by default. This shall be for both FWD/NEW modes.

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

---
 app/test/test_event_crypto_adapter.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

-- 
2.17.1

Comments

Gujjar, Abhinandan S Sept. 17, 2019, 3:27 a.m. UTC | #1 
Acked-by: abhinandan.gujjar@intel.com



> -----Original Message-----

> From: Hemant Agrawal <hemant.agrawal@nxp.com>

> Sent: Friday, September 6, 2019 4:15 PM

> To: dev@dpdk.org

> Cc: jerinj@marvell.com; Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>;

> Hemant Agrawal <hemant.agrawal@nxp.com>

> Subject: [PATCH] test/event_crypto: no service core for HW options

> 

> If HW support is available, service core shall not come into play by default. This

> shall be for both FWD/NEW modes.

> 

> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

> ---

>  app/test/test_event_crypto_adapter.c | 10 ++++++----

>  1 file changed, 6 insertions(+), 4 deletions(-)

> 

> diff --git a/app/test/test_event_crypto_adapter.c

> b/app/test/test_event_crypto_adapter.c

> index e7bf80978..ed8a58d32 100644

> --- a/app/test/test_event_crypto_adapter.c

> +++ b/app/test/test_event_crypto_adapter.c

> @@ -293,7 +293,8 @@ test_sessionless_with_op_forward_mode(void)

>  	ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev,

> &cap);

>  	TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");

> 

> -	if (!(cap &

> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD))

> +	if (!(cap &

> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) &&

> +	    !(cap &

> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW))

>  		map_adapter_service_core();

> 

> 

> 	TEST_ASSERT_SUCCESS(rte_event_crypto_adapter_start(TEST_ADAPTE

> R_ID),

> @@ -313,7 +314,8 @@ test_session_with_op_forward_mode(void)

>  	ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev,

> &cap);

>  	TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");

> 

> -	if (!(cap &

> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD))

> +	if (!(cap &

> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) &&

> +	    !(cap &

> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW))

>  		map_adapter_service_core();

> 

> 

> 	TEST_ASSERT_SUCCESS(rte_event_crypto_adapter_start(TEST_ADAPTE

> R_ID

> @@ -441,7 +443,7 @@ test_sessionless_with_op_new_mode(void)

>  	ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev,

> &cap);

>  	TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");

> 

> -	if (!(cap &

> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) ||

> +	if (!(cap &

> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) &&

>  	    !(cap &

> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW))

>  		map_adapter_service_core();

> 

> @@ -463,7 +465,7 @@ test_session_with_op_new_mode(void)

>  	ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev,

> &cap);

>  	TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");

> 

> -	if (!(cap &

> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) ||

> +	if (!(cap &

> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) &&

>  	    !(cap &

> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW))

>  		map_adapter_service_core();

> 

> --

> 2.17.1
Jerin Jacob Sept. 23, 2019, 7:17 a.m. UTC | #2 
On Tue, Sep 17, 2019 at 9:01 AM Gujjar, Abhinandan S
<abhinandan.gujjar@intel.com> wrote:
>

> Acked-by: abhinandan.gujjar@intel.com


Changed to Acked-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
and Applied to dpdk-next-eventdev/master. Thanks.


>

>

> > -----Original Message-----

> > From: Hemant Agrawal <hemant.agrawal@nxp.com>

> > Sent: Friday, September 6, 2019 4:15 PM

> > To: dev@dpdk.org

> > Cc: jerinj@marvell.com; Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>;

> > Hemant Agrawal <hemant.agrawal@nxp.com>

> > Subject: [PATCH] test/event_crypto: no service core for HW options

> >

> > If HW support is available, service core shall not come into play by default. This

> > shall be for both FWD/NEW modes.

> >

> > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

> > ---

> >  app/test/test_event_crypto_adapter.c | 10 ++++++----

> >  1 file changed, 6 insertions(+), 4 deletions(-)
diff mbox series

Patch

diff --git a/app/test/test_event_crypto_adapter.c b/app/test/test_event_crypto_adapter.c
index e7bf80978..ed8a58d32 100644
--- a/app/test/test_event_crypto_adapter.c
+++ b/app/test/test_event_crypto_adapter.c
@@ -293,7 +293,8 @@  test_sessionless_with_op_forward_mode(void)
 	ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev, &cap);
 	TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
 
-	if (!(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD))
+	if (!(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) &&
+	    !(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW))
 		map_adapter_service_core();
 
 	TEST_ASSERT_SUCCESS(rte_event_crypto_adapter_start(TEST_ADAPTER_ID),
@@ -313,7 +314,8 @@  test_session_with_op_forward_mode(void)
 	ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev, &cap);
 	TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
 
-	if (!(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD))
+	if (!(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) &&
+	    !(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW))
 		map_adapter_service_core();
 
 	TEST_ASSERT_SUCCESS(rte_event_crypto_adapter_start(TEST_ADAPTER_ID
@@ -441,7 +443,7 @@  test_sessionless_with_op_new_mode(void)
 	ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev, &cap);
 	TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
 
-	if (!(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) ||
+	if (!(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) &&
 	    !(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW))
 		map_adapter_service_core();
 
@@ -463,7 +465,7 @@  test_session_with_op_new_mode(void)
 	ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev, &cap);
 	TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
 
-	if (!(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) ||
+	if (!(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) &&
 	    !(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW))
 		map_adapter_service_core();