| Message ID | 20190909152107.4968-1-sudeep.holla@arm.com |
|---|---|
| State | Accepted |
| Commit | 61423712dbb86e02af4aa5de65b9041493c92cac |
| Headers | show |
| Series | [-next] reset: reset-scmi: add missing handle initialisation | expand |
Hi Sudeep, On Mon, 2019-09-09 at 16:21 +0100, Sudeep Holla wrote: > scmi_reset_data->handle needs to be initialised at probe, so that it > can be used to access scmi reset protocol apis using the same later. > > Since it was tested with a module that obtained handle elsewhere, > it was missed easily. Add the missing scmi_reset_data->handle > initialisation to fix the issue. > > Fixes: c8ae9c2da1cc ("reset: Add support for resets provided by SCMI") > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Reported-by: Etienne Carriere <etienne.carriere@linaro.org> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > --- > drivers/reset/reset-scmi.c | 1 + > 1 file changed, 1 insertion(+) > > Hi Philipp, > > I can either take this via ARM SoC as the driver is getting merged through > ARM SoC tree, or you can apply this once it gets landed in mainline. > I am fine with whatever you prefer. Feel free to take this in via ARM SoC directly, I see no need to wait for this to hit mainline. Acked-by: Philipp Zabel <p.zabel@pengutronix.de> regards Philipp
diff --git a/drivers/reset/reset-scmi.c b/drivers/reset/reset-scmi.c index c6d3c8427f14..b46df80ec6c3 100644 --- a/drivers/reset/reset-scmi.c +++ b/drivers/reset/reset-scmi.c @@ -102,6 +102,7 @@ static int scmi_reset_probe(struct scmi_device *sdev) data->rcdev.owner = THIS_MODULE; data->rcdev.of_node = np; data->rcdev.nr_resets = handle->reset_ops->num_domains_get(handle); + data->handle = handle; return devm_reset_controller_register(dev, &data->rcdev); }
scmi_reset_data->handle needs to be initialised at probe, so that it can be used to access scmi reset protocol apis using the same later. Since it was tested with a module that obtained handle elsewhere, it was missed easily. Add the missing scmi_reset_data->handle initialisation to fix the issue. Fixes: c8ae9c2da1cc ("reset: Add support for resets provided by SCMI") Cc: Philipp Zabel <p.zabel@pengutronix.de> Reported-by: Etienne Carriere <etienne.carriere@linaro.org> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- drivers/reset/reset-scmi.c | 1 + 1 file changed, 1 insertion(+) Hi Philipp, I can either take this via ARM SoC as the driver is getting merged through ARM SoC tree, or you can apply this once it gets landed in mainline. I am fine with whatever you prefer. Regards, Sudeep -- 2.17.1