| Message ID | 20191002095736.1297224-1-arnd@arndb.de |
|---|---|
| State | New |
| Headers | show |
| Series | input: ixp4xx-beeper: include linux/io.h | expand |
On Wed, Oct 2, 2019 at 11:57 AM Arnd Bergmann <arnd@arndb.de> wrote: > asm/io.h may not be included implicitly, causing a rare > randconfig build error: > > drivers/input/misc/ixp4xx-beeper.c:48:3: error: implicit declaration of function '__raw_writel' [-Werror,-Wimplicit-function-declaration] > __raw_writel((count & ~IXP4XX_OST_RELOAD_MASK) | IXP4XX_OST_ENABLE, > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> I am thinking a bit about the future of this driver. Isn't it more reasonable to just make a hrtimer-driven PWM and use the existing PWM userspace ABI and timer framework in Linux for this? Not that there is a generic timer-driven PWM but ... that is essentially what this driver is. Yours, Linus Walleij
On Wed, Oct 2, 2019 at 11:57 AM Arnd Bergmann <arnd@arndb.de> wrote: > > asm/io.h may not be included implicitly, causing a rare > randconfig build error: > > drivers/input/misc/ixp4xx-beeper.c:48:3: error: implicit declaration of function '__raw_writel' [-Werror,-Wimplicit-function-declaration] > __raw_writel((count & ~IXP4XX_OST_RELOAD_MASK) | IXP4XX_OST_ENABLE, > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Please ignore, this does not apply to mainline and is probably only needed on top of another patch that I will submit in the future. Arnd
diff --git a/drivers/input/misc/ixp4xx-beeper.c b/drivers/input/misc/ixp4xx-beeper.c index 764cf21c0aaf..456325f0ea59 100644 --- a/drivers/input/misc/ixp4xx-beeper.c +++ b/drivers/input/misc/ixp4xx-beeper.c @@ -17,6 +17,7 @@ #include <linux/platform_device.h> #include <linux/interrupt.h> #include <linux/gpio.h> +#include <linux/io.h> MODULE_AUTHOR("Alessandro Zummo <a.zummo@towertech.it>"); MODULE_DESCRIPTION("ixp4xx beeper driver");
asm/io.h may not be included implicitly, causing a rare randconfig build error: drivers/input/misc/ixp4xx-beeper.c:48:3: error: implicit declaration of function '__raw_writel' [-Werror,-Wimplicit-function-declaration] __raw_writel((count & ~IXP4XX_OST_RELOAD_MASK) | IXP4XX_OST_ENABLE, Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/input/misc/ixp4xx-beeper.c | 1 + 1 file changed, 1 insertion(+) -- 2.20.0