diff mbox series

[v2,5/7] exec: Restrict TARGET_PAGE_BITS_VARY assert to CONFIG_DEBUG_TCG

Message ID 20191023154505.30521-6-richard.henderson@linaro.org
State Superseded
Headers show
Series exec: Improve code for TARGET_PAGE_BITS_VARY | expand

Commit Message

Richard Henderson Oct. 23, 2019, 3:45 p.m. UTC 
This reduces the size of a release build by about 10k.
Noticably, within the tlb miss helpers.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

---
 include/exec/cpu-all.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

-- 
2.17.1

Comments

Alex Bennée Oct. 25, 2019, 2:44 p.m. UTC | #1 
Richard Henderson <richard.henderson@linaro.org> writes:

> This reduces the size of a release build by about 10k.

> Noticably, within the tlb miss helpers.

>

> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Reviewed-by: Alex Bennée <alex.bennee@linaro.org>


> ---

>  include/exec/cpu-all.h | 6 +++++-

>  1 file changed, 5 insertions(+), 1 deletion(-)

>

> diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h

> index 76515dc8d9..d3e4660d50 100644

> --- a/include/exec/cpu-all.h

> +++ b/include/exec/cpu-all.h

> @@ -219,7 +219,11 @@ extern const TargetPageBits target_page;

>  #else

>  extern TargetPageBits target_page;

>  # endif

> -#define TARGET_PAGE_BITS (assert(target_page.decided), target_page.bits)

> +# ifdef CONFIG_DEBUG_TCG

> +#  define TARGET_PAGE_BITS (assert(target_page.decided), target_page.bits)

> +# else

> +#  define TARGET_PAGE_BITS target_page.bits

> +# endif

>  #else

>  #define TARGET_PAGE_BITS_MIN TARGET_PAGE_BITS

>  #endif



--
Alex Bennée
diff mbox series

Patch

diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h
index 76515dc8d9..d3e4660d50 100644
--- a/include/exec/cpu-all.h
+++ b/include/exec/cpu-all.h
@@ -219,7 +219,11 @@  extern const TargetPageBits target_page;
 #else
 extern TargetPageBits target_page;
 # endif
-#define TARGET_PAGE_BITS (assert(target_page.decided), target_page.bits)
+# ifdef CONFIG_DEBUG_TCG
+#  define TARGET_PAGE_BITS (assert(target_page.decided), target_page.bits)
+# else
+#  define TARGET_PAGE_BITS target_page.bits
+# endif
 #else
 #define TARGET_PAGE_BITS_MIN TARGET_PAGE_BITS
 #endif