[v2,07/12] linux-user/sparc: Fix WREG usage in setup_frame

Message ID	20191025113921.9412-8-richard.henderson@linaro.org
State	Superseded
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; From: Richard Henderson <richard.henderson@linaro.org> To: qemu-devel@nongnu.org Subject: [PATCH v2 07/12] linux-user/sparc: Fix WREG usage in setup_frame Date: Fri, 25 Oct 2019 07:39:16 -0400 Message-Id: <20191025113921.9412-8-richard.henderson@linaro.org> In-Reply-To: <20191025113921.9412-1-richard.henderson@linaro.org> References: <20191025113921.9412-1-richard.henderson@linaro.org> Precedence: list Cc: alex.bennee@linaro.org, laurent@vivier.eu Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+patch=linaro.org@nongnu.org>
Series	linux-user sparc fixes \| expand [v2,00/12] linux-user sparc fixes [v2,01/12] scripts/qemu-binfmt-conf: Update for sparc64 [v2,02/12] tests/tcg/multiarch/linux-test: Fix error check for shmat [v2,03/12] target/sparc: Define an enumeration for accessing env->regwptr [v2,04/12] linux-user/sparc: Use WREG constants in sparc/target_cpu.h [v2,05/12] linux-user/sparc: Begin using WREG constants in sparc/signal.c [v2,06/12] linux-user/sparc: Use WREG_SP constant in sparc/signal.c [v2,07/12] linux-user/sparc: Fix WREG usage in setup_frame [v2,08/12] linux-user/sparc64: Fix target_signal_frame [v2,09/12] linux-user: Rename cpu_clone_regs to cpu_clone_regs_child [v2,10/12] linux-user: Introduce cpu_clone_regs_parent [v2,11/12] linux-user/sparc: Fix cpu_clone_regs_* [v2,12/12] linux-user/alpha: Set r20 secondary return value

Message ID

20191025113921.9412-8-richard.henderson@linaro.org

State

Superseded

Headers

Received-SPF: pass (google.com: domain of
	qemu-devel-bounces+patch=linaro.org@nongnu.org designates
	209.51.188.17 as permitted sender) client-ip=209.51.188.17; 
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PATCH v2 07/12] linux-user/sparc: Fix WREG usage in setup_frame
Date: Fri, 25 Oct 2019 07:39:16 -0400
Message-Id: <20191025113921.9412-8-richard.henderson@linaro.org>
In-Reply-To: <20191025113921.9412-1-richard.henderson@linaro.org>
References: <20191025113921.9412-1-richard.henderson@linaro.org>
Precedence: list
Cc: alex.bennee@linaro.org, laurent@vivier.eu
Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org
Sender: "Qemu-devel" <qemu-devel-bounces+patch=linaro.org@nongnu.org>

Series

linux-user sparc fixes | expand

Commit Message

Richard Henderson Oct. 25, 2019, 11:39 a.m. UTC

Use WREG_I0 not WREG_O0 in order to properly save the "ins".
The "outs" were saved separately in setup___siginfo.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

---
 linux-user/sparc/signal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.17.1

Comments

Laurent Vivier Nov. 5, 2019, 9:50 a.m. UTC | #1

Le 25/10/2019 à 13:39, Richard Henderson a écrit :
> Use WREG_I0 not WREG_O0 in order to properly save the "ins".

> The "outs" were saved separately in setup___siginfo.

> 

> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

> ---

>  linux-user/sparc/signal.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/linux-user/sparc/signal.c b/linux-user/sparc/signal.c

> index 0db4c5f84f..efb0df7e2b 100644

> --- a/linux-user/sparc/signal.c

> +++ b/linux-user/sparc/signal.c

> @@ -192,7 +192,7 @@ void setup_frame(int sig, struct target_sigaction *ka,

>          __put_user(env->regwptr[i + WREG_L0], &sf->ss.locals[i]);

>      }

>      for (i = 0; i < 8; i++) {

> -        __put_user(env->regwptr[i + WREG_O0], &sf->ss.ins[i]);

> +        __put_user(env->regwptr[i + WREG_I0], &sf->ss.ins[i]);

>      }

>      if (err)

>          goto sigsegv;

> 


Applied to my linux-user branch.

Thanks,
Laurent

diff --git a/linux-user/sparc/signal.c b/linux-user/sparc/signal.c
index 0db4c5f84f..efb0df7e2b 100644
--- a/linux-user/sparc/signal.c
+++ b/linux-user/sparc/signal.c
@@ -192,7 +192,7 @@  void setup_frame(int sig, struct target_sigaction *ka,
         __put_user(env->regwptr[i + WREG_L0], &sf->ss.locals[i]);
     }
     for (i = 0; i < 8; i++) {
-        __put_user(env->regwptr[i + WREG_O0], &sf->ss.ins[i]);
+        __put_user(env->regwptr[i + WREG_I0], &sf->ss.ins[i]);
     }
     if (err)
         goto sigsegv;

[v2,07/12] linux-user/sparc: Fix WREG usage in setup_frame

Commit Message

Comments

Patch