| Message ID | 1371801922-15142-4-git-send-email-ryan.harkin@linaro.org |
|---|---|
| State | New |
| Headers | show |
In your patch, I fixed (Revision 14439): - the !ifndef syntax to use '!ifndef EDK2_ARMVE_STANDALONE' - Moved the previous condition that uses EDK2_ARMVE_STANDALONE after your definition > -----Original Message----- > From: Ryan Harkin [mailto:ryan.harkin@linaro.org] > Sent: 21 June 2013 09:05 > To: ryan.harkin@linaro.org; edk2-devel@lists.sourceforge.net; > patches@linaro.org; boot-architecture@lists.linaro.org; Olivier Martin > Subject: [PATCH 3/9] ArmPlatformPkg/ArmVExpressPkg: CTA9x4: default to > EDK2_ARMVE_STANDALONE=1 > > This patch changes the Versatile Express A9 BSP to build with > EDK2_ARMVE_STANDALONE=1 as the default option. > > The user may then specify zero if they wish to build the non-standalone > version. > > Signed-off-by: Ryan Harkin <ryan.harkin@linaro.org> > --- > .../ArmVExpressPkg/ArmVExpress-CTA9x4.dsc | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA9x4.dsc > b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA9x4.dsc > index b4040c2..e805b57 100644 > --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA9x4.dsc > +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA9x4.dsc > @@ -30,6 +30,9 @@ > BUILD_TARGETS = DEBUG|RELEASE > SKUID_IDENTIFIER = DEFAULT > FLASH_DEFINITION = > ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA9x4.fdf > +!ifndef $(EDK2_ARMVE_STANDALONE) > + DEFINE EDK2_ARMVE_STANDALONE=1 > +!endif > > !include ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc > > -- > 1.7.9.5 >
On 21 June 2013 12:11, Olivier Martin <olivier.martin@arm.com> wrote: > In your patch, I fixed (Revision 14439): > - the !ifndef syntax to use '!ifndef EDK2_ARMVE_STANDALONE' Thanks! > - Moved the previous condition that uses EDK2_ARMVE_STANDALONE after your > definition Surely if you want to change the OUTPUT_DIRECTORY, you should update the build script to allow you to over-ride the value in the DSC file ;-) (I'll hide now :-)) > > > > >> -----Original Message----- >> From: Ryan Harkin [mailto:ryan.harkin@linaro.org] >> Sent: 21 June 2013 09:05 >> To: ryan.harkin@linaro.org; edk2-devel@lists.sourceforge.net; >> patches@linaro.org; boot-architecture@lists.linaro.org; Olivier Martin >> Subject: [PATCH 3/9] ArmPlatformPkg/ArmVExpressPkg: CTA9x4: default to >> EDK2_ARMVE_STANDALONE=1 >> >> This patch changes the Versatile Express A9 BSP to build with >> EDK2_ARMVE_STANDALONE=1 as the default option. >> >> The user may then specify zero if they wish to build the non-standalone >> version. >> >> Signed-off-by: Ryan Harkin <ryan.harkin@linaro.org> >> --- >> .../ArmVExpressPkg/ArmVExpress-CTA9x4.dsc | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA9x4.dsc >> b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA9x4.dsc >> index b4040c2..e805b57 100644 >> --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA9x4.dsc >> +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA9x4.dsc >> @@ -30,6 +30,9 @@ >> BUILD_TARGETS = DEBUG|RELEASE >> SKUID_IDENTIFIER = DEFAULT >> FLASH_DEFINITION = >> ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA9x4.fdf >> +!ifndef $(EDK2_ARMVE_STANDALONE) >> + DEFINE EDK2_ARMVE_STANDALONE=1 >> +!endif >> >> !include ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc >> >> -- >> 1.7.9.5 >> > > > > > > _______________________________________________ > boot-architecture mailing list > boot-architecture@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/boot-architecture
diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA9x4.dsc b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA9x4.dsc index b4040c2..e805b57 100644 --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA9x4.dsc +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA9x4.dsc @@ -30,6 +30,9 @@ BUILD_TARGETS = DEBUG|RELEASE SKUID_IDENTIFIER = DEFAULT FLASH_DEFINITION = ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA9x4.fdf +!ifndef $(EDK2_ARMVE_STANDALONE) + DEFINE EDK2_ARMVE_STANDALONE=1 +!endif !include ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc
This patch changes the Versatile Express A9 BSP to build with EDK2_ARMVE_STANDALONE=1 as the default option. The user may then specify zero if they wish to build the non-standalone version. Signed-off-by: Ryan Harkin <ryan.harkin@linaro.org> --- .../ArmVExpressPkg/ArmVExpress-CTA9x4.dsc | 3 +++ 1 file changed, 3 insertions(+)