| Message ID | 20191210145345.11616-16-sudeep.holla@arm.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | firmware: arm_scmi: Add support for multiple device per protocol | expand |
Hi Sudeep, On Tue, 2019-12-10 at 14:53 +0000, Sudeep Holla wrote: > The scmi bus now has support to match the driver with devices not only > based on their protocol id but also based on their device name if one is > available. This was added to cater the need to support multiple devices > and drivers for the same protocol. > > Let us add the name "reset" to scmi_device_id table in the driver so > that in matches only with device with the same name and protocol id > SCMI_PROTOCOL_RESET. > > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > --- > drivers/reset/reset-scmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/reset/reset-scmi.c b/drivers/reset/reset-scmi.c > index b46df80ec6c3..8d3a858e3b19 100644 > --- a/drivers/reset/reset-scmi.c > +++ b/drivers/reset/reset-scmi.c > @@ -108,7 +108,7 @@ static int scmi_reset_probe(struct scmi_device *sdev) > } > > static const struct scmi_device_id scmi_id_table[] = { > - { SCMI_PROTOCOL_RESET }, > + { SCMI_PROTOCOL_RESET, "reset" }, > { }, > }; > MODULE_DEVICE_TABLE(scmi, scmi_id_table); > -- > 2.17.1 I can't speak to the correctness of this approach, but in case the rest of the series passes review, this patch is Acked-by: Philipp Zabel <p.zabel@pengutronix.de> to be merged together with the other patches. regards Philipp
On Wed, Dec 11, 2019 at 10:51:41AM +0100, Philipp Zabel wrote: > Hi Sudeep, > > On Tue, 2019-12-10 at 14:53 +0000, Sudeep Holla wrote: > > The scmi bus now has support to match the driver with devices not only > > based on their protocol id but also based on their device name if one is > > available. This was added to cater the need to support multiple devices > > and drivers for the same protocol. > > > > Let us add the name "reset" to scmi_device_id table in the driver so > > that in matches only with device with the same name and protocol id > > SCMI_PROTOCOL_RESET. > > > > Cc: Philipp Zabel <p.zabel@pengutronix.de> > > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > > --- > > drivers/reset/reset-scmi.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/reset/reset-scmi.c b/drivers/reset/reset-scmi.c > > index b46df80ec6c3..8d3a858e3b19 100644 > > --- a/drivers/reset/reset-scmi.c > > +++ b/drivers/reset/reset-scmi.c > > @@ -108,7 +108,7 @@ static int scmi_reset_probe(struct scmi_device *sdev) > > } > > > > static const struct scmi_device_id scmi_id_table[] = { > > - { SCMI_PROTOCOL_RESET }, > > + { SCMI_PROTOCOL_RESET, "reset" }, > > { }, > > }; > > MODULE_DEVICE_TABLE(scmi, scmi_id_table); > > -- > > 2.17.1 > > I can't speak to the correctness of this approach, but in case the rest > of the series passes review, this patch is > I understand that and completely depends on the review of the patches implementing it. > Acked-by: Philipp Zabel <p.zabel@pengutronix.de> > > to be merged together with the other patches. > Thanks. -- Regards, Sudeep
diff --git a/drivers/reset/reset-scmi.c b/drivers/reset/reset-scmi.c index b46df80ec6c3..8d3a858e3b19 100644 --- a/drivers/reset/reset-scmi.c +++ b/drivers/reset/reset-scmi.c @@ -108,7 +108,7 @@ static int scmi_reset_probe(struct scmi_device *sdev) } static const struct scmi_device_id scmi_id_table[] = { - { SCMI_PROTOCOL_RESET }, + { SCMI_PROTOCOL_RESET, "reset" }, { }, }; MODULE_DEVICE_TABLE(scmi, scmi_id_table);
The scmi bus now has support to match the driver with devices not only based on their protocol id but also based on their device name if one is available. This was added to cater the need to support multiple devices and drivers for the same protocol. Let us add the name "reset" to scmi_device_id table in the driver so that in matches only with device with the same name and protocol id SCMI_PROTOCOL_RESET. Cc: Philipp Zabel <p.zabel@pengutronix.de> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- drivers/reset/reset-scmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1