diff mbox

[Branch,~linaro-validation/lava-dashboard/trunk] Rev 412: Fix bug #1197338.

Message ID 20130703153315.9695.71538.launchpad@ackee.canonical.com
State Accepted
Headers show

Commit Message

Stevan Radakovic July 3, 2013, 3:33 p.m. UTC 
Merge authors:
  Stevan Radaković (stevanr)
Related merge proposals:
  https://code.launchpad.net/~stevanr/lava-dashboard/fix-1197338/+merge/172838
  proposed by: Stevan Radaković (stevanr)
------------------------------------------------------------
revno: 412 [merge]
committer: Stevan Radakovic <stevan.radakovic@linaro.org>
branch nick: trunk
timestamp: Wed 2013-07-03 17:03:46 +0200
message:
  Fix bug #1197338.
modified:
  dashboard_app/static/dashboard_app/js/image-report.js


--
lp:lava-dashboard
https://code.launchpad.net/~linaro-validation/lava-dashboard/trunk

You are subscribed to branch lp:lava-dashboard.
To unsubscribe from this branch go to https://code.launchpad.net/~linaro-validation/lava-dashboard/trunk/+edit-subscription
diff mbox

Patch

=== modified file 'dashboard_app/static/dashboard_app/js/image-report.js'
--- dashboard_app/static/dashboard_app/js/image-report.js	2013-07-03 11:42:45 +0000
+++ dashboard_app/static/dashboard_app/js/image-report.js	2013-07-03 14:48:22 +0000
@@ -33,12 +33,13 @@ 
 function update_filters(column_data, test_run_names) {
     for (iter in column_data) {
 	build_number = column_data[iter]["number"].split('.')[0];
+	build_date = column_data[iter]["date"];
 	$("#build_number_start").append($('<option>', {
-	    value: build_number,
+	    value: build_date,
 	    text: build_number
 	}));
 	$("#build_number_end").append($('<option>', {
-	    value: build_number,
+	    value: build_date,
 	    text: build_number
 	}));
     }
@@ -76,7 +77,7 @@ 
 	build_number_end = parseInt(build_number_end);
     }
 
-    if (build_number_start >= build_number_end) {
+    if (build_number_start > build_number_end) {
 	alert("End build number must be greater then the start build number.");
 	return false;
     }
@@ -380,19 +381,7 @@ 
 function test_build_number(column_data, iter) {
     // Test if the build number/date is between specified number/date boundaries.
 
-    build_number = column_data[iter]["number"].split('.')[0];
-    if (isNumeric(build_number)) {
-	build_number = parseInt(build_number);
-    }
-
-    build_number_start = $("#build_number_start").val();
-    if (isNumeric(build_number_start)) {
-	build_number_start = parseInt(build_number_start);
-    }
-    build_number_end = $("#build_number_end").val();
-    if (isNumeric(build_number_end)) {
-	build_number_end = parseInt(build_number_end);
-    }
+    build_number = column_data[iter]["date"];
 
     if (build_number <= $("#build_number_end").val() && build_number >= $("#build_number_start").val()) {
 	return true;