| Message ID | 20200313180727.23044-1-robh@kernel.org |
|---|---|
| State | Accepted |
| Commit | 98878d9dfc7acbad56c3433f4166472fee56884f |
| Headers | show |
| Series | [v2] dt-bindings: display: ti: Fix dtc unit-address warnings in examples | expand |
On Fri, Mar 13, 2020 at 01:07:27PM -0500, Rob Herring wrote: > Extra dtc warnings (roughly what W=1 enables) are now enabled by default > when building the binding examples. These were fixed treewide in > 5.6-rc5, but some new display bindings have been added with new > warnings: > > Documentation/devicetree/bindings/display/ti/ti,am65x-dss.example.dts:21.27-49.11: Warning (unit_address_format): /example-0/dss@04a00000: unit name should not have leading 0s > Documentation/devicetree/bindings/display/ti/ti,j721e-dss.example.dts:21.27-72.11: Warning (unit_address_format): /example-0/dss@04a00000: unit name should not have leading 0s > Documentation/devicetree/bindings/display/ti/ti,k2g-dss.example.dts:20.27-42.11: Warning (unit_address_format): /example-0/dss@02540000: unit name should not have leading 0s > > Cc: Jyri Sarha <jsarha@ti.com> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> > Signed-off-by: Rob Herring <robh@kernel.org> Reviewed-by: Sam Ravnborg <sam@ravnborg.org> > --- > v2: > - Drop panel fixes as there's another patch fixing the 3 panels plus > others. Will revisit the panel/ fixes patch and apply tomorrow. Sam > --- > Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml | 2 +- > Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml | 2 +- > Documentation/devicetree/bindings/display/ti/ti,k2g-dss.yaml | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml > index cac61a998203..aa5543a64526 100644 > --- a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml > +++ b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml > @@ -121,7 +121,7 @@ examples: > #include <dt-bindings/interrupt-controller/irq.h> > #include <dt-bindings/soc/ti,sci_pm_domain.h> > > - dss: dss@04a00000 { > + dss: dss@4a00000 { > compatible = "ti,am65x-dss"; > reg = <0x0 0x04a00000 0x0 0x1000>, /* common */ > <0x0 0x04a02000 0x0 0x1000>, /* vidl1 */ > diff --git a/Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml > index ade9b2f513f5..6d47cd7206c2 100644 > --- a/Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml > +++ b/Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml > @@ -154,7 +154,7 @@ examples: > #include <dt-bindings/interrupt-controller/irq.h> > #include <dt-bindings/soc/ti,sci_pm_domain.h> > > - dss: dss@04a00000 { > + dss: dss@4a00000 { > compatible = "ti,j721e-dss"; > reg = <0x00 0x04a00000 0x00 0x10000>, /* common_m */ > <0x00 0x04a10000 0x00 0x10000>, /* common_s0*/ > diff --git a/Documentation/devicetree/bindings/display/ti/ti,k2g-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,k2g-dss.yaml > index 385bd060ccf9..7cb37053e95b 100644 > --- a/Documentation/devicetree/bindings/display/ti/ti,k2g-dss.yaml > +++ b/Documentation/devicetree/bindings/display/ti/ti,k2g-dss.yaml > @@ -81,7 +81,7 @@ examples: > #include <dt-bindings/interrupt-controller/arm-gic.h> > #include <dt-bindings/interrupt-controller/irq.h> > > - dss: dss@02540000 { > + dss: dss@2540000 { > compatible = "ti,k2g-dss"; > reg = <0x02540000 0x400>, > <0x02550000 0x1000>, > -- > 2.20.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
On 13/03/2020 20:07, Rob Herring wrote: > Extra dtc warnings (roughly what W=1 enables) are now enabled by default > when building the binding examples. These were fixed treewide in > 5.6-rc5, but some new display bindings have been added with new > warnings: > > Documentation/devicetree/bindings/display/ti/ti,am65x-dss.example.dts:21.27-49.11: Warning (unit_address_format): /example-0/dss@04a00000: unit name should not have leading 0s > Documentation/devicetree/bindings/display/ti/ti,j721e-dss.example.dts:21.27-72.11: Warning (unit_address_format): /example-0/dss@04a00000: unit name should not have leading 0s > Documentation/devicetree/bindings/display/ti/ti,k2g-dss.example.dts:20.27-42.11: Warning (unit_address_format): /example-0/dss@02540000: unit name should not have leading 0s > > Cc: Jyri Sarha <jsarha@ti.com> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> > Signed-off-by: Rob Herring <robh@kernel.org> Acked-by: Jyri Sarha <jsarha@ti.com> > --- > v2: > - Drop panel fixes as there's another patch fixing the 3 panels plus > others. > --- > Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml | 2 +- > Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml | 2 +- > Documentation/devicetree/bindings/display/ti/ti,k2g-dss.yaml | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml > index cac61a998203..aa5543a64526 100644 > --- a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml > +++ b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml > @@ -121,7 +121,7 @@ examples: > #include <dt-bindings/interrupt-controller/irq.h> > #include <dt-bindings/soc/ti,sci_pm_domain.h> > > - dss: dss@04a00000 { > + dss: dss@4a00000 { > compatible = "ti,am65x-dss"; > reg = <0x0 0x04a00000 0x0 0x1000>, /* common */ > <0x0 0x04a02000 0x0 0x1000>, /* vidl1 */ > diff --git a/Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml > index ade9b2f513f5..6d47cd7206c2 100644 > --- a/Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml > +++ b/Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml > @@ -154,7 +154,7 @@ examples: > #include <dt-bindings/interrupt-controller/irq.h> > #include <dt-bindings/soc/ti,sci_pm_domain.h> > > - dss: dss@04a00000 { > + dss: dss@4a00000 { > compatible = "ti,j721e-dss"; > reg = <0x00 0x04a00000 0x00 0x10000>, /* common_m */ > <0x00 0x04a10000 0x00 0x10000>, /* common_s0*/ > diff --git a/Documentation/devicetree/bindings/display/ti/ti,k2g-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,k2g-dss.yaml > index 385bd060ccf9..7cb37053e95b 100644 > --- a/Documentation/devicetree/bindings/display/ti/ti,k2g-dss.yaml > +++ b/Documentation/devicetree/bindings/display/ti/ti,k2g-dss.yaml > @@ -81,7 +81,7 @@ examples: > #include <dt-bindings/interrupt-controller/arm-gic.h> > #include <dt-bindings/interrupt-controller/irq.h> > > - dss: dss@02540000 { > + dss: dss@2540000 { > compatible = "ti,k2g-dss"; > reg = <0x02540000 0x400>, > <0x02550000 0x1000>, > -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml index cac61a998203..aa5543a64526 100644 --- a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml +++ b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml @@ -121,7 +121,7 @@ examples: #include <dt-bindings/interrupt-controller/irq.h> #include <dt-bindings/soc/ti,sci_pm_domain.h> - dss: dss@04a00000 { + dss: dss@4a00000 { compatible = "ti,am65x-dss"; reg = <0x0 0x04a00000 0x0 0x1000>, /* common */ <0x0 0x04a02000 0x0 0x1000>, /* vidl1 */ diff --git a/Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml index ade9b2f513f5..6d47cd7206c2 100644 --- a/Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml +++ b/Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml @@ -154,7 +154,7 @@ examples: #include <dt-bindings/interrupt-controller/irq.h> #include <dt-bindings/soc/ti,sci_pm_domain.h> - dss: dss@04a00000 { + dss: dss@4a00000 { compatible = "ti,j721e-dss"; reg = <0x00 0x04a00000 0x00 0x10000>, /* common_m */ <0x00 0x04a10000 0x00 0x10000>, /* common_s0*/ diff --git a/Documentation/devicetree/bindings/display/ti/ti,k2g-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,k2g-dss.yaml index 385bd060ccf9..7cb37053e95b 100644 --- a/Documentation/devicetree/bindings/display/ti/ti,k2g-dss.yaml +++ b/Documentation/devicetree/bindings/display/ti/ti,k2g-dss.yaml @@ -81,7 +81,7 @@ examples: #include <dt-bindings/interrupt-controller/arm-gic.h> #include <dt-bindings/interrupt-controller/irq.h> - dss: dss@02540000 { + dss: dss@2540000 { compatible = "ti,k2g-dss"; reg = <0x02540000 0x400>, <0x02550000 0x1000>,
Extra dtc warnings (roughly what W=1 enables) are now enabled by default when building the binding examples. These were fixed treewide in 5.6-rc5, but some new display bindings have been added with new warnings: Documentation/devicetree/bindings/display/ti/ti,am65x-dss.example.dts:21.27-49.11: Warning (unit_address_format): /example-0/dss@04a00000: unit name should not have leading 0s Documentation/devicetree/bindings/display/ti/ti,j721e-dss.example.dts:21.27-72.11: Warning (unit_address_format): /example-0/dss@04a00000: unit name should not have leading 0s Documentation/devicetree/bindings/display/ti/ti,k2g-dss.example.dts:20.27-42.11: Warning (unit_address_format): /example-0/dss@02540000: unit name should not have leading 0s Cc: Jyri Sarha <jsarha@ti.com> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> Signed-off-by: Rob Herring <robh@kernel.org> --- v2: - Drop panel fixes as there's another patch fixing the 3 panels plus others. --- Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml | 2 +- Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml | 2 +- Documentation/devicetree/bindings/display/ti/ti,k2g-dss.yaml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) -- 2.20.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel