| Message ID | 1375105771-8106-3-git-send-email-vikas.sajjan@linaro.org |
|---|---|
| State | New |
| Headers | show |
Hi Vikas, Please see my comment inline. On Monday 29 of July 2013 19:19:26 Vikas Sajjan wrote: > Moves the properties of FIMD DT node which are common across Exynos5 based > SoCs like Exynos5250 and Exxynos5420 to exynos5.dtsi > > Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org> > --- > arch/arm/boot/dts/exynos5.dtsi | 10 ++++++++++ > arch/arm/boot/dts/exynos5250.dtsi | 6 +----- > 2 files changed, 11 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi > index f65e124..80a4630 100644 > --- a/arch/arm/boot/dts/exynos5.dtsi > +++ b/arch/arm/boot/dts/exynos5.dtsi > @@ -108,4 +108,14 @@ > interrupts = <0 42 0>; > status = "disabled"; > }; > + > + fimd { I don't know why this node was named incorrectly in original file (probably the patch adding it did not have enough review), but if you are modifying it anyway, could you fix it to be conformant to DT conventions? Whenever there is a reg property inside a node, the node should be named whatever@addr, where addr is comma separated list of addresses specified in reg property, in hex, without "0x" prefix. So in this case this should be at least fimd@14400000 but ideally display-controller@14400000 as nodes should have generic names (see ePAPR, paragraph 2.2.2). Best regards, Tomasz
diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi index f65e124..80a4630 100644 --- a/arch/arm/boot/dts/exynos5.dtsi +++ b/arch/arm/boot/dts/exynos5.dtsi @@ -108,4 +108,14 @@ interrupts = <0 42 0>; status = "disabled"; }; + + fimd { + compatible = "samsung,exynos5250-fimd"; + interrupt-parent = <&combiner>; + reg = <0x14400000 0x40000>; + interrupt-names = "fifo", "vsync", "lcd_sys"; + interrupts = <18 4>, <18 5>, <18 6>; + status = "disabled"; + }; + }; diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi index ef57277..20c32fc 100644 --- a/arch/arm/boot/dts/exynos5250.dtsi +++ b/arch/arm/boot/dts/exynos5250.dtsi @@ -631,12 +631,8 @@ }; fimd { - compatible = "samsung,exynos5250-fimd"; - interrupt-parent = <&combiner>; - reg = <0x14400000 0x40000>; - interrupt-names = "fifo", "vsync", "lcd_sys"; - interrupts = <18 4>, <18 5>, <18 6>; clocks = <&clock 133>, <&clock 339>; clock-names = "sclk_fimd", "fimd"; + status = "okay"; }; };
Moves the properties of FIMD DT node which are common across Exynos5 based SoCs like Exynos5250 and Exxynos5420 to exynos5.dtsi Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org> --- arch/arm/boot/dts/exynos5.dtsi | 10 ++++++++++ arch/arm/boot/dts/exynos5250.dtsi | 6 +----- 2 files changed, 11 insertions(+), 5 deletions(-)