| Message ID | 8f37155d1524de4298f7b1de08b3474fe2d97241.1375279948.git.viresh.kumar@linaro.org |
|---|---|
| State | New |
| Headers | show |
On Wed, Jul 31, 2013 at 07:49:11PM +0530, Viresh Kumar wrote: > CPUFreq core does following at multiple places: > module_{get|put}(cpufreq_driver->owner)). > > This is done to make sure module doesn't get unloaded if it is currently in use. > This will work only if the .owner field of cpufreq driver is initialized with a > valid pointer. > > This field wasn't initialized for this driver, lets initialize it with > THIS_MODULE. > > Cc: Shawn Guo <shawn.guo@linaro.org> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> For this and imx6q-cpufreq one, Acked-by: Shawn Guo <shawn.guo@linaro.org> > --- > drivers/cpufreq/cpufreq-cpu0.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.c > index ad1fde2..a087bf1 100644 > --- a/drivers/cpufreq/cpufreq-cpu0.c > +++ b/drivers/cpufreq/cpufreq-cpu0.c > @@ -169,6 +169,7 @@ static struct cpufreq_driver cpu0_cpufreq_driver = { > .init = cpu0_cpufreq_init, > .exit = cpu0_cpufreq_exit, > .name = "generic_cpu0", > + .owner = THIS_MODULE, > .attr = cpu0_cpufreq_attr, > }; > > -- > 1.7.12.rc2.18.g61b472e >
diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.c index ad1fde2..a087bf1 100644 --- a/drivers/cpufreq/cpufreq-cpu0.c +++ b/drivers/cpufreq/cpufreq-cpu0.c @@ -169,6 +169,7 @@ static struct cpufreq_driver cpu0_cpufreq_driver = { .init = cpu0_cpufreq_init, .exit = cpu0_cpufreq_exit, .name = "generic_cpu0", + .owner = THIS_MODULE, .attr = cpu0_cpufreq_attr, };
CPUFreq core does following at multiple places: module_{get|put}(cpufreq_driver->owner)). This is done to make sure module doesn't get unloaded if it is currently in use. This will work only if the .owner field of cpufreq driver is initialized with a valid pointer. This field wasn't initialized for this driver, lets initialize it with THIS_MODULE. Cc: Shawn Guo <shawn.guo@linaro.org> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/cpufreq/cpufreq-cpu0.c | 1 + 1 file changed, 1 insertion(+)