| Message ID | 20200523073639.7442-1-dinghao.liu@zju.edu.cn |
|---|---|
| State | Accepted |
| Commit | cf7b1c794d2f2362610143375b4156111e35aed5 |
| Headers | show |
| Series | media: camss: csid: Fix runtime PM imbalance in csid_set_power | expand |
diff --git a/drivers/media/platform/qcom/camss/camss-csid.c b/drivers/media/platform/qcom/camss/camss-csid.c index a5ae85674ffb..8a247b6f5550 100644 --- a/drivers/media/platform/qcom/camss/camss-csid.c +++ b/drivers/media/platform/qcom/camss/camss-csid.c @@ -562,8 +562,10 @@ static int csid_set_power(struct v4l2_subdev *sd, int on) u32 hw_version; ret = pm_runtime_get_sync(dev); - if (ret < 0) + if (ret < 0) { + pm_runtime_put_sync(dev); return ret; + } ret = regulator_enable(csid->vdda); if (ret < 0) {
pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> --- drivers/media/platform/qcom/camss/camss-csid.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)