| Message ID | 20200605142541.28412-4-amitx.k.singh@intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] bluez:load Generic access service | expand |
Hi Luiz, > -----Original Message----- > From: Luiz Augusto von Dentz <luiz.dentz@gmail.com> > Sent: Friday, June 5, 2020 10:34 PM > To: Singh, AmitX K <amitx.k.singh@intel.com> > Cc: linux-bluetooth@vger.kernel.org > Subject: Re: [PATCH 1/2] bluez:load Generic access service > > Hi Amit, > > On Fri, Jun 5, 2020 at 7:31 AM Amitsi5x <amitx.k.singh@intel.com> wrote: > > > > From: “AmitSingh” <amitx.k.singh@intel.com> > > > > It allow to load generic access service to database > > > > Signed-off-by: “AmitSingh” <amitx.k.singh@intel.com> > > --- > > src/gatt-client.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/src/gatt-client.c b/src/gatt-client.c index > > 20c3fbec2..2ae258da0 100644 > > --- a/src/gatt-client.c > > +++ b/src/gatt-client.c > > @@ -2009,9 +2009,6 @@ static void export_service(struct > gatt_db_attribute *attr, void *user_data) > > struct btd_gatt_client *client = user_data; > > struct service *service; > > > > - if (gatt_db_service_get_claimed(attr)) > > - return; > > - > > This is actually done on purpose in order to avoid extra traffic since the > daemon already exposes this information in other interfaces. > GAP service is not getting stored is hash database .To verify the PTS test case GATT/CL/GAD/BV-02-C which is GAP service discovery with '1800' UUID, verdicts as "INCONCLUSIVE" as it does not find the GAP UUID in place > > service = service_create(attr, client); > > if (!service) > > return; > > -- > > 2.17.1 > > -- > Luiz Augusto von Dentz
Hi Amit, On Thu, Jul 16, 2020 at 1:40 AM Singh, AmitX K <amitx.k.singh@intel.com> wrote: > > Hi Luiz, > > > -----Original Message----- > > From: Luiz Augusto von Dentz <luiz.dentz@gmail.com> > > Sent: Friday, June 5, 2020 10:34 PM > > To: Singh, AmitX K <amitx.k.singh@intel.com> > > Cc: linux-bluetooth@vger.kernel.org > > Subject: Re: [PATCH 1/2] bluez:load Generic access service > > > > Hi Amit, > > > > On Fri, Jun 5, 2020 at 7:31 AM Amitsi5x <amitx.k.singh@intel.com> wrote: > > > > > > From: “AmitSingh” <amitx.k.singh@intel.com> > > > > > > It allow to load generic access service to database > > > > > > Signed-off-by: “AmitSingh” <amitx.k.singh@intel.com> > > > --- > > > src/gatt-client.c | 3 --- > > > 1 file changed, 3 deletions(-) > > > > > > diff --git a/src/gatt-client.c b/src/gatt-client.c index > > > 20c3fbec2..2ae258da0 100644 > > > --- a/src/gatt-client.c > > > +++ b/src/gatt-client.c > > > @@ -2009,9 +2009,6 @@ static void export_service(struct > > gatt_db_attribute *attr, void *user_data) > > > struct btd_gatt_client *client = user_data; > > > struct service *service; > > > > > > - if (gatt_db_service_get_claimed(attr)) > > > - return; > > > - > > > > This is actually done on purpose in order to avoid extra traffic since the > > daemon already exposes this information in other interfaces. > > > > GAP service is not getting stored is hash database .To verify the PTS test case GATT/CL/GAD/BV-02-C which is GAP service discovery with '1800' UUID, verdicts as "INCONCLUSIVE" as it does not find the GAP UUID in place BlueZ does perform the so-called discover all service procedure, perhaps you need to select the procedure correctly in order to pass this test. > > > service = service_create(attr, client); > > > if (!service) > > > return; > > > -- > > > 2.17.1 > > > > -- > > Luiz Augusto von Dentz -- Luiz Augusto von Dentz
diff --git a/src/gatt-client.c b/src/gatt-client.c index 20c3fbec2..2ae258da0 100644 --- a/src/gatt-client.c +++ b/src/gatt-client.c @@ -2009,9 +2009,6 @@ static void export_service(struct gatt_db_attribute *attr, void *user_data) struct btd_gatt_client *client = user_data; struct service *service; - if (gatt_db_service_get_claimed(attr)) - return; - service = service_create(attr, client); if (!service) return;