diff mbox series

[v2,2/2] mx6ul_14x14_evk: Move CONFIG_DM_74X164 to defconfig

Message ID 20200129165803.16249-2-festevam@gmail.com
State Accepted
Commit 19ba4808c149e7bb0780b10d489c2b53c01334ea
Headers show
Series [v2,1/2] gpio: Let DM_74X164 be built without CONFIG_SPL_GPIO | expand

Commit Message

Fabio Estevam Jan. 29, 2020, 4:58 p.m. UTC
The CONFIG_DM_74X164 symbols should be moved to the defconfig file,
as indicated in the comments.

Signed-off-by: Fabio Estevam <festevam at gmail.com>
---
 configs/mx6ul_14x14_evk_defconfig | 1 +
 include/configs/mx6ul_14x14_evk.h | 5 -----
 2 files changed, 1 insertion(+), 5 deletions(-)

Comments

Tom Rini Jan. 29, 2020, 5:48 p.m. UTC | #1
On Wed, Jan 29, 2020 at 01:58:03PM -0300, Fabio Estevam wrote:

> The CONFIG_DM_74X164 symbols should be moved to the defconfig file,
> as indicated in the comments.
> 
> Signed-off-by: Fabio Estevam <festevam at gmail.com>

Reviewed-by: Tom Rini <trini at konsulko.com>
diff mbox series

Patch

diff --git a/configs/mx6ul_14x14_evk_defconfig b/configs/mx6ul_14x14_evk_defconfig
index 4fd311d2fb..029cc01285 100644
--- a/configs/mx6ul_14x14_evk_defconfig
+++ b/configs/mx6ul_14x14_evk_defconfig
@@ -44,6 +44,7 @@  CONFIG_DEFAULT_DEVICE_TREE="imx6ul-14x14-evk"
 CONFIG_ENV_IS_IN_MMC=y
 CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
+CONFIG_DM_74X164=y
 CONFIG_DM_I2C=y
 CONFIG_DM_MMC=y
 CONFIG_FSL_USDHC=y
diff --git a/include/configs/mx6ul_14x14_evk.h b/include/configs/mx6ul_14x14_evk.h
index 5cc15b6d2f..f347eeb39f 100644
--- a/include/configs/mx6ul_14x14_evk.h
+++ b/include/configs/mx6ul_14x14_evk.h
@@ -44,11 +44,6 @@ 
 #define CONFIG_SYS_I2C_SPEED		100000
 #endif
 
-/* Note: This is incorrect and should move to Kconfig / defconfig */
-#ifdef CONFIG_DM_GPIO
-#define CONFIG_DM_74X164
-#endif
-
 #define CONFIG_SYS_MMC_IMG_LOAD_PART	1
 
 #define CONFIG_EXTRA_ENV_SETTINGS \