diff mbox series

[v2] arm: k3: Consolidate and silence k3_fit_atf.sh call

Message ID 1598ba9e-bc95-ddcc-396a-609404975aa5@siemens.com
State Superseded
Headers show
Series [v2] arm: k3: Consolidate and silence k3_fit_atf.sh call | expand

Commit Message

Jan Kiszka July 1, 2020, 6:09 p.m. UTC 
From: Jan Kiszka <jan.kiszka at siemens.com>

Buiding u-boot-spl-k3[_HS].its is currently unconditionally verbose
about what it does. Change that by wrapping the call to k3_fit_atf.sh
into a cmd, also using that chance to reduce duplicate lines of makefile
code - only IS_HS=1 is different when CONFIG_TI_SECURE_DEVICE is on.

Signed-off-by: Jan Kiszka <jan.kiszka at siemens.com>
Acked-by: Lokesh Vutla <lokeshvutla at ti.com>
---

Change in v2:
 - add a commit message

 arch/arm/mach-k3/config.mk | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

Comments

Lokesh Vutla July 14, 2020, 5:42 a.m. UTC | #1 
On 01/07/20 11:39 pm, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka at siemens.com>
> 
> Buiding u-boot-spl-k3[_HS].its is currently unconditionally verbose
> about what it does. Change that by wrapping the call to k3_fit_atf.sh
> into a cmd, also using that chance to reduce duplicate lines of makefile
> code - only IS_HS=1 is different when CONFIG_TI_SECURE_DEVICE is on.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka at siemens.com>
> Acked-by: Lokesh Vutla <lokeshvutla at ti.com>


Applied to u-boot-ti.

Thanks and regards,
Lokesh
diff mbox series

Patch

diff --git a/arch/arm/mach-k3/config.mk b/arch/arm/mach-k3/config.mk
index f6b63db349..f7afef610c 100644
--- a/arch/arm/mach-k3/config.mk
+++ b/arch/arm/mach-k3/config.mk
@@ -48,22 +48,23 @@  ALL-y	+= tiboot3.bin
 endif
 
 ifdef CONFIG_ARM64
+
 ifeq ($(CONFIG_TI_SECURE_DEVICE),y)
 SPL_ITS := u-boot-spl-k3_HS.its
-$(SPL_ITS): FORCE
-	IS_HS=1 \
-	$(srctree)/tools/k3_fit_atf.sh \
-	$(patsubst %,$(obj)/dts/%.dtb,$(subst ",,$(CONFIG_SPL_OF_LIST))) > $@
-
+$(SPL_ITS): export IS_HS=1
 ALL-y	+= tispl.bin_HS
 else
 SPL_ITS := u-boot-spl-k3.its
-$(SPL_ITS): FORCE
+ALL-y	+= tispl.bin
+endif
+
+quiet_cmd_k3_mkits = MKITS   $@
+cmd_k3_mkits = \
 	$(srctree)/tools/k3_fit_atf.sh \
 	$(patsubst %,$(obj)/dts/%.dtb,$(subst ",,$(CONFIG_SPL_OF_LIST))) > $@
 
-ALL-y	+= tispl.bin
-endif
+$(SPL_ITS): FORCE
+	$(call cmd,k3_mkits)
 endif
 
 else